Return-Path: X-Original-To: apmail-ignite-issues-archive@minotaur.apache.org Delivered-To: apmail-ignite-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9F19C1862D for ; Thu, 10 Dec 2015 07:42:11 +0000 (UTC) Received: (qmail 1125 invoked by uid 500); 10 Dec 2015 07:42:11 -0000 Delivered-To: apmail-ignite-issues-archive@ignite.apache.org Received: (qmail 1071 invoked by uid 500); 10 Dec 2015 07:42:11 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 1044 invoked by uid 99); 10 Dec 2015 07:42:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Dec 2015 07:42:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id F107F2C1F57 for ; Thu, 10 Dec 2015 07:42:10 +0000 (UTC) Date: Thu, 10 Dec 2015 07:42:10 +0000 (UTC) From: "Semen Boikov (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-1355) Potential NPE in CacheAffinityProxy MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050260#comment-15050260 ] Semen Boikov commented on IGNITE-1355: -------------------------------------- Changes look good, but I see minor issues in GridAffinityProcessor: - line 894: '@Nullable private AffinityInfo cache() throws IgniteCheckedException {' - please remove '@Nullable' here - line 895: unnesessary call 'ctx.discovery().topologyVersionEx();', please remove > Potential NPE in CacheAffinityProxy > ----------------------------------- > > Key: IGNITE-1355 > URL: https://issues.apache.org/jira/browse/IGNITE-1355 > Project: Ignite > Issue Type: Bug > Components: cache > Affects Versions: ignite-1.4 > Reporter: Semen Boikov > Assignee: Artem Shutak > Priority: Critical > Fix For: 1.6 > > > NPE was observed on TC: > {noformat} > java.lang.NullPointerException > at org.apache.ignite.internal.processors.affinity.GridAffinityProcessor$AffinityInfo.access$1800(GridAffinityProcessor.java:537) > at org.apache.ignite.internal.processors.affinity.GridAffinityProcessor$CacheAffinityProxy.mapPartitionToPrimaryAndBackups(GridAffinityProcessor.java:879) > at org.apache.ignite.testframework.junits.common.GridCommonAbstractTest.awaitPartitionMapExchange(GridCommonAbstractTest.java:423) > at org.apache.ignite.internal.processors.cache.distributed.dht.IgniteCacheCrossCacheTxFailoverTest.crossCacheTxFailover(IgniteCacheCrossCacheTxFailoverTest.java:355) > {noformat} > As I see method CacheAffinityProxy.cache() can return null, but there are no checks for null. -- This message was sent by Atlassian JIRA (v6.3.4#6332)