ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Denis Magda (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-1900) Ignite JMX problem with Spring Boot
Date Tue, 17 Nov 2015 13:41:10 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008643#comment-15008643
] 

Denis Magda commented on IGNITE-1900:
-------------------------------------

Reviewed, checked, merged to ignite-1.5.

Thanks for the contribution! In addition, please, trigger TeamCity tests for changes validation
manually. I've updated related section recently:
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-1.CreateGitHubpull-request

> Ignite JMX problem with Spring Boot
> -----------------------------------
>
>                 Key: IGNITE-1900
>                 URL: https://issues.apache.org/jira/browse/IGNITE-1900
>             Project: Ignite
>          Issue Type: Bug
>          Components: 1.4
>    Affects Versions: ignite-1.4
>            Reporter: wmz7year
>            Assignee: wmz7year
>              Labels: patch
>             Fix For: 1.5
>
>
> I use Ignite with Spring Boot.
> When start application,Spring Boot will register JMX info.
> In IgniteMXBean interface,There is two method getUserAttributesFormatted and getLifecycleBeansFormatted
return Collection<String>
> But In JMX DefaultMXBeanMappingFactory.makeParameterizedTypeMapping method will get method
return type.
> {noformat}
>  final Type rawType = objType.getRawType();
>         if (rawType instanceof Class<?>) {
>             Class<?> c = (Class<?>) rawType;
>             if (c == List.class || c == Set.class || c == SortedSet.class) {
>                 Type[] actuals = objType.getActualTypeArguments();
>                 assert(actuals.length == 1);
>                 if (c == SortedSet.class)
>                     mustBeComparable(c, actuals[0]);
>                 return makeArrayOrCollectionMapping(objType, actuals[0], factory);
>             } else {
>                 boolean sortedMap = (c == SortedMap.class);
>                 if (c == Map.class || sortedMap) {
>                     Type[] actuals = objType.getActualTypeArguments();
>                     assert(actuals.length == 2);
>                     if (sortedMap)
>                         mustBeComparable(c, actuals[0]);
>                     return makeTabularMapping(objType, sortedMap,
>                             actuals[0], actuals[1], factory);
>                 }
>             }
>         }
> {noformat}
> The Collection<String> will not match any type for this although IgniteKernal return
type is Set or List.
> I think IgniteMXBean interface should change Collection to Set and List



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message