ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-1759) .Net: Guid read/write is not platform-safe.
Date Thu, 22 Oct 2015 10:37:27 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968931#comment-14968931
] 

ASF GitHub Bot commented on IGNITE-1759:
----------------------------------------

GitHub user ptupitsyn opened a pull request:

    https://github.com/apache/ignite/pull/171

    IGNITE-1759 .Net: Guid read/write is not platform-safe.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ptupitsyn/ignite ignite-1759

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/171.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #171
    
----
commit 52698b17068475536752c9ec9e6cc0a36b18ebaa
Author: ptupitsyn <ptupitsyn@gridgain.com>
Date:   2015-10-21T17:28:47Z

    wip todos

commit 77132979501ba32f27cc31f35bdedee1ddaa3486
Author: ptupitsyn <ptupitsyn@gridgain.com>
Date:   2015-10-22T09:04:10Z

    Endianness issue fixed

commit d5173706035a45936993902156198c41f88b8ce6
Author: ptupitsyn <ptupitsyn@gridgain.com>
Date:   2015-10-22T09:41:20Z

    WriteGuidBytewise

commit 3996dc01e3fbf05ceebc25d5a8a04ec977bc5ec6
Author: ptupitsyn <ptupitsyn@gridgain.com>
Date:   2015-10-22T10:07:12Z

    wip

commit 022300a1421359d57a598189f91787fd62532b47
Author: ptupitsyn <ptupitsyn@gridgain.com>
Date:   2015-10-22T10:09:34Z

    GetIsGuidSequentialPacked improved check

commit 6733894c879bf139002a4340858f7979ca48d16b
Author: ptupitsyn <ptupitsyn@gridgain.com>
Date:   2015-10-22T10:11:24Z

    wip

commit ddc5fc4c3f2f1425c39f0692c2d29c43d7239ef4
Author: ptupitsyn <ptupitsyn@gridgain.com>
Date:   2015-10-22T10:11:59Z

    Merge remote-tracking branch 'remotes/upstream/ignite-1282' into ignite-1759

----


> .Net: Guid read/write is not platform-safe.
> -------------------------------------------
>
>                 Key: IGNITE-1759
>                 URL: https://issues.apache.org/jira/browse/IGNITE-1759
>             Project: Ignite
>          Issue Type: Bug
>          Components: interop
>    Affects Versions: ignite-1.4
>            Reporter: Vladimir Ozerov
>            Assignee: Pavel  Tupitsyn
>            Priority: Critical
>             Fix For: 1.5
>
>
> Two problems here:
> 1) We do not count for endiannes, so byte shifts might be invalid.
> 2) Guid doesn't have fixed layout. For this reason there are no guarantees that it will
take 16 bytes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message