ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Semen Boikov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-1272) PortableMarshaller: issues when different class loaders are used
Date Mon, 26 Oct 2015 17:05:27 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14974552#comment-14974552
] 

Semen Boikov commented on IGNITE-1272:
--------------------------------------

Denis,

I don't like that if message contains EntryProcessor then 'addDepInfo' is set to 'true' for
all objects in the message (and e.g. 'prepareObject' will be unnecessarily called for keys),
I think it is better to initialize 'addDepInfo' flag inside 'prepareMarshal' method.

> PortableMarshaller: issues when different class loaders are used
> ----------------------------------------------------------------
>
>                 Key: IGNITE-1272
>                 URL: https://issues.apache.org/jira/browse/IGNITE-1272
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: ignite-1.4
>            Reporter: Denis Magda
>            Assignee: Semen Boikov
>            Priority: Blocker
>             Fix For: 1.5
>
>         Attachments: ignite-1272.patch, ignite-1272.patch
>
>
> The reason is that a loader is not passed to required places when needed.
> Reproduced with the following tests:
> - {{IgniteCacheAbstractExecutionContextTest.testUserClassLoader()}} fails with PortableMarshaller
enabled.
> - {{GridDeploymentMessageCountSelfTest.testCacheValueDeploymentOnPut()}}
> Another issue is when {{PortableContext}} returns {{PortableClassDescriptor}} by type
id. Returned descriptor has a constructor which already has been loaded with another class
loader. Fix is not trivial and issue is reproduced with {{GridP2PRemoteClassLoadersSelfTest}}
> Look for corresponding TODOs in the code.
> Unmute tests when fixed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message