Return-Path: X-Original-To: apmail-ignite-issues-archive@minotaur.apache.org Delivered-To: apmail-ignite-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D858B180B4 for ; Fri, 11 Sep 2015 01:34:45 +0000 (UTC) Received: (qmail 79458 invoked by uid 500); 11 Sep 2015 01:34:45 -0000 Delivered-To: apmail-ignite-issues-archive@ignite.apache.org Received: (qmail 79429 invoked by uid 500); 11 Sep 2015 01:34:45 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 79419 invoked by uid 99); 11 Sep 2015 01:34:45 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Sep 2015 01:34:45 +0000 Date: Fri, 11 Sep 2015 01:34:45 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-1402) Logging uses root logger in some cases MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739989#comment-14739989 ] ASF GitHub Bot commented on IGNITE-1402: ---------------------------------------- GitHub user vkulichenko opened a pull request: https://github.com/apache/ignite/pull/82 IGNITE-1402 - Fixed logging categories You can merge this pull request into a Git repository by running: $ git pull https://github.com/vkulichenko/incubator-ignite ignite-1402 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/82.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #82 ---- commit ed6984644a3a575f1f0ffb5eb9b834ad855f8fae Author: Valentin Kulichenko Date: 2015-09-11T01:31:56Z IGNITE-1402 - Fixed logging categories ---- > Logging uses root logger in some cases > -------------------------------------- > > Key: IGNITE-1402 > URL: https://issues.apache.org/jira/browse/IGNITE-1402 > Project: Ignite > Issue Type: Bug > Components: general > Reporter: Valentin Kulichenko > Assignee: Valentin Kulichenko > Priority: Blocker > Labels: user-request > Fix For: ignite-1.4 > > > {{GridKernalContext.log()}} method returns root logger which should not be used by any of Ignite classes. This can cause the following scenario: > # User configures logger with DEBUG level as default and INFO level for {{org.apache.ignite}} package. > # Ignite class takes logger using {{GridKernalContext.log()}} and checks if debug is enabled. It will get true regardless of the settings for Ignite package. > There are places in code that uses {{GridKernalContext.log()}} method incorrectly, so it should be removed. We should always use {{GridKernalContext.log(Class cls)}} properly specifying the category. -- This message was sent by Atlassian JIRA (v6.3.4#6332)