ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-1402) Logging uses root logger in some cases
Date Fri, 11 Sep 2015 01:34:45 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739989#comment-14739989

ASF GitHub Bot commented on IGNITE-1402:

GitHub user vkulichenko opened a pull request:


    IGNITE-1402 - Fixed logging categories


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vkulichenko/incubator-ignite ignite-1402

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #82
commit ed6984644a3a575f1f0ffb5eb9b834ad855f8fae
Author: Valentin Kulichenko <valentin.kulichenko@gmail.com>
Date:   2015-09-11T01:31:56Z

    IGNITE-1402 - Fixed logging categories


> Logging uses root logger in some cases
> --------------------------------------
>                 Key: IGNITE-1402
>                 URL: https://issues.apache.org/jira/browse/IGNITE-1402
>             Project: Ignite
>          Issue Type: Bug
>          Components: general
>            Reporter: Valentin Kulichenko
>            Assignee: Valentin Kulichenko
>            Priority: Blocker
>              Labels: user-request
>             Fix For: ignite-1.4
> {{GridKernalContext.log()}} method returns root logger which should not be used by any
of Ignite classes. This can cause the following scenario:
> # User configures logger with DEBUG level as default and INFO level for {{org.apache.ignite}}
> # Ignite class takes logger using {{GridKernalContext.log()}} and checks if debug is
enabled. It will get true regardless of the settings for Ignite package.
> There are places in code that uses {{GridKernalContext.log()}} method incorrectly, so
it should be removed. We should always use {{GridKernalContext.log(Class<?> cls)}} properly
specifying the category.

This message was sent by Atlassian JIRA

View raw message