ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Artem Shutak (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-788) add support for log4j2 into org.apache.ignite.logger.log4j package (Log4J2Logger)
Date Tue, 07 Jul 2015 19:03:05 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617193#comment-14617193
] 

Artem Shutak commented on IGNITE-788:
-------------------------------------

1 - ok. Looks better.

As I said before, you have a lot of formatting issues: blinked lines, Override annotations
not on needed lines, not optimized imports and etc.

I've created a review-patch (https://issues.apache.org/jira/secure/attachment/12742899/ignite-788-review.patch)
for your previous patch (https://issues.apache.org/jira/secure/attachment/12742320/ignite-sprint-5_ignite-788.patch).
Can you please apply my patch to your patch and look at all changes which I done. 

For example, you should not use your full IGNITE_HOME. It will not work on another machins
and on TC.

2. We have new Gti Workflow, so patches have to be done against master branch, so you need
merge master to you changes before creating a patch.

P.S. I expected, that you 
- apply my review patch to your patch, 
- fix "2- Change the format of the log files."
- create new patch with all changes (your and mine).
Can you please do it?

Thanks,
Artem.

> add support for log4j2 into org.apache.ignite.logger.log4j package (Log4J2Logger)
> ---------------------------------------------------------------------------------
>
>                 Key: IGNITE-788
>                 URL: https://issues.apache.org/jira/browse/IGNITE-788
>             Project: Ignite
>          Issue Type: New Feature
>          Components: general, newbie
>    Affects Versions: sprint-3
>            Reporter: Yakov Zhdanov
>            Assignee: Gianfranco Murador
>              Labels: newbie
>             Fix For: sprint-7
>
>         Attachments: ignite-788-review.patch, ignite-sprint-5_ignite-788.patch, ignite-sprint-5_ignite-788.patch,
ignite-sprint-5_ignite-788.patch, patch-ingnite-788.zip
>
>
> This should be a new module. See {{ignite-log4j}} module for reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message