ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Atri Sharma (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-1006) Add hostnames() method to ClusterGroup to get all hostnames in current ClusterGroup
Date Tue, 23 Jun 2015 11:39:01 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597505#comment-14597505
] 

Atri Sharma commented on IGNITE-1006:
-------------------------------------

I am not sure if I understood your comments correctly.

For your concern about not reusing ClusterGroupAdapter#nodes, I mentioned that I cannot see
a clear mechanism of reusing existing nodes() (without major refactoring of ClusterGroupAdapter#nodes
which I try to avoid since ClusterGroupAdapter#nodes is a heavily used method). If there is
a method I missed, please let me know.

For the tests, test I added gets all the hostnames for test cluster using new method, gets
localnode's hostnames and tests if all of localnode's hostnames are present in hostnames result
returned by hostNames() method. I did not understand your concern around it (is it that test
cluster might have single node)? Please elaborate a bit.

> Add hostnames() method to ClusterGroup to get all hostnames in current ClusterGroup
> -----------------------------------------------------------------------------------
>
>                 Key: IGNITE-1006
>                 URL: https://issues.apache.org/jira/browse/IGNITE-1006
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Atri Sharma
>            Assignee: Atri Sharma
>         Attachments: ignite-sprint-5_ignite-1006ver3.patch
>
>
> We should have method like nodes() in ClusterGroup to allow getting all hostnames currently
in this ClusterGroup. Method should ensure handling for duplicates as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message