ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Artem Shutak (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-788) add support for log4j2 into org.apache.ignite.logger.log4j package (Log4J2Logger)
Date Tue, 30 Jun 2015 18:43:05 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608846#comment-14608846
] 

Artem Shutak commented on IGNITE-788:
-------------------------------------

Hi, Gianfranco!

I've done review of your patch and create a patch file which can be applied to your patch.
You can see review there.

1. Can you, please, config your IDE to use spaces for indention instead of tabulation.
2. It would be great to see log4j2-test.xml configured as log4j-test.xml and then we wiil
be able to get the same logs at console and at a log files. Can you do it please?

Thanks,
Artem.

> add support for log4j2 into org.apache.ignite.logger.log4j package (Log4J2Logger)
> ---------------------------------------------------------------------------------
>
>                 Key: IGNITE-788
>                 URL: https://issues.apache.org/jira/browse/IGNITE-788
>             Project: Ignite
>          Issue Type: New Feature
>          Components: general, newbie
>    Affects Versions: sprint-3
>            Reporter: Yakov Zhdanov
>            Assignee: Gianfranco Murador
>              Labels: newbie
>             Fix For: sprint-7
>
>         Attachments: ignite-788-review.patch, ignite-sprint-5_ignite-788.patch, ignite-sprint-5_ignite-788.patch,
patch-ingnite-788.zip
>
>
> This should be a new module. See {{ignite-log4j}} module for reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message