ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-456) [Public TC] Need to complete patch validation mechanism.
Date Tue, 19 May 2015 17:56:01 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550882#comment-14550882

Konstantin Boudnik commented on IGNITE-456:

Actually, there's no security issue with this. Quoting my reply to the dev@:
Here's two reasons why current approach is secure enough (and in fact has
been used for some time on Apache build infrastructure):

- only project contributors can manipulate JIRA: attaching, changing
  state, etc. Don't we trust our contributors?
- if TC agents aren't running as privileged user - and they shouldn't be -
  malicious code won't do any harm to the system.

> [Public TC] Need to complete patch validation mechanism.
> --------------------------------------------------------
>                 Key: IGNITE-456
>                 URL: https://issues.apache.org/jira/browse/IGNITE-456
>             Project: Ignite
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: sprint-1
>            Reporter: Konstantin Boudnik
>            Assignee: Artem Shutak
>            Priority: Blocker
>             Fix For: sprint-5
>         Attachments: ignite-456-patch-validation-2.txt, patch-456-2.file, patch-456.file
> h4. Original task scope: "Public TC test builds need to accept the optional parameter"
> Test builds should be able to accept the following optional parameter:
> - JIRA number
> If the parameter is passed in, then an extra build step needs to be execute to get the
latest attachment from the JIRA ticket and {{git am}} it into the local Ignite repo before
running the tests.
> Important to notice, the the patch needs to be applied once before running all required
tests. At some late point we might add the logic to only run tests in the affected modules,
but it could be a bit of a challenge. 
> h4. New scope of task
> - find way to run TC build with paramether from another build - Done
> - configure new task to run all Ignite builds
> - configure task to get all NEW patches from JIRAs and run them on TC
> To check:
> - comment on jira for which builds were started
> - tasks for each patch started once
> Current issues:
> - curl does not work properly on agents

This message was sent by Atlassian JIRA

View raw message