ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Muzafarov <mmu...@apache.org>
Subject Re: [VOTE] Allow or prohibit a joint use of @deprecated and @IgniteExperimental
Date Mon, 10 Feb 2020 13:35:50 GMT
+1

I think we are talking about huge API reorganization, not a simple renaming [1].

[1]
https://docs.oracle.com/javase/8/docs/technotes/guides/javadoc/deprecation/deprecation.html

On Mon, 10 Feb 2020 at 16:32, Ilya Kasnacheev <ilya.kasnacheev@gmail.com> wrote:
>
> Hello!
>
> +1 because it is possible that old API is obviously going away some time in
> the future, such as if it is inherently unsafe.
>
> I don't see why we should not indicate this fact as soon as it is known.
>
> Experimental API can implement partial or complete fix but not be
> stabilized yet. In fact, it is partial replacements that I'm worried about.
>
> Also, imagine we have some API already deprecated, and we want to add new
> experimental feature for the same purpose, at least partially.
> This means we either can't add it, can't mark as IgniteExperimental, or we
> have to un-deprecate old API, which is silly.
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> пн, 10 февр. 2020 г. в 15:34, Alexei Scherbakov <
> alexey.scherbakoff@gmail.com>:
>
> > -1 because it's controversial to deprecation rules [1]
> >
> > [1]
> >
> > https://docs.oracle.com/javase/8/docs/technotes/guides/javadoc/deprecation/deprecation.html
> >
> >
> >
> > пн, 10 февр. 2020 г. в 14:03, Вячеслав Коптилин <slava.koptilin@gmail.com
> > >:
> >
> > > -1 Prohibit
> > >
> > > We should not deprecate old API unless the new one will be released as a
> > > stable version.
> > >
> > > Thanks,
> > > S.
> > >
> > >
> > > пн, 10 февр. 2020 г. в 13:19, Dmitriy Govorukhin <
> > > dmitriy.govorukhin@gmail.com>:
> > >
> > > > -1 Prohibit
> > > >
> > > > On Mon, Feb 10, 2020 at 12:58 PM Pavel Tupitsyn <ptupitsyn@apache.org>
> > > > wrote:
> > > >
> > > > > -1 Prohibit
> > > > >
> > > > > On Mon, Feb 10, 2020 at 12:41 PM Zhenya Stanilovsky
> > > > > <arzamas123@mail.ru.invalid> wrote:
> > > > >
> > > > > >
> > > > > > -1, sounds confusing, i wan`t use deprecated API
> > > > > > and @IgniteExperimental it`s something unknown with undefined
«time
> > > for
> > > > > > support».
> > > > > >
> > > > > >
> > > > > >
> > > > > > >Dear Apache Ignite community,
> > > > > > >
> > > > > > >We would like to conduct a formal vote on the subject of
whether
> > to
> > > > > allow
> > > > > > >or prohibit a joint existence of @deprecated annotation
for an old
> > > API
> > > > > > >and @IgniteExperimental [1] for a new (replacement) API.
The
> > result
> > > of
> > > > > > this
> > > > > > >vote will be formalized as an Apache Ignite development
rule to be
> > > > used
> > > > > in
> > > > > > >future.
> > > > > > >
> > > > > > >The discussion thread where you can address all non-vote
messages
> > is
> > > > > [2].
> > > > > > >
> > > > > > >The votes are:
> > > > > > >*[+1 Allow]* Allow to deprecate the old APIs even when new
APIs
> > are
> > > > > marked
> > > > > > >with @IgniteExperimental to explicitly notify users that
an old
> > APIs
> > > > > will
> > > > > > >be removed in the next major release AND new APIs are available.
> > > > > > >*[-1 Prohibit]* Never deprecate the old APIs unless the
new APIs
> > are
> > > > > > stable
> > > > > > >and released without @IgniteExperimental. The old APIs javadoc
may
> > > be
> > > > > > >updated with a reference to new APIs to encourage users
to
> > evaluate
> > > > new
> > > > > > >APIs. The deprecation and new API release may happen
> > simultaneously
> > > if
> > > > > the
> > > > > > >new API is not marked with @IgniteExperimental or the annotation
> > is
> > > > > > removed
> > > > > > >in the same release.
> > > > > > >
> > > > > > >Neither of the choices prohibits deprecation of an API without
a
> > > > > > >replacement if community decides so.
> > > > > > >
> > > > > > >The vote will hold for 72 hours and will end on February
13th 2020
> > > > 08:00
> > > > > > >UTC:
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > https://www.timeanddate.com/countdown/to?year=2020&month=2&day=13&hour=8&min=0&sec=0&p0=utc-1
> > > > > > >
> > > > > > >All votes count, there is no binding/non-binding status
for this.
> > > > > > >
> > > > > > >[1]
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/lang/IgniteExperimental.java
> > > > > > >[2]
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSS-Public-API-deprecation-rules-td45647.html
> > > > > > >
> > > > > > >Thanks,
> > > > > > >--AG
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> >
> > --
> >
> > Best regards,
> > Alexei Scherbakov
> >

Mime
View raw message