From dev-return-49304-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Jan 24 10:15:09 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8818918064E for ; Fri, 24 Jan 2020 11:15:09 +0100 (CET) Received: (qmail 92710 invoked by uid 500); 24 Jan 2020 10:15:08 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 92693 invoked by uid 99); 24 Jan 2020 10:15:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Jan 2020 10:15:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id F3F7A180B7E for ; Fri, 24 Jan 2020 10:15:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.001 X-Spam-Level: X-Spam-Status: No, score=0.001 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Glmu8rzcB04r for ; Fri, 24 Jan 2020 10:15:06 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.222.47; helo=mail-ua1-f47.google.com; envelope-from=alexey.goncharuk@gmail.com; receiver= Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id 96137BC50F for ; Fri, 24 Jan 2020 10:15:06 +0000 (UTC) Received: by mail-ua1-f47.google.com with SMTP id 59so573388uap.12 for ; Fri, 24 Jan 2020 02:15:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Ow2aaSKvKerd6Gd/HHV9ET+GCfw704VAunA9iaA058U=; b=lNQUcrqI5bFnwXBWtTl7VDX65cqZidQTG1LWye1qRWkUjaM5KOh+PMTuxk3F00eWlj HPNZ2V3KzmObyhNUpNkWcYLQpmzqWb5Ct+FwDDR9Lxs2EpD4MCOd5VhdCVHfyr2B6zmY NUhreI39YaXvWyZRoU8m8A4KJL4DJvH5mmGTG4ViyPrNzTt7Y7ijuRyw86ofqyznkyz0 4IN/CTA72ZVJK4LM8utl35Z6a2MhV01/tH/aQUfw2I82zEQRL1duzLa8aCQrZMhqrlN8 L477pwzxJk3GQazV8wBvHYnXaRDYb1aM6mUhhpPLG9jp0wGzVjF84zk3x3LDgADhSB/Z RlEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Ow2aaSKvKerd6Gd/HHV9ET+GCfw704VAunA9iaA058U=; b=CHNZzypbOLE6bLjYs80b1xWdGZYXNKpj6xhDNlMRR+U3PyWcljA5fkvm3N3iRSJ6DG fmRUuj9rmNH6WnkcXY5vz2IkpTAvgG2mUpX0ud1v++w2Y/Lb51Izl4ocMm1jOCNJhmS0 pWKFAOvs0ZfX4SKWLHym+T9cTUzstlPfzOthDqB5h3MhdBdwH5PsiPHsKCvICjVM7z/5 TxiohjXgXTYBZWp/J7ZJixeoImISEbVLMEyZL96CdLWZwybpk5vZrDXtaX3tA8g942Kl 0NX19iy+VtEdA30kf/Ne98b6fNQS+wPb6H5CDpSPFkMIGcmvYx9u0xsIrZzugyMk6W+P rhgw== X-Gm-Message-State: APjAAAXRF4kt8ct0bkQupk+QKTCEKRRKvG6BDjLrpQHMQeV/kjU9JFfO ZuN7ON9lZznmkPm0STZQlL7HPv/3Qy/ggvph/hmNAQ== X-Google-Smtp-Source: APXvYqzpouZRTxNwLJDG976tbJ5OQGrOfLOuBSuCXqRZBWF/Bw4fub6kjM2mczlW96BgN8Niok88vXr/XYJwnuSjGhA= X-Received: by 2002:ab0:2ea8:: with SMTP id y8mr1372938uay.23.1579860900038; Fri, 24 Jan 2020 02:15:00 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alexey Goncharuk Date: Fri, 24 Jan 2020 13:14:49 +0300 Message-ID: Subject: Re: [DISCUSS] ThreadGroup for IgniteThread To: dev Content-Type: multipart/alternative; boundary="000000000000bdca92059ce00769" --000000000000bdca92059ce00769 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ivan, I believe that the removal of the thread group is harmless. Let's check with the rest of the community, and if there is no objections, remove it. =D0=BF=D1=82, 24 =D1=8F=D0=BD=D0=B2. 2020 =D0=B3. =D0=B2 11:13, Ivan Pavluk= hin : > Alex, > > > We can either remove it (not sure if this is a breaking public API > change?) > > or create a separate thread group per Ignite instance and pass it to th= e > > constructor of IgniteThread (quite a lot of refactoring). > > Recently there were a discussion about "magic stuff" in codebase. And > it seems that we should eliminate such stuff if there is no chance to > understand why is it needed. > > I run TC after dropping special ThreadGroup and did not get any new > failures [1]. It can imagine that dedicated ThreadGroup has some sense > for application servers. But personally I would prefer to get rid of > that ThreadGroup. A more conservative approach is to use some flag > (system property) to control it. > > [1] > https://mtcga.gridgain.com/pr.html?serverId=3Dapache&suiteId=3DIgniteTest= s24Java8_RunAll&branchForTc=3Dpull/7297/head&action=3DLatest > > =D0=B2=D1=82, 21 =D1=8F=D0=BD=D0=B2. 2020 =D0=B3. =D0=B2 16:39, Alexey Go= ncharuk >: > > > > Ivan, > > > > I cannot recall why exactly a separate thread group was needed. I guess > the > > intention was to collect all threads related to Ignite to one group, bu= t > I > > see no practical use of that particular implementation. > > > > We can either remove it (not sure if this is a breaking public API > change?) > > or create a separate thread group per Ignite instance and pass it to th= e > > constructor of IgniteThread (quite a lot of refactoring). > > > > =D0=B2=D1=82, 21 =D1=8F=D0=BD=D0=B2. 2020 =D0=B3. =D0=B2 13:17, Ivan Pa= vlukhin : > > > > > Hi, > > > > > > As you might know, IgniteThread class captures calling ThreadGroup on > > > initialization (as IgniteThread.DFLT_GRP) and includes all new ignite > > > threads into this group. A user reported an issue [1] related to it. > > > And the root cause here is that captured DFLT_GRP is out of control o= f > > > IgniteThread class. Looks like a design fault. Consequently several > > > unclear points: > > > 1. What is the real need for IgniteThread.DFLT_GRP? > > > 2. Can we simply stop using this trick? > > > 3. Could there be any better options to do the same? > > > > > > Please share your thoughts. > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-12554 > > > > > > -- > > > Best regards, > > > Ivan Pavlukhin > > > > > > > -- > Best regards, > Ivan Pavlukhin > --000000000000bdca92059ce00769--