From dev-return-49212-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Tue Jan 21 13:30:11 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BDC82180657 for ; Tue, 21 Jan 2020 14:30:10 +0100 (CET) Received: (qmail 40849 invoked by uid 500); 21 Jan 2020 13:30:10 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 40837 invoked by uid 99); 21 Jan 2020 13:30:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Jan 2020 13:30:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 53149C2279 for ; Tue, 21 Jan 2020 13:30:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id wnCAUBHXfbDf for ; Tue, 21 Jan 2020 13:30:03 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::e35; helo=mail-vs1-xe35.google.com; envelope-from=alexey.goncharuk@gmail.com; receiver= Received: from mail-vs1-xe35.google.com (mail-vs1-xe35.google.com [IPv6:2607:f8b0:4864:20::e35]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 260117DDD3 for ; Tue, 21 Jan 2020 13:30:01 +0000 (UTC) Received: by mail-vs1-xe35.google.com with SMTP id k188so1736151vsc.8 for ; Tue, 21 Jan 2020 05:30:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=lO0F9qsC6Q/folaZ8Ui+uZ6tsyC5ed6zkqFKNKsd02Y=; b=FEEWw53Ax0KTHIXIJBRQEQsULu/tVZchQBvEFyUJ7aFHLbPmw4Id440FTguMPZ24jM CH28YxuZyi1a28LRNmPQ/Zl6eRfsXjrv2CqOxtH6WjpQIoFtiaV8KsRls8aiwPC/AUJo MC2U5yLGgVnPwGdfehZpUnplM9behlb6OtT+pXjTDQULq0aHKPxzQUqgAZvsLdVHTNCQ LTaa5e35hvw2w0kxwZJxcZR7DUMN4fw2a/P5tBx1u9r38ietaTU9rjBfs+BNAc6asHNQ jf5ZbRZ9vbnMO4GVKPrqULg3h5Aj5k5p2+T0f7xrq4MJRnb/Bx/eM6GinqMTkUe6FvW/ PH1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=lO0F9qsC6Q/folaZ8Ui+uZ6tsyC5ed6zkqFKNKsd02Y=; b=gSdTnoFYSK/iq5o9kkIv/mHq5eX0uEmX6FE+6KcVu5Royi/21E9voaGeA/DyL8aCJU wve71oN20he+Z+vAJr6GF5juKsma8osXt5wNpQ1rGIBzFUIg7W/Z+isspW1iA/6JxSNm ozuI4ZzvARDlu6NtOrRCWEnmMdTP+HT8MmKol1iBrdGAgLhbqDcneAbrwRg6W/C19Nuc Xy/NIHtvJXzJfkl/bYEYotaZSAeVSnUCdFbrgUjQvK9dh69+fudsNVN+85hHEmpT1unV IJnpOfnXTREBvLCxlDKa9nVDQ1hYp47OtowhqmrXX06orUE9AxjllrNlGiXcKaNZmn/J D76Q== X-Gm-Message-State: APjAAAWNt+c0neLKKkatHACGtFFZP/5KTXFFz+wMeAmYNkfPzZFAMDzD 85+OkFIKGDDGZZDY2SWC92d+/IUpETLSHF1PkFoY4yt8 X-Google-Smtp-Source: APXvYqx0AnAwazysYOrkhd+LDxeHewkJ9oJlNCTbmssCaEBKTI9iCu5pEKU8wB8vuykGU0Do183XUQzjA+GlxPoprtk= X-Received: by 2002:a67:fd17:: with SMTP id f23mr2759019vsr.100.1579613394649; Tue, 21 Jan 2020 05:29:54 -0800 (PST) MIME-Version: 1.0 References: <797FBB02-134C-4210-AF6F-D8D0E9DC82AE@gmail.com> In-Reply-To: From: Alexey Goncharuk Date: Tue, 21 Jan 2020 16:29:43 +0300 Message-ID: Subject: Re: Master compilation error To: dev Content-Type: multipart/alternative; boundary="000000000000454447059ca667ee" --000000000000454447059ca667ee Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable That's what I was using, it did not compile ignite-compatibility for me. Thanks for Petr, the following command worked: mvn clean package -U -Pall-java,all-scala,scala,licenses,lgpl,examples,tensorflow,checkstyle -DskipTests -Dmaven.javadoc.skip=3Dtrue =D0=BF=D0=BD, 20 =D1=8F=D0=BD=D0=B2. 2020 =D0=B3. =D0=B2 18:59, Ilya Kasnac= heev : > Hello! > > I do the following: > > mvn clean install -DskipTests -Dmaven.javadoc.skip=3Dtrue > -Dmaven.scaladoc.skip=3Dtrue -Plgpl > > Maybe -Pall-java is needed actually, though, it will not check C++ and .N= et > anyway :-/ > > Regards, > -- > Ilya Kasnacheev > > > =D0=BF=D0=BD, 20 =D1=8F=D0=BD=D0=B2. 2020 =D0=B3. =D0=B2 16:35, Alexey Go= ncharuk >: > > > Ok, now I'm confused: what is a kosher command to check the build > locally? > > > > =D0=BF=D0=BD, 20 =D1=8F=D0=BD=D0=B2. 2020 =D0=B3. =D0=B2 15:38, Alexey = Goncharuk < > alexey.goncharuk@gmail.com > > >: > > > > > Master is fixed. > > > > > > =D0=BF=D0=BD, 20 =D1=8F=D0=BD=D0=B2. 2020 =D0=B3. =D0=B2 15:08, Alexe= y Goncharuk < > > alexey.goncharuk@gmail.com > > > >: > > > > > >> Will fix the compilation shortly, apologies for not checking locally= . > > >> > > >> An additional compilation attempt is a good idea, but: first, I > believe, > > >> there is still an option to merge a PR directly to apache git, secon= d > - > > >> when running a check, we need to make sure that master gets > > fast-forwarded > > >> exactly to the revision that was checked (though, it will help to > avoid > > a > > >> lot of concurrent merge failures). I have no enough experience with > > Github, > > >> so I am not sure if this is possible. > > >> > > >> =D0=BF=D0=BD, 20 =D1=8F=D0=BD=D0=B2. 2020 =D0=B3. =D0=B2 14:40, Anto= n Vinogradov : > > >> > > >>> Also, is it possible to perform the same check on the merge attempt= ? > > >>> > > >>> Each PR can be merged from GitHub page, can we append check to the > > "megre > > >>> button" flow? > > >>> Can we restrict merges bypassing this button? > > >>> > > >>> On Mon, Jan 20, 2020 at 2:17 PM Anton Vinogradov > > wrote: > > >>> > > >>> > Should we perform an additional compilation attempt on > pull/xxx/merge > > >>> at > > >>> > each visa request? > > >>> > > > >>> > On Mon, Jan 20, 2020 at 1:56 PM Pavel Tupitsyn < > ptupitsyn@apache.org > > > > > >>> > wrote: > > >>> > > > >>> >> > Main question is "how this may happen in case fix got the Visa > [2] > > >>> ?". > > >>> >> This can happen because of other changes in master. > > >>> >> "Visa" truly works only when master is in the same state during > the > > >>> merge > > >>> >> as it was during TC run. > > >>> >> > > >>> >> On Mon, Jan 20, 2020 at 1:50 PM Anton Vinogradov > > >>> wrote: > > >>> >> > > >>> >> > It seems, this because of IGNITE-12227 fix [1]. > > >>> >> > Main question is "how this may happen in case fix got the Visa > [2] > > >>> ?". > > >>> >> > > > >>> >> > [1] > > >>> >> > > > >>> >> > > > >>> >> > > >>> > > > https://ci.ignite.apache.org/viewModification.html?modId=3D895719&persona= l=3Dfalse&buildTypeId=3DIgniteTests24Java8_BuildApacheIgnite&tab=3DvcsModif= icationFiles > > >>> >> > [2] > > >>> >> > > > >>> >> > > > >>> >> > > >>> > > > https://issues.apache.org/jira/browse/IGNITE-12227?focusedCommentId=3D170= 18135&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:comment-tabpan= el#comment-17018135 > > >>> >> > > > >>> >> > On Mon, Jan 20, 2020 at 1:43 PM =D0=9D=D0=B8=D0=BA=D0=BE=D0=BB= =D0=B0=D0=B9 =D0=98=D0=B6=D0=B8=D0=BA=D0=BE=D0=B2 < > > nizhikov@apache.org > > >>> > > > >>> >> > wrote: > > >>> >> > > > >>> >> > > Hello. Igniters. > > >>> >> > > > > >>> >> > > Master build fails: > > >>> >> > > > > >>> >> > > > > >>> >> > > > > >>> >> > > > >>> >> > > >>> > > > https://ci.ignite.apache.org/viewLog.html?buildId=3D4944107&buildTypeId= =3DIgniteTests24Java8_BuildApacheIgnite&tab=3DbuildLog&branch_IgniteTests24= Java8=3Dpull%2F7269%2Fhead > > >>> >> > > > > >>> >> > > [13:37:02][Step 3/4] [ERROR] Failed to execute goal > > >>> >> > > org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompi= le > > >>> >> > > (default-testCompile) on project ignite-core: Compilation > > failure: > > >>> >> > > Compilation failure: > > >>> >> > > [13:37:02][Step 3/4] [ERROR] > > >>> >> > > > > >>> >> > > > >>> >> > > >>> > > > /opt/buildagent/work/7bc1c54bc719b67c/modules/core/src/test/java/org/apac= he/ignite/internal/processors/cache/transactions/TxPartitionCounterStateCon= sistencyVolatileRebalanceTest.java:[25,1] > > >>> >> > > cannot find symbol > > >>> >> > > [13:37:02][Step 3/4] [ERROR] symbol: static > > >>> >> > > IGNITE_BASELINE_AUTO_ADJUST_ENABLED > > >>> >> > > [13:37:02][Step 3/4] [ERROR] location: class > > >>> >> > > [13:37:02][Step 3/4] [ERROR] > > >>> >> > > > > >>> >> > > > >>> >> > > >>> > > > /opt/buildagent/work/7bc1c54bc719b67c/modules/core/src/test/java/org/apac= he/ignite/internal/processors/cache/transactions/TxPartitionCounterStateAbs= tractTest.java:[162,28] > > >>> >> > > cannot find symbol > > >>> >> > > [13:37:02][Step 3/4] [ERROR] symbol: variable > > >>> >> > > IGNITE_BASELINE_AUTO_ADJUST_ENABLED > > >>> >> > > [13:37:02][Step 3/4] [ERROR] location: class > > >>> >> > > > > >>> >> > > > >>> >> > > >>> > > > org.apache.ignite.internal.processors.cache.transactions.TxPartitionCount= erStateAbstractTest > > >>> >> > > [13:37:02][Step 3/4] [ERROR] > > >>> >> > > > > >>> >> > > > >>> >> > > >>> > > > /opt/buildagent/work/7bc1c54bc719b67c/modules/core/src/test/java/org/apac= he/ignite/internal/processors/cache/transactions/TxPartitionCounterStateCon= sistencyVolatileRebalanceTest.java:[40,28] > > >>> >> > > cannot find symbol > > >>> >> > > [13:37:02][Step 3/4] [ERROR] symbol: variable > > >>> >> > > IGNITE_BASELINE_AUTO_ADJUST_ENABLED > > >>> >> > > [13:37:02][Step 3/4] [ERROR] location: class > > >>> >> > > > > >>> >> > > > >>> >> > > >>> > > > org.apache.ignite.internal.processors.cache.transactions.TxPartitionCount= erStateConsistencyVolatileRebalanceTest > > >>> >> > > [13:37:02][Step 3/4] [ERROR] > > >>> >> > > > > >>> >> > > > >>> >> > > >>> > > > /opt/buildagent/work/7bc1c54bc719b67c/modules/core/src/test/java/org/apac= he/ignite/internal/processors/cache/transactions/TxPartitionCounterStateCon= sistencyVolatileRebalanceTest.java:[47,30] > > >>> >> > > cannot find symbol > > >>> >> > > [13:37:02][Step 3/4] [ERROR] symbol: variable > > >>> >> > > IGNITE_BASELINE_AUTO_ADJUST_ENABLED > > >>> >> > > [13:37:02][Step 3/4] [ERROR] location: class > > >>> >> > > > > >>> >> > > > >>> >> > > >>> > > > org.apache.ignite.internal.processors.cache.transactions.TxPartitionCount= erStateConsistencyVolatileRebalanceTest > > >>> >> > > > > >>> >> > > > > >>> >> > > > >>> >> > > >>> > > > >>> > > >> > > > --000000000000454447059ca667ee--