From dev-return-48950-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Mon Dec 30 14:55:57 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1783E180657 for ; Mon, 30 Dec 2019 15:55:56 +0100 (CET) Received: (qmail 91159 invoked by uid 500); 30 Dec 2019 14:55:56 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 91147 invoked by uid 99); 30 Dec 2019 14:55:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Dec 2019 14:55:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 71EB11A3225 for ; Mon, 30 Dec 2019 14:55:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.052 X-Spam-Level: X-Spam-Status: No, score=0.052 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id QM9T7gvTF4v7 for ; Mon, 30 Dec 2019 14:55:54 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.210.42; helo=mail-ot1-f42.google.com; envelope-from=vololo100@gmail.com; receiver= Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id 34D0FBC509 for ; Mon, 30 Dec 2019 14:55:54 +0000 (UTC) Received: by mail-ot1-f42.google.com with SMTP id h9so43930170otj.11 for ; Mon, 30 Dec 2019 06:55:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=viyvgRJhg6aFwMHQssf6lRsYMTn4tobnHQx/8vJxTrU=; b=qluJAuO7XC7DGkiP4LkXZMEvlXa7s8xHCp2a/MfoD+FFnlcny9atthrrmwbtfnyTxf h4Gl42eASPealxz5pjOYjj2VpyyVAFJV1d8YlIVILE4boYOCL69LO1EgHWoLcC4BjnMk CmhOMxTh/sAPxCkFTQd2krNp5s1YawmrF0vi9UHYg9uRCAbnrfHhEUP3dH5QFOP34D2S M6m0bSWhFM5LAbzB0ItX+jYQeXbLJfIFAt0p5pIkV8dDmw5gxpOt3fsZXSrKzZebC2B9 +slK9sp3wfvSN/XINbFhfWDUXdq5A3HJPySVTPKkd7uijGkUz2s4t2fEufWimoZ5WQ5i 2NmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=viyvgRJhg6aFwMHQssf6lRsYMTn4tobnHQx/8vJxTrU=; b=Etwm8QESYVkL1hyFE0wzAVyzNjMPSBTSF3IHb1Nl2BMXVxIa29I1OLtGz0Wwq0Rv7N 1EOoxAgIkoMr67ZM+ZiAUWNgOMiy+CbbbGNzrC0//0Lxes6kKnTtK1YFv8g0jx9AO32a NJBTC0vLZdYbSIBfhOMTxUIX7wdYkqWhoI+IvJfLUHY5kZVA4ct8RyZ5l3R09ZDOygoC bmhEI3Jaczrvx3ELaEQ+OtHXxX6ng59qrDDI7rnIoUNNfTQFS4Odb3rNgCmn4+vkRrRD 2+JattCHbYovpivZEu4pORM0apdhsjmRPD6FUKeLtn6d8XsNFlteOcbMOYYKFj5AQmZ/ zPHA== X-Gm-Message-State: APjAAAUHhSomR18rlnDoPEGbgxhx6p1l0ANF83LwIRgw7lWjZ4Y2x+aT 84F8gT4MLjIcNHBsIJ4u8utItq2uVjw5Y5q24HVWMr8J X-Google-Smtp-Source: APXvYqz9+q8ECMQZcy6Bns2Mi8NMec+0MZdb5DDmde923UpWIVD9pGOd+T2e8Fl2z+e0V7RyMcN9n2x3k/ONBFxK0GU= X-Received: by 2002:a05:6830:174e:: with SMTP id 14mr49015867otz.142.1577717753453; Mon, 30 Dec 2019 06:55:53 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Ivan Pavlukhin Date: Mon, 30 Dec 2019 17:55:42 +0300 Message-ID: Subject: Re: PME speedup #2, TX recovery delay elimination. To: dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Anton, > Since this fix made to speedup pme-free switch which prohibits the merges= ... Sounds as a bit of knowledge that I missed. Good to understand it now. > The "magic numbers" are always the "magic numbers" :) > We must get rid of them to see problems covered by them. Let's try =3D) =D1=87=D1=82, 26 =D0=B4=D0=B5=D0=BA. 2019 =D0=B3. =D0=B2 15:09, Anton Vinog= radov : > > Ivan, > > The "magic numbers" are always the "magic numbers" :) > We must get rid of them to see problems covered by them. > > >> Was there any > >> performance measurements for such multiple left nodes cases? > Since this fix made to speedup pme-free switch which prohibits the merges= , > the answer is "no". > > BTW, the fix was merged to master. > > On Thu, Dec 26, 2019 at 2:21 PM Ivan Pavlukhin wrot= e: > > > Anton, > > > > Thank you for your efforts! And sorry for a late reply. > > > > I am a little bit familiar with tx recovery. I personally like the > > idea of removing such "magic" logic from the code. I think a proper > > way is either justify and sustain (tests, documentation) some behavior > > or get rid of it. > > > > Regarding a delay before tx recovery. My understanding was that it > > might be useful when multiple (client) nodes leaves almost at the same > > time (perhaps due to some network connectivity issues). With a delay > > recovering multiple failed nodes will be grouped into one recovery > > round (+PME). Correct me if my understanding is wrong. Was there any > > performance measurements for such multiple left nodes cases? > > > > =D0=B2=D1=82, 24 =D0=B4=D0=B5=D0=BA. 2019 =D0=B3. =D0=B2 16:22, Anton V= inogradov : > > > > > > Rechecked TC two more times. > > > Going to merge to master in case no objections here. > > > > > > On Mon, Dec 23, 2019 at 1:44 PM Anton Vinogradov wrot= e: > > > > > > > Igniters, > > > > > > > > One more PME optimization ready to be reviewed. > > > > I found a strange tx recovery delay caused by > > IGNITE_TX_SALVAGE_TIMEOUT. > > > > I've checked the code and tests and found no reason to delay recove= ry. > > > > > > > > So, the issue [1] is ready to be reviewed. > > > > > > > > Improvement checked with benchmark [2] and fix, obviously, 100 ms > > faster > > > > :) > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-12272 > > > > [2] > > > > > > https://github.com/anton-vinogradov/ignite/commit/f8c27253b0ecfe7381418= f505aafe942efe5a0a8 > > > > > > > > > > > > -- > > Best regards, > > Ivan Pavlukhin > > --=20 Best regards, Ivan Pavlukhin