ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrey Gura <ag...@apache.org>
Subject Re: Checkstyle "NewlineAtEndOfFile" rule issue
Date Thu, 19 Dec 2019 17:55:19 GMT
Agree with Pavel. But it could broke something in our pipeline.

Maxim, if issue was fixed so it dependency update is better way. But
it seems that this issue in Open status.

On Thu, Dec 19, 2019 at 7:22 PM Pavel Tupitsyn <ptupitsyn@apache.org> wrote:
>
> Maxim,
>
> The guidelines are not set in stone.
> If we decide that some guideline does not bring any value and only wastes
> our time (like this one),
> we can (and should) remove it.
>
> On Thu, Dec 19, 2019 at 7:13 PM Maxim Muzafarov <mmuzaf@apache.org> wrote:
>
> > Pavel,
> >
> > It's configured according to accepted Coding Guidelines [1].
> >
> > [1]
> > https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-Whitespacesandemptylines
> >
> > On Thu, 19 Dec 2019 at 18:59, Pavel Tupitsyn <ptupitsyn@apache.org> wrote:
> > >
> > > Igniters,
> > >
> > > Does this rule bring any value whatsoever for us?
> > > Let's just disable it.
> > >
> > > On Thu, Dec 19, 2019 at 6:25 PM Maxim Muzafarov <mmuzaf@apache.org>
> > wrote:
> > >
> > > > Hello, Andrey
> > > >
> > > > Is it better to upgrade the checkstyle plugin version?
> > > > It seems the issue has been fixed since 8.21 version (currently we have
> > > > 8.19)
> > > >
> > > > [1] https://checkstyle.org/releasenotes.html#Release_8.21
> > > >
> > > > On Thu, 19 Dec 2019 at 18:09, Andrey Gura <agura@apache.org> wrote:
> > > > >
> > > > > Igniters,
> > > > >
> > > > > recently I run build with checkstyle profile on Windows machine and
> > > > > got 8 issues related to the "NewlineAtEndOfFile" rule while there
are
> > > > > no problems on my Linux machine.
> > > > >
> > > > > I investigated the problem and suggest explicitly configure this
rule
> > > > > by LF separator. See [1] for more details.
> > > > >
> > > > > I want merge this change if there are no any objections from
> > community
> > > > members.
> > > > >
> > > > > [1] https://issues.apache.org/jira/browse/IGNITE-12472
> > > >
> >

Mime
View raw message