ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pavel Tupitsyn <ptupit...@apache.org>
Subject Re: Checkstyle "NewlineAtEndOfFile" rule issue
Date Thu, 19 Dec 2019 15:58:59 GMT
Igniters,

Does this rule bring any value whatsoever for us?
Let's just disable it.

On Thu, Dec 19, 2019 at 6:25 PM Maxim Muzafarov <mmuzaf@apache.org> wrote:

> Hello, Andrey
>
> Is it better to upgrade the checkstyle plugin version?
> It seems the issue has been fixed since 8.21 version (currently we have
> 8.19)
>
> [1] https://checkstyle.org/releasenotes.html#Release_8.21
>
> On Thu, 19 Dec 2019 at 18:09, Andrey Gura <agura@apache.org> wrote:
> >
> > Igniters,
> >
> > recently I run build with checkstyle profile on Windows machine and
> > got 8 issues related to the "NewlineAtEndOfFile" rule while there are
> > no problems on my Linux machine.
> >
> > I investigated the problem and suggest explicitly configure this rule
> > by LF separator. See [1] for more details.
> >
> > I want merge this change if there are no any objections from community
> members.
> >
> > [1] https://issues.apache.org/jira/browse/IGNITE-12472
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message