From dev-return-48289-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Sat Nov 9 08:48:09 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1B3791804BB for ; Sat, 9 Nov 2019 09:48:09 +0100 (CET) Received: (qmail 51428 invoked by uid 500); 9 Nov 2019 08:48:08 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 51416 invoked by uid 99); 9 Nov 2019 08:48:07 -0000 Received: from Unknown (HELO mailrelay1-lw-us.apache.org) (10.10.3.42) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Nov 2019 08:48:07 +0000 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id 667A71004 for ; Sat, 9 Nov 2019 08:48:07 +0000 (UTC) Received: by mail-ed1-f43.google.com with SMTP id k14so7809232eds.4 for ; Sat, 09 Nov 2019 00:48:07 -0800 (PST) X-Gm-Message-State: APjAAAWxFdnjFJpJEyxPKzUdVkORMxmjJT/xSply95X7Jr5AVWw/AT9r apepedY2qXluKPk5DZuNsqt1eTA06bRE68Q7Cg== X-Google-Smtp-Source: APXvYqw90K1pzxuzShfeLUto4IkKAdFTYHjJtRyosjN1hSForMTfqVgD1S4h8aDqkp7Xp8Xt76l6g0RUMYV3vBUA/v0= X-Received: by 2002:a50:f783:: with SMTP id h3mr15023820edn.168.1573289286681; Sat, 09 Nov 2019 00:48:06 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Pavel Tupitsyn Date: Sat, 9 Nov 2019 11:47:53 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: SQL query timeout: in progress or abandoned To: dev Content-Type: multipart/alternative; boundary="0000000000000fca390596e5f58d" --0000000000000fca390596e5f58d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Replied in JIRA Thanks On Sat, Nov 9, 2019 at 3:13 AM Saikat Maitra wrote: > Pavel Tupitsyn, Igor Sapego > > I wanted to connect and confirm on changes for this PR. > > https://github.com/apache/ignite/pull/6490 > > Do you think keeping the change for PlatformConfigurationUtils.java will > cause regression on the .NET component or C++ components? > > Jira : https://issues.apache.org/jira/browse/IGNITE-7285 > > Regards, > Saikat > > > > On Mon, Oct 14, 2019 at 3:14 AM Ivan Pavlukhin > wrote: > > > Hi Saikat, > > > > Sorry for delay. I will do my best to check it in the beginning of this > > week. > > > > =D1=81=D0=B1, 12 =D0=BE=D0=BA=D1=82. 2019 =D0=B3. =D0=B2 08:15, Saikat = Maitra : > > > > > > Hello Ivan, > > > > > > I have updated the PR as per our discussion. > > > > > > Please review and share your feedback. > > > > > > Regards, > > > Saikat > > > > > > On Sun, Sep 1, 2019 at 3:20 PM Saikat Maitra > > > wrote: > > > > > > > Hi Ivan, > > > > > > > > I have taken care of review comments and also have shared a questio= n > > for > > > > the application of default Query timeout value. > > > > > > > > Can you please review and share feedback? > > > > > > > > Regards, > > > > Saikat > > > > > > > > On Sat, Aug 24, 2019 at 7:22 PM Saikat Maitra < > saikat.maitra@gmail.com > > > > > > > wrote: > > > > > > > >> Hi Ivan, > > > >> > > > >> Thank you, I have shared my comments and have few questions relate= d > to > > > >> the issue. > > > >> > > > >> Please take a look and share your thoughts. > > > >> > > > >> Regards, > > > >> Saikat > > > >> > > > >> On Tue, Aug 20, 2019 at 4:03 PM =D0=9F=D0=B0=D0=B2=D0=BB=D1=83=D1= =85=D0=B8=D0=BD =D0=98=D0=B2=D0=B0=D0=BD > > > >> wrote: > > > >> > > > >>> Hi Saikat, > > > >>> > > > >>> I left a comment in JIRA ticket [1]. Also, I invited Andrey to he= lp > > > >>> with a further review. > > > >>> > > > >>> Andrey, could you please step in and continue the review? > > > >>> Unfortunately, for a couple of weeks I have limited access to my > > > >>> computer and cannot do a review in a timely manner. > > > >>> > > > >>> [1] https://issues.apache.org/jira/browse/IGNITE-7285 > > > >>> > > > >>> 2019-08-19 7:24 GMT+11:00, Saikat Maitra >: > > > >>> > Hi Ivan, > > > >>> > > > > >>> > I have updated the PR and made changes in IgniteH2Indexing for > > query > > > >>> > timeout so that default query timeout get used during query > > execution. > > > >>> > > > > >>> > Please take a look and let me know if this change looks good. > > > >>> > > > > >>> > I will update tests if the approach looks good. > > > >>> > > > > >>> > PR https://github.com/apache/ignite/pull/6490 > > > >>> > > > > >>> > Regards, > > > >>> > > > > >>> > Saikat > > > >>> > > > > >>> > On Sat, Aug 17, 2019 at 8:30 PM Saikat Maitra < > > saikat.maitra@gmail.com > > > >>> > > > > >>> > wrote: > > > >>> > > > > >>> >> Hi Ivan, Denis > > > >>> >> > > > >>> >> Thank you for your feedback, I am looking into the changes > needed > > for > > > >>> >> this > > > >>> >> issue. > > > >>> >> > > > >>> >> I am also looking into these configurations parameters > > > >>> >> > https://apacheignite.readme.io/v2.2/docs/configuration-parameters > > to > > > >>> see > > > >>> >> if there are similar attributes being used in SqlFieldsQuery > and > > > >>> >> SqlQuery. > > > >>> >> > > > >>> >> > > > >>> >> Regards, > > > >>> >> > > > >>> >> Saikat > > > >>> >> > > > >>> >> > > > >>> >> > > > >>> >> On Thu, Aug 15, 2019 at 6:13 AM =D0=9F=D0=B0=D0=B2=D0=BB=D1=83= =D1=85=D0=B8=D0=BD =D0=98=D0=B2=D0=B0=D0=BD < > > vololo100@gmail.com> > > > >>> >> wrote: > > > >>> >> > > > >>> >>> Saikat, Denis, > > > >>> >>> > > > >>> >>> I left comments in the ticket [1]. > > > >>> >>> > > > >>> >>> [1] https://issues.apache.org/jira/browse/IGNITE-7285 > > > >>> >>> > > > >>> >>> =D0=B2=D1=82, 13 =D0=B0=D0=B2=D0=B3. 2019 =D0=B3. =D0=B2 21:5= 3, Denis Magda : > > > >>> >>> > > > > >>> >>> > Hi Saikat, > > > >>> >>> > > > > >>> >>> > Thanks for a quick turnaround! Ivan, could you please step = in > > and > > > >>> do a > > > >>> >>> > review? > > > >>> >>> > > > > >>> >>> > - > > > >>> >>> > Denis > > > >>> >>> > > > > >>> >>> > > > > >>> >>> > On Sun, Aug 11, 2019 at 6:26 AM Saikat Maitra > > > >>> >>> > > > > >>> >>> > wrote: > > > >>> >>> > > > > >>> >>> > > Hi Denis, Ivan > > > >>> >>> > > > > > >>> >>> > > As discussed I have updated the PR and incorporated revie= w > > > >>> comments. > > > >>> >>> > > > > > >>> >>> > > https://github.com/apache/ignite/pull/6490/files > > > >>> >>> > > > > > >>> >>> > > Please take a look and share your feedback. > > > >>> >>> > > > > > >>> >>> > > Regard, > > > >>> >>> > > Saikat > > > >>> >>> > > > > > >>> >>> > > > > > >>> >>> > > > > > >>> >>> > > On Sat, Aug 10, 2019 at 5:51 PM Saikat Maitra < > > > >>> >>> saikat.maitra@gmail.com> > > > >>> >>> > > wrote: > > > >>> >>> > > > > > >>> >>> > > > Hello Denis, Ivan > > > >>> >>> > > > > > > >>> >>> > > > Yes, I can take up the changes for IGNITE-7825. > > > >>> >>> > > > > > > >>> >>> > > > I had a doubt on the usage of the Default Query Timeout= . > > > >>> >>> > > > > > > >>> >>> > > > I had raised the PR in an assumption that Default Query > > Timeout > > > >>> >>> will only > > > >>> >>> > > > be used if user had not provided Cache Query Timeout > > > >>> >>> > > > > > > >>> >>> > > > https://github.com/apache/ignite/pull/6490/files > > > >>> >>> > > > > > > >>> >>> > > > I wanted to discuss if it is correct intended usage of > > Default > > > >>> >>> > > > Query > > > >>> >>> > > > Timeout or should we reconsider? > > > >>> >>> > > > > > > >>> >>> > > > Regards, > > > >>> >>> > > > Saikat > > > >>> >>> > > > > > > >>> >>> > > > > > > >>> >>> > > > > > > >>> >>> > > > On Fri, Aug 9, 2019 at 12:11 PM Denis Magda < > > dmagda@apache.org > > > >>> > > > > >>> >>> wrote: > > > >>> >>> > > > > > > >>> >>> > > >> Ivan, thanks for sharing this discussion. Let's use it > > for our > > > >>> >>> > > >> conversation. > > > >>> >>> > > >> > > > >>> >>> > > >> - > > > >>> >>> > > >> Denis > > > >>> >>> > > >> > > > >>> >>> > > >> > > > >>> >>> > > >> On Thu, Aug 8, 2019 at 11:15 PM =D0=9F=D0=B0=D0=B2=D0= =BB=D1=83=D1=85=D0=B8=D0=BD =D0=98=D0=B2=D0=B0=D0=BD > > > >>> >>> > > >> > > >>> >>> > > > > >>> >>> > > >> wrote: > > > >>> >>> > > >> > > > >>> >>> > > >> > Just for the protocol. There was an original dev-lis= t > > > >>> >>> > > >> > discussion > > > >>> >>> [1]. > > > >>> >>> > > >> > Added a link to the ticket as well. > > > >>> >>> > > >> > > > > >>> >>> > > >> > [1] > > > >>> >>> > > >> > > > > >>> >>> > > >> > > > >>> >>> > > > > > >>> >>> > > > >>> > > > http://apache-ignite-developers.2346864.n4.nabble.com/IGNITE-7285-Add-def= ault-query-timeout-td41828.html > > > >>> >>> > > >> > > > > >>> >>> > > >> > =D0=BF=D1=82, 9 =D0=B0=D0=B2=D0=B3. 2019 =D0=B3. =D0= =B2 01:22, Denis Magda < > > dmagda@apache.org > > > >>> >: > > > >>> >>> > > >> > > > > > >>> >>> > > >> > > Hey Saikat, > > > >>> >>> > > >> > > > > > >>> >>> > > >> > > Are you still working on this ticket? > > > >>> >>> > > >> > > https://issues.apache.org/jira/browse/IGNITE-7285 > > > >>> >>> > > >> > > > > > >>> >>> > > >> > > Seems that's the last API that doesn't support > > timeouts - > > > >>> >>> > > >> > > JDBC > > > >>> >>> and > > > >>> >>> > > >> ODBC > > > >>> >>> > > >> > > drivers already go with it. > > > >>> >>> > > >> > > > > > >>> >>> > > >> > > If you don't have time to complete the changes the= n > > > >>> someone > > > >>> >>> else > > > >>> >>> > > from > > > >>> >>> > > >> the > > > >>> >>> > > >> > > community can take over. We see a lot of demand fo= r > > this > > > >>> API > > > >>> >>> and > > > >>> >>> > > here > > > >>> >>> > > >> is > > > >>> >>> > > >> > > one example: > > > >>> >>> > > >> > > > > > >>> >>> > > >> > > > > >>> >>> > > >> > > > >>> >>> > > > > > >>> >>> > > > >>> > > > https://stackoverflow.com/questions/57275301/how-to-set-a-query-timeout-f= or-apache-ignite-cache > > > >>> >>> > > >> > > > > > >>> >>> > > >> > > - > > > >>> >>> > > >> > > Denis > > > >>> >>> > > >> > > > > >>> >>> > > >> > > > > >>> >>> > > >> > > > > >>> >>> > > >> > -- > > > >>> >>> > > >> > Best regards, > > > >>> >>> > > >> > Ivan Pavlukhin > > > >>> >>> > > >> > > > > >>> >>> > > >> > > > >>> >>> > > > > > > >>> >>> > > > > > >>> >>> > > > >>> >>> > > > >>> >>> > > > >>> >>> -- > > > >>> >>> Best regards, > > > >>> >>> Ivan Pavlukhin > > > >>> >>> > > > >>> >> > > > >>> > > > > >>> > > > >>> > > > >>> -- > > > >>> Best regards, > > > >>> Ivan Pavlukhin > > > >>> > > > >> > > > > > > > > -- > > Best regards, > > Ivan Pavlukhin > > > --0000000000000fca390596e5f58d--