From dev-return-47829-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Oct 4 07:16:39 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 87139180651 for ; Fri, 4 Oct 2019 09:16:39 +0200 (CEST) Received: (qmail 90801 invoked by uid 500); 4 Oct 2019 07:16:38 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 90789 invoked by uid 99); 4 Oct 2019 07:16:38 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Oct 2019 07:16:38 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 763F0C0C8B for ; Fri, 4 Oct 2019 07:16:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.049 X-Spam-Level: * X-Spam-Status: No, score=1.049 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id eEdZLzIvoiHV for ; Fri, 4 Oct 2019 07:16:35 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.167.193; helo=mail-oi1-f193.google.com; envelope-from=vololo100@gmail.com; receiver= Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id 56C9CBC5E6 for ; Fri, 4 Oct 2019 07:16:35 +0000 (UTC) Received: by mail-oi1-f193.google.com with SMTP id e18so4969118oii.0 for ; Fri, 04 Oct 2019 00:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=/4qmZ94GGvyDXoLyufRBzuJFMWIoWrj+orDjFg+m5NY=; b=uF+ZFd95+VwA+Sut17sW5OrCnxKprovO/5iiqrp3vCHb9Lva/ya+oaF7flSt2Aoz7I +4y3rL3UZl7dWZYYrh12E7FnHS+G28UoECllRWEhHenZFbs8LRthdY77+RjeqfJzN4rR NnJ9PU1CWlTd52K/oErpp+30FkfcI7AJOiSTddOwTh8xnLm4AOpIPRCyiemy/Q3MyVsr /fn1qOUg7qtjBLue9Z72/bLuFk7BKl2UbXTJVkLJE+LsHXoYCJHQBP3pSVpTC+13EBU9 N5bgsV296eF/FAEEvlymHrjGgfXSaBG+LgaV6jv8UFEme1g5DHR/soARRbz1LVtSoZ5L eQug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=/4qmZ94GGvyDXoLyufRBzuJFMWIoWrj+orDjFg+m5NY=; b=WImBMmlxLQnbuVSy01bDfvzxTDam+Xz4agFcsszsWql833qOxb5dddFYBL7PHIYL7h 6rosovrvJdZ1bQrWImc0A/34VLtV2Wco/cYO1db81dAFsmMsc6RDyFDna7RIULI+TmfG p5vlAqrqQGS8ns998dzSjGLHB66gJq5XgbkiQ6SzMHidp4PXeVXbCjV15isP0f6p5DOI Y6MpYKumeqjIbvq/A44aC1DgAV7CzIiwEJrxWG/ajq6hTHF/MjzH1H7S9oEBk609gG34 M1j5hcuu9rk0a8ae+pgmEW1WBx9Sb4el0sYMEgV4RLGKSz6pL2VIrcjijdl033XYe/EZ SZjg== X-Gm-Message-State: APjAAAX0GnzeELG7QCoZQZmRpBdLXyOc1Gih0iXrRJS85eiAzwaBC0ML umVISUpOZz+JKOUOmJzb8ewuIMOYtSjShIojnw2vsFiU X-Google-Smtp-Source: APXvYqxPjlgs49Lj3pULqKzOgKjTe/5J7CLLKVbqnaEdm+duBmGl8h4uuHmva+OQ8udEnUSpJYD8lETyb5ePkxMc2Ws= X-Received: by 2002:aca:645:: with SMTP id 66mr5704206oig.117.1570173394417; Fri, 04 Oct 2019 00:16:34 -0700 (PDT) MIME-Version: 1.0 References: <8657281565622613@sas2-ce04c18c415c.qloud-c.yandex.net> <1566890216.224076930@f387.i.mail.ru> <071e5ffa0a127353e38c4cb1b479f8f706d3f7df.camel@gmail.com> In-Reply-To: From: Ivan Pavlukhin Date: Fri, 4 Oct 2019 10:16:22 +0300 Message-ID: Subject: Re: Replacing default work dir from tmp to current dir To: dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Interesting things about those LINQPad/JPad scenarios. Was not aware of it. Still some doubts about applicability. It seems to me that JPad having work dir in "Program Files" have a lot of problems by itself, e.g. a user is not able to run basic file IO snippets with relative file paths. =D1=87=D1=82, 3 =D0=BE=D0=BA=D1=82. 2019 =D0=B3. =D0=B2 23:24, Pavel Tupits= yn : > > Ilya, fallback is a good idea. > Still I'd prefer to have user.home as a default, and fallback to user.dir > when home does not work for some reason. > > On Thu, Oct 3, 2019 at 11:07 PM Ilya Kasnacheev > wrote: > > > Hello! > > > > We can try and fallback to home dir with warning, when file cannot be > > created in current dir. > > > > WDYT? > > > > Regards, > > -- > > Ilya Kasnacheev > > > > > > =D1=87=D1=82, 3 =D0=BE=D0=BA=D1=82. 2019 =D0=B3. =D0=B2 20:05, Pavel Tu= pitsyn : > > > > > > Cannot tell about NuGet. Maven is typically used during developmen= t, > > > usually there is no Maven in production deployments. > > > NuGet and Maven are very similar. Yes, both of them are build-time to= ols, > > > production is unrelated. > > > For production-ready deployments we can expect users to tweak Ignite = to > > > their needs, set custom storage dirs, adjust heap sizes and so on. > > > > > > I'm talking about new users, about "getting started" scenarios - > > > it is super important to make Ignite easy to get started with, provid= e > > > reasonable defaults for all the configuration properties. > > > > > > For Ignite.NET, LINQPad is one of those "get started in 2 clicks" > > > scenarios. And this scenario got broken as explained above. > > > 2.7.5 and earlier used temp dir, which worked. 2.7.6 fails: "Work > > directory > > > does not exist and cannot be created: C:\Program > > > Files\LINQPad5\ignite\work" > > > > > > For Java there is JPad, which will fail in the same way - when you ru= n > > code > > > from there, `user.dir` points to Program Files. > > > > > > I expect that there are more use cases like this, and `user.home` is = a > > > reasonable solution. > > > > > > On Thu, Oct 3, 2019 at 5:56 PM Ilya Kasnacheev < > > ilya.kasnacheev@gmail.com> > > > wrote: > > > > > > > Hello! > > > > > > > > I want to point out that I didn't change this location (current dir= ). > > It > > > > was already implemented when I raised this issue, the only change I= did > > > was > > > > to swap current dir/work to current dir/ignite/work to avoid confus= ion > > > > whose work dir that is. > > > > > > > > I also communicated this to you all in ML when I discovered that > > current > > > > dir is used. > > > > > > > > I think that current dir is actually *well defined* when starting a > > > > project. A project is expected to be started from the same dir, and= all > > > > "Run..." dialogs usually allow specifying that one. > > > > > > > > For embedded scenarios, you definitely not want work dir from two > > > different > > > > Ignite-using tools to interfere. For embedded scenarios, you should > > only > > > > expect that current dir is writable. > > > > > > > > Even after these considerations, it's too late to change that becau= se > > > > people don't expect this dir to move with every release of Ignite, = and > > we > > > > already did it once. > > > > > > > > Regards, > > > > -- > > > > Ilya Kasnacheev > > > > > > > > > > > > =D1=87=D1=82, 3 =D0=BE=D0=BA=D1=82. 2019 =D0=B3. =D0=B2 17:34, Alex= ey Goncharuk < > > alexey.goncharuk@gmail.com > > > >: > > > > > > > > > > > > > > > > Seems, we should have different defaults and even distributions= for > > > > > > different usage scenarios. > > > > > > > > > > > I still do not understand why defaults should be different for > > embedded > > > > and > > > > > "traditional RDBMS-like" installations. Having different defaults > > will > > > > > likely confuse users, not make usability easier. Personally, I wo= uld > > > > forbid > > > > > to start Ignite if IGNITE_HOME is not set, but this suggestion wa= s > > not > > > > > accepted by the community. > > > > > > > > > > As far as I know, both rocksdb and SQLite is local only libraries= and > > > > don't > > > > > > have any distrubted features. > > > > > > > > > > See no difference here. Imagine a user starts only one Ignite nod= e > > for > > > > > development or just to play (which, I believe, happes quite a lot= ) - > > > same > > > > > as with local databases. BTW, it is impossible to start SQLite > > without > > > > > database path, so a user either provides a full path, or a relati= ve > > > path > > > > > from the current directory - which is an explicit action from a u= ser. > > > > > > > > > > > > > > > > I agree with you. > > > > > > How it happens, that after wide discussion we implemented, revi= ewed > > > and > > > > > > merged wrong defaults? > > > > > > > > > > > > As I know, we have explicit release only to change this default= . > > > > > > > > > > > > This release is broken, isn't it? > > > > > > > > > > > I think this is just a miscommunication. Ilya made a fix which wa= s > > > > exactly > > > > > what he meant it to be. As for the release - it may have worse > > > usability, > > > > > but not more 'broken' as the previous one with the temp directory= . At > > > > least > > > > > the data will not be physically removed after the machine restart= . > > > > > > > > > > > > > > --=20 Best regards, Ivan Pavlukhin