From dev-return-47735-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Mon Sep 30 10:27:07 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0F065180656 for ; Mon, 30 Sep 2019 12:27:06 +0200 (CEST) Received: (qmail 37702 invoked by uid 500); 30 Sep 2019 10:27:06 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 37684 invoked by uid 99); 30 Sep 2019 10:27:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Sep 2019 10:27:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 598431A4129 for ; Mon, 30 Sep 2019 10:27:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.899 X-Spam-Level: * X-Spam-Status: No, score=1.899 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URI_HEX=0.1] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id wXm6Y0qKIIal for ; Mon, 30 Sep 2019 10:27:02 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.128.52; helo=mail-wm1-f52.google.com; envelope-from=garus.d.g@gmail.com; receiver= Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id 85BBFBC55E for ; Mon, 30 Sep 2019 10:27:02 +0000 (UTC) Received: by mail-wm1-f52.google.com with SMTP id f22so12089969wmc.2 for ; Mon, 30 Sep 2019 03:27:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GDfeHvgFjDg14klhThSr15rJ7v5fZTg5jGV8r9o43Us=; b=f56vOuhjiG20EIyA5MGhDTUS9v6AwGC5unz1TxPu1iJ0NuoK/n9HL5IomaQLOzs657 v21gS1QLpZxWFrACsvzU3bpP2U41EwQIO1VyLeEED4sduuwEXw0C74vdf/yokgWcDFvc f4rNehxufI5wVRZcJaDnwuUiEiaYcK7W+p2eITnWRkEaEDPcwFHnRQ3qg9m5pBmEGgjd 7OYCKEwRpIp4UV+Chmwj16x2RhhhoqsFQOeWYKyU7nq4MW11UvbgJPN7uKC0fxGFqQX+ 0eIgfesUxTsuD8hs8LTFmCVOtfKwOERk5b21GP7uW/2M0jliWxIpKLIubXUYuGt2ZqJX JNQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GDfeHvgFjDg14klhThSr15rJ7v5fZTg5jGV8r9o43Us=; b=G3osKXrBUJdFMHw+0Nlq4nif6QIJJysLXLvBE3Txxcfvhezm24xZYvjxhS1dToCDjW gMjyslcsmBhpwL1yA/M/EmTd4OpnwFcZPCKc6obMVJn22HNfgn2pN9Putc2Mpd6/iB8o viIB4lAyVzgfsqJGYmkKukb1e59KcsCL2K23xnxp1KFmSpyjNvehO8Yycy+gFaFaxy0G Ux1TGQk5t4ofKpMy27Vzju8iXCA6D5I3GbxdMwQp5x2QHZJXtdkmt13MIbJqoGJDegcn UxKJJHFOtD8fAO2EloxFcClbYubv20wXF1iIWYlie+w9oifstTgi/ZWO1SvBLPLFdQUZ Jl+w== X-Gm-Message-State: APjAAAVwXHE36QfVh3tTILiKZnVolQBL6cL9k0n4eRgwf9e0kwYkimSL MVY+qr5bldufMmY3oFGNFKbb8Ny7qbbpaW8GL94= X-Google-Smtp-Source: APXvYqx5PBHUG6wl3T5HCgekDYkTq4klN8iLqOL2JPf/g2jx6HscfbHT3rbKAkRhOfc614Hi9ZWRPdZHErXQ9kFvCV4= X-Received: by 2002:a7b:c182:: with SMTP id y2mr16339421wmi.156.1569839221550; Mon, 30 Sep 2019 03:27:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Denis Garus Date: Mon, 30 Sep 2019 13:26:49 +0300 Message-ID: Subject: Re: JavaDoc for Event's subjectId methods To: Maksim Stepachev Cc: dev@ignite.apache.org Content-Type: multipart/alternative; boundary="00000000000027b1ea0593c2aded" --00000000000027b1ea0593c2aded Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thank you, Maksim! I think that the description should look like: "Gets security subject ID initiated this task event if IgniteSecurity is enabled, otherwise returns null. This property is not available for GridEventType#EVT_TASK_SESSION_ATTR_SET task event." Please pay close attention that described behavior is confirmed by tests. =D0=BF=D0=BD, 30 =D1=81=D0=B5=D0=BD=D1=82. 2019 =D0=B3. =D0=B2 13:11, Maksi= m Stepachev : > Denis, > > I added it in my ticket and pull-request. Should I change the only first > sentence or full comment? > > =D0=BF=D0=BD, 30 =D1=81=D0=B5=D0=BD=D1=82. 2019 =D0=B3. =D0=B2 11:27, Den= is Garus : > >> Hello! >> >> I suggested to Maksim Stepachev include these changes in the scope of >> your thicket [1] >> and it looks like he agreed [2]. >> >> Maksim Stepachev, could you please reflect JavaDoc and behavior changes >> of events in your ticket? >> >> 1. https://issues.apache.org/jira/browse/IGNITE-11992 >> 2. >> http://apache-ignite-developers.2346864.n4.nabble.com/Improvements-for-n= ew-security-approach-td42698.html >> >> =D0=BF=D0=BD, 30 =D1=81=D0=B5=D0=BD=D1=82. 2019 =D0=B3. =D0=B2 11:07, Iv= an Pavlukhin : >> >>> Hi, >>> >>> Do we allow commits to master without a ticket? I can imagine only >>> reverts as an exception. >>> >>> Otherwise a ticket is a primary process item. Work description, >>> review, CI checks (we have a job checking javadocs). >>> >>> =D1=81=D1=80, 25 =D1=81=D0=B5=D0=BD=D1=82. 2019 =D0=B3. =D0=B2 01:15, D= enis Magda : >>> > >>> > Denis, please feel free to go and edit the JavaDocs in place without = a >>> > ticket. The changes suggested by you are reasonable. >>> > >>> > - >>> > Denis >>> > >>> > >>> > On Tue, Sep 24, 2019 at 3:55 AM Denis Garus >>> wrote: >>> > >>> > > Hello, Igniters! >>> > > >>> > > Some events contain the subjectId method, for example, >>> TaskEvent#subjectId. >>> > > The JavaDoc for this method is: >>> > > "Gets security subject ID initiated this task event, if available. >>> > > This property is not available for >>> GridEventType#EVT_TASK_SESSION_ATTR_SET >>> > > task event. >>> > > Subject ID will be set either to node ID or client ID initiated tas= k >>> > > execution." >>> > > >>> > > I think It's wrong. The main point is a subject id doesn't have any >>> sense >>> > > if IgniteSecurity is disabled. >>> > > However, if IgniteSecurity is enabled, the method must return the >>> subject >>> > > id from the current security context. >>> > > Thus, the description (and behavior) of the method should be the >>> following: >>> > > Gets security subject ID initiated this task event if IgniteSecurit= y >>> is >>> > > enabled, otherwise returns null. >>> > > >>> > > The same is actual for CacheEvent, CacheQueryExecutedEvent and >>> > > CacheQueryReadEvent. >>> > > >>> > > If there are no objections, I am going to create a relevant issue i= n >>> Jira. >>> > > >>> >>> >>> >>> -- >>> Best regards, >>> Ivan Pavlukhin >>> >> --00000000000027b1ea0593c2aded--