From dev-return-47730-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Mon Sep 30 08:28:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C71D6180656 for ; Mon, 30 Sep 2019 10:28:02 +0200 (CEST) Received: (qmail 78081 invoked by uid 500); 30 Sep 2019 08:28:02 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 78069 invoked by uid 99); 30 Sep 2019 08:28:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Sep 2019 08:28:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 49F46C0D25 for ; Mon, 30 Sep 2019 08:28:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.899 X-Spam-Level: * X-Spam-Status: No, score=1.899 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URI_HEX=0.1] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id pJnrPmKHCCwg for ; Mon, 30 Sep 2019 08:27:59 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.128.53; helo=mail-wm1-f53.google.com; envelope-from=garus.d.g@gmail.com; receiver= Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id B0386BC566 for ; Mon, 30 Sep 2019 08:27:58 +0000 (UTC) Received: by mail-wm1-f53.google.com with SMTP id v17so11647024wml.4 for ; Mon, 30 Sep 2019 01:27:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=F9QIrxoS28YSoWScdoCVJHCqiXC3pqSK8O2fN4mdpNM=; b=t4+xLRb0FWT0A9exhIea75V0jL1YxLz+lo2Ot8WTHVVDCUQOpJiwZsNhlC2Zdk2fxs BLkZxCsbeJ4MUcZ6Sjy8HzPtnfeBqTrjN6Ua6Smwhvt3rezlLtinIPRtF286dvzU/3GY zYodKhflIFQrMhRiedrSrW5ay5e3lt0HT4RSDazRk/UhbQcwpcOPOl8eOv37vHwafY4l sbS8sVIOp1mkhx4JGDFSCrHzlV0L3dRkRi7HtIz6eBP30ljZkWUVvYqqrdnZXf/AoGV6 Adc33+yJn5orSzddzsH7mcnwiEKW/iLqbrsJOBq5ZjBIp0rXiNuhbUpKejwtmJbjZCrB wXBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=F9QIrxoS28YSoWScdoCVJHCqiXC3pqSK8O2fN4mdpNM=; b=dbynoSw2hFplpzDccwNQBwnt8FL56tFoqNIyH2RAwCK/lBE4wYYdKfMJeIYdnGbXEw JitcrwYpx/Jxv+HebhEiGF6FscwNrbKWKI5x0xD/eNT3fOANi+YA5UR2bZyyUCKshN9I hDZt+6Mjj7YncVMl23BZtBbyGWr0UC8XB+noHmZOj5MMKcA0GEbkN9WsFbQFWvSpHzuh 9UIyxOAAMQoM0pYJA4mTgXxjqIhgIi5af+p69+TIY0KYG5fPZoyhEx7uv/KvJYEoAtpt 5rde6xNYNtclFxCOLWRzTtQVQ9WjEpp+s2E1p2akvlMW1SWneEp7qMjmYO3ZM9yM72A2 kTjw== X-Gm-Message-State: APjAAAWDE0+lFvGBFpBR46/UmpIckUv8JUCdSYOh+ro+YTqFlYavOdc7 bJGqGWJYd/rQnYyytDMQBXQi6hQ0YxVPmpit82XVNe7ydsI= X-Google-Smtp-Source: APXvYqxGDgaIn+HfYsTwbMBC+Pdwg4K0E+ewCtxJS3/CR9g3EQQy8p035pCTNYWDJ0EERKHwC2FyD2FXroKhz/Lev7Q= X-Received: by 2002:a1c:7914:: with SMTP id l20mr16289562wme.155.1569832077596; Mon, 30 Sep 2019 01:27:57 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Denis Garus Date: Mon, 30 Sep 2019 11:27:45 +0300 Message-ID: Subject: Re: JavaDoc for Event's subjectId methods To: dev@ignite.apache.org, Maksim Stepachev Content-Type: multipart/alternative; boundary="000000000000579b340593c103c7" --000000000000579b340593c103c7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello! I suggested to Maksim Stepachev include these changes in the scope of your thicket [1] and it looks like he agreed [2]. Maksim Stepachev, could you please reflect JavaDoc and behavior changes of events in your ticket? 1. https://issues.apache.org/jira/browse/IGNITE-11992 2. http://apache-ignite-developers.2346864.n4.nabble.com/Improvements-for-new-= security-approach-td42698.html =D0=BF=D0=BD, 30 =D1=81=D0=B5=D0=BD=D1=82. 2019 =D0=B3. =D0=B2 11:07, Ivan = Pavlukhin : > Hi, > > Do we allow commits to master without a ticket? I can imagine only > reverts as an exception. > > Otherwise a ticket is a primary process item. Work description, > review, CI checks (we have a job checking javadocs). > > =D1=81=D1=80, 25 =D1=81=D0=B5=D0=BD=D1=82. 2019 =D0=B3. =D0=B2 01:15, Den= is Magda : > > > > Denis, please feel free to go and edit the JavaDocs in place without a > > ticket. The changes suggested by you are reasonable. > > > > - > > Denis > > > > > > On Tue, Sep 24, 2019 at 3:55 AM Denis Garus wrote= : > > > > > Hello, Igniters! > > > > > > Some events contain the subjectId method, for example, > TaskEvent#subjectId. > > > The JavaDoc for this method is: > > > "Gets security subject ID initiated this task event, if available. > > > This property is not available for > GridEventType#EVT_TASK_SESSION_ATTR_SET > > > task event. > > > Subject ID will be set either to node ID or client ID initiated task > > > execution." > > > > > > I think It's wrong. The main point is a subject id doesn't have any > sense > > > if IgniteSecurity is disabled. > > > However, if IgniteSecurity is enabled, the method must return the > subject > > > id from the current security context. > > > Thus, the description (and behavior) of the method should be the > following: > > > Gets security subject ID initiated this task event if IgniteSecurity = is > > > enabled, otherwise returns null. > > > > > > The same is actual for CacheEvent, CacheQueryExecutedEvent and > > > CacheQueryReadEvent. > > > > > > If there are no objections, I am going to create a relevant issue in > Jira. > > > > > > > -- > Best regards, > Ivan Pavlukhin > --000000000000579b340593c103c7--