From dev-return-46843-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Aug 2 08:32:31 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id AFF73180647 for ; Fri, 2 Aug 2019 10:32:30 +0200 (CEST) Received: (qmail 7029 invoked by uid 500); 2 Aug 2019 08:32:29 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 7011 invoked by uid 99); 2 Aug 2019 08:32:28 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Aug 2019 08:32:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id EFBA8C056A for ; Fri, 2 Aug 2019 08:32:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.201 X-Spam-Level: X-Spam-Status: No, score=-0.201 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id W8vRMuitniAj for ; Fri, 2 Aug 2019 08:32:26 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.167.67; helo=mail-lf1-f67.google.com; envelope-from=maxmuzaf@gmail.com; receiver= Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id A1DFDBC7F2 for ; Fri, 2 Aug 2019 08:32:25 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id x3so52447603lfc.0 for ; Fri, 02 Aug 2019 01:32:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=POyU1phK9g5CTsUQplfABN9q3DUFw7FlY2Oq187NDBc=; b=q2cmv47UyVPrT1HMRZ0cMUxqO+Fa9SQ/vMtN6ZWIOhFXIrdGjKeiVS6M6xkAZdRUjE fzIily4iw2aVSqNndHeBdc1atmE/kWl09ZXdrSA8ZxBXS3M976fz4neIiMbg61d8c31T VS8rbjvgb5Lbn+78LlpHYSVCpFcTbtg7J2VqTti26kGSawmYIfak0s65WNW8Yo1UTwu3 WgXYScNYLhz++6RLz7E0cw+/dqxJ2lmNgpP+cHwjp6jgvjBjxdIVTykCPSOxocrqev7B 6zg9WTWqyavT72Lor/AqT6cup2idVHbFniqo8rDqmmf6hVYcJDVIosfyK8B+A10IZ/QO DocA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=POyU1phK9g5CTsUQplfABN9q3DUFw7FlY2Oq187NDBc=; b=DI/aSNUXkRVpsEEj7SuW96TOYsdM8ny8F5t5lEH4SF9v9GN3UhMUtUeZfXV/kwtE80 qOvD4keXo+2dHaGnN4y9i/tHzw6Vu2T8Y4DA1aCdhSD9/ZL7o6GE0QIlAao7uxK6X1xV HHtlV+xs2Gy770NTRqtbCYiT2GAxGrbpCicnN8Ml/eb6WwSLkb1MwE8qL2XA8hzTdY0r ybsQP4zOXBZJ1TS/GzBCP4FQGF0/KeIlaEfel0hpbYDli+s0jIkqebGagFNxQkE5ccch ad0M6h0Pbpqf2ia4+JFiR5AArtlIGI4k0R0HU35ERISqQciKEChQpk9z4HCsX3C/C/Bo ldPg== X-Gm-Message-State: APjAAAUY2fTftGj9EmSJXDbHi8vIUWkIQFvuEb57SiCD/TgO66WEVAMl /iy0QCFHPvLHwpFY6F2uu6ODaxMBDGR8qIY0VjLjzfNB X-Google-Smtp-Source: APXvYqztzcYRQ62yA6v6NTi8LnMa2QWBAmqid0mAAfjUQ878oQbWT+1Lw6xAJ7gNXlO5gUFUXZ71+t+sXH1S9QD0XYE= X-Received: by 2002:a19:4a50:: with SMTP id x77mr19341522lfa.91.1564734737365; Fri, 02 Aug 2019 01:32:17 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Maxim Muzafarov Date: Fri, 2 Aug 2019 11:32:05 +0300 Message-ID: Subject: Re: Deprecate\remove REBALANCE_OBJECT_LOADED cache event To: dev@ignite.apache.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Igniters, I've created a ticket [1]. [1] https://issues.apache.org/jira/browse/IGNITE-12035 On Thu, 1 Aug 2019 at 10:55, Pavel Kovalenko wrote: > > Hello Maxim, > > Thank you for researching this. > It seems those events can be used as an interceptor for the rebalance > process to make some extra actions after the entry is rebalanced. > However, I don't see any real usages despite tests. Most likely > functionality that used such rebalance events no longer exists. > I see no reasons to have it anymore. > +1 for removing in 2.8 > > > =D1=81=D1=80, 31 =D0=B8=D1=8E=D0=BB. 2019 =D0=B3. =D0=B2 20:54, Maxim Muz= afarov : > > > Igniters, > > > > > > I've faced with EVT_CACHE_REBALANCE_OBJECT_LOADED [1] and > > EVT_CACHE_REBALANCE_OBJECT_UNLOADED [2] cache events and not fully > > understand their general purpose. Hope someone from the community can > > clarify to me the initial idea of adding these events. > > > > The first - it seems to me that these events are completely Ignite > > internal thing. Why the user should be able to subscribe to such > > events? (not related to tracking cache keys metrics). Once the data is > > loaded to cache, I see no reasons to notifying the user about moving > > cache keys from one node to another if the cluster topology changed. > > It's up to Ignites mission to keep data consistency in any cases. > > > > The second - I haven't found any real usages on GitHub\Google of these > > events. Most of the examples are related to our community members and > > Ignites documentation. > > > > The third - Correct me if I am wrong, but subscribing for Ignites > > events can have a strong influence on the cluster performance. So > > fewer events available to users the better performance will be. > > > > > > I think these events can be easily removed in the next 2.8 release. > > WDYT? Am I missing something? > > > > [1] > > https://ignite.apache.org/releases/latest/javadoc/org/apache/ignite/eve= nts/EventType.html#EVT_CACHE_REBALANCE_OBJECT_LOADED > > [2] > > https://ignite.apache.org/releases/latest/javadoc/org/apache/ignite/eve= nts/EventType.html#EVT_CACHE_REBALANCE_OBJECT_UNLOADED > >