ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunny Chan (Jira)" <j...@apache.org>
Subject [jira] [Created] (IGNITE-12120) Change log level in GridCacheWritebehindStore
Date Thu, 29 Aug 2019 09:21:00 GMT
Sunny Chan created IGNITE-12120:

             Summary: Change log level in GridCacheWritebehindStore
                 Key: IGNITE-12120
                 URL: https://issues.apache.org/jira/browse/IGNITE-12120
             Project: Ignite
          Issue Type: Bug
          Components: cache
    Affects Versions: 2.7.5
            Reporter: Sunny Chan

In the [GridCacheWriteBehindStore|https://github.com/apache/ignite/blob/7e73098d4d6e3d5f78326cb11dac7e083a2312dd/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/store/GridCacheWriteBehindStore.java#L893],
when the updateStore failed to write to underlying store, it logs this as error:

{{LT.error(log, e, "Unable to update underlying store: " + store);}}

After this line logged the error, it would return false so that it would retry the store (by
returning false).  

While later on in the updatStore function, when the writeCache overflows, it would log this:

{{log.warning("Failed to update store (value will be lost as current buffer size is greater
" + …}}

then it will remove the failed entry.

I think the severity of the log messages is not right, as the fail update would still be retried.

So I propose to change the log severity level so that the first one would be a warn, and second
one would be error

This message was sent by Atlassian Jira

View raw message