From dev-return-46800-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Jul 26 13:54:15 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 330FC180595 for ; Fri, 26 Jul 2019 15:54:15 +0200 (CEST) Received: (qmail 47120 invoked by uid 500); 26 Jul 2019 13:54:14 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 47108 invoked by uid 99); 26 Jul 2019 13:54:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jul 2019 13:54:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A0EF81825C8 for ; Fri, 26 Jul 2019 13:54:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.799 X-Spam-Level: * X-Spam-Status: No, score=1.799 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id fkZYYq_EJjEx for ; Fri, 26 Jul 2019 13:54:12 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.167.49; helo=mail-lf1-f49.google.com; envelope-from=zaleslaw.sin@gmail.com; receiver= Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id BF3D0BC7E1 for ; Fri, 26 Jul 2019 13:54:11 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id q26so37176502lfc.3 for ; Fri, 26 Jul 2019 06:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Fo412qArkbMcEoR6J1hkkMd+4C2om6FhuDajdjT4GVw=; b=ZRTFlMGQGulvimRqA/oG4eaBt9wEjGVO+8gLG9mdL3KlmtRzRX7Ui0LyIH886nbT33 dwOkGPjsN6rTcDiXEqY2qbYhWoCMXBXZF6m6fCvzJqF7hhLr2PlDB4seqWv8kKTBDn1z gpq1ECUwGsdSMQoV1xlRWHYaAr24UmecpFNzT7PNFfWF9pC7kNgz0S41v6k41Rs+7ZtA amY7smyGF7dC7juS4V9izW54tEu3VEiMmSvZRoDVSFkk7kBRyAj+pv8I0+1Dr30sZvAl x5xwy9bHH9x0xuX2OYojV1/gQlBr2epND2Bf92XE2WgBDNYJcNt3RmDv3ydMditDvyvo nwxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Fo412qArkbMcEoR6J1hkkMd+4C2om6FhuDajdjT4GVw=; b=eGh3nbupzbkTCeTxn9i9S2B+6SSkAYuOZLEmdsrQ2xtDsuyLa13IRHEE2G4mOZojMx O1kuIK3MT80MNu6KQAlkZeYR5ffaJZ/2XaXKynoWI8IW9m2n+crm2qTXgYaVcjz1fTuA zpc2C5fi/7reiVczTz3eEo/6x2CXlb9hS1L9uNXA626aQEFasyLVgQ7Sjha5SWSJF3no vW9nbrbgS5R8K6obHt6h3jBesvdV1l3uZl7NgEj/IttwCp3j/zvZzdY98eerJ3Hvfmoe uZoBSK0cE1TFvPwef4v6Ll37upJK/tqexLKlXTnFJDfEt4n5t49kVrNNQmXEJbYdKL3j oI/Q== X-Gm-Message-State: APjAAAU2AZaVi6abp/bW9yraBgSnLe/QP/Ib0Ij9LL6DPwgWMSc7EL10 0L9h/7D7v7W6CIdcJNnCCONFJLvXwuAhGk21RIg= X-Google-Smtp-Source: APXvYqyp/gUN6kRUII98iVDae/7qIsvyChRsFvsscK0n3vQ4rUxP8YVo4NmmnsK8pjbCAxIqDOLgUJAMSEiTaTQZKbs= X-Received: by 2002:a19:5d53:: with SMTP id p19mr41037011lfj.109.1564149250436; Fri, 26 Jul 2019 06:54:10 -0700 (PDT) MIME-Version: 1.0 References: <1708761101.1.1564079205079.JavaMail.dpavlov@app02> <61ee00160f378e2b47d00ce94aeb15f13c879bf4.camel@gmail.com> In-Reply-To: From: Alexey Zinoviev Date: Fri, 26 Jul 2019 18:53:59 +0500 Message-ID: Subject: Re: [MTCGA]: new failures in builds [4394336] needs to be handled To: Dmitriy Pavlov Cc: dev Content-Type: multipart/alternative; boundary="00000000000072b412058e95e048" --00000000000072b412058e95e048 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Igniters, many thanks for the update on my PR, I didn't merge for a 3 months and doesn't know that rules were changed Please, revert my commit, I will update my PR according CheckStyle job Please, tell me, is CheckStyle bot recommendations and changing of PR name (with ticket name addition) is enough to finish this issue? Thanks a lot for the clarification =D0=BF=D1=82, 26 =D0=B8=D1=8E=D0=BB. 2019 =D0=B3. =D0=B2 18:28, Dmitriy Pav= lov : > +1 to revert. Some day we should learn this process. Maybe this day is > today. > > =D0=BF=D1=82, 26 =D0=B8=D1=8E=D0=BB. 2019 =D0=B3. =D0=B2 10:00, Nikolay I= zhikov : > >> +1 to revert. >> >> =D0=92 =D0=9F=D1=82, 26/07/2019 =D0=B2 09:48 +0300, =D0=9F=D0=B0=D0=B2= =D0=BB=D1=83=D1=85=D0=B8=D0=BD =D0=98=D0=B2=D0=B0=D0=BD =D0=BF=D0=B8=D1=88= =D0=B5=D1=82: >> > Alexey, >> > >> > Actually the commit [1] is very suspicious: >> > 1. Commit message "[ML] Hyper-parameter tuning via Genetic Algorithm >> > (#6713)" does not refer to a ticket. >> > 2. Is there a ticket? Consequently it is not easy to understand what >> > was done and check ticket according to regular flow (review, TC run). >> > 3. I skimmed through changes and found several code style violations >> quite soon. >> > >> > Should we revert the commit [1] and apply the changes according to our >> > conventions [2]? >> > >> > [1] >> https://github.com/apache/ignite/commit/63fbcbf849640edf140047a5111a58f4= 80c95294 >> > [2] >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute >> > >> > =D1=87=D1=82, 25 =D0=B8=D1=8E=D0=BB. 2019 =D0=B3. =D0=B2 21:26, : >> > > >> > > Hi Igniters, >> > > >> > > I've detected some new issue on TeamCity to be handled. You are mor= e >> than welcomed to help. >> > > >> > > If your changes can lead to this failure(s): We're grateful that yo= u >> were a volunteer to make the contribution to this project, but things >> change and you may no longer be able to finalize your contribution. >> > > Could you respond to this email and indicate if you wish to continu= e >> and fix test failures or step down and some committer may revert you com= mit. >> > > >> > > * New Trusted Suite failure in master [Check Code Style] >> https://ci.ignite.apache.org/viewType.html?buildTypeId=3DIgniteTests24Ja= va8_CheckCodeStyle&branch=3D%3Cdefault%3E&tab=3DbuildTypeStatusDiv >> > > Changes may lead to failure were done by >> > > - zaleslaw.sin@gmail.com >> https://ci.ignite.apache.org/viewModification.html?modId=3D888540 >> > > >> > > - Here's a reminder of what contributors were agreed to do >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute >> > > - Should you have any questions please contact >> dev@ignite.apache.org >> > > >> > > Best Regards, >> > > Apache Ignite TeamCity Bot >> > > https://github.com/apache/ignite-teamcity-bot >> > > Notification generated at 21:26:38 25-07-2019 >> > >> > >> > >> > --00000000000072b412058e95e048--