From dev-return-46207-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Jun 7 13:23:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B8B1C18067E for ; Fri, 7 Jun 2019 15:23:05 +0200 (CEST) Received: (qmail 87796 invoked by uid 500); 7 Jun 2019 13:23:04 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 87785 invoked by uid 99); 7 Jun 2019 13:23:04 -0000 Received: from Unknown (HELO mailrelay1-lw-us.apache.org) (10.10.3.159) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Jun 2019 13:23:04 +0000 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id 501748AA7 for ; Fri, 7 Jun 2019 13:23:04 +0000 (UTC) Received: by mail-wr1-f50.google.com with SMTP id d18so2170756wrs.5 for ; Fri, 07 Jun 2019 06:23:04 -0700 (PDT) X-Gm-Message-State: APjAAAV1k6LrltqeNdmsbgX9+0Au8Ul9Kh+L9mIKhUIEDL7w6iFQr9lB 3Og1jXxTlGeFMdcUzd/MrogL7ObNSOEsAPTYCnQ= X-Google-Smtp-Source: APXvYqxaBsbyWOjs7qYUzaQ9dpcFLg1Fpjw3p2DwrwJiQcQefxoy7W0jhbi7RBOjW3lFV9MsH9RrA9fcBwB1uc/UD+A= X-Received: by 2002:a5d:488a:: with SMTP id g10mr33422881wrq.344.1559913783295; Fri, 07 Jun 2019 06:23:03 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Gura Date: Fri, 7 Jun 2019 16:22:52 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Code styles issues in IGNITE-11750 To: dev Content-Type: text/plain; charset="UTF-8" Big +1 from me. Make code base clean and clear. On Fri, Jun 7, 2019 at 3:26 PM Nikolay Izhikov wrote: > > Hello, Igniters. > > Please, pay attention to commits quality. > > 1. Please, writer Javadocs. > 2. Please, make the new lines according to code style. > > Issues like [1] has to be fixed *BEFORE* commit. > > > [1] https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/SharedPageLockTracker.java#L45 >