From dev-return-46155-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Wed Jun 5 09:14:16 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0A14818065D for ; Wed, 5 Jun 2019 11:14:15 +0200 (CEST) Received: (qmail 27500 invoked by uid 500); 5 Jun 2019 09:14:15 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 27446 invoked by uid 99); 5 Jun 2019 09:14:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Jun 2019 09:14:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 479E3180C62 for ; Wed, 5 Jun 2019 09:14:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.737 X-Spam-Level: X-Spam-Status: No, score=-0.737 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.638, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id jOpXarwNETEx for ; Wed, 5 Jun 2019 09:14:12 +0000 (UTC) Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id A16DB5FCE0 for ; Wed, 5 Jun 2019 09:14:11 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id m23so641258lje.12 for ; Wed, 05 Jun 2019 02:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:message-id:subject:to:date:in-reply-to:references :mime-version; bh=9LE73Y33dAfLiexYmrRVP2296Wz/ipGVVMit+7cPDNw=; b=RB51J2QCMxZdUat40iZnWdwVXRFp6yscNgSrRpbGu5Z073gZaklE46AlPAJ8Pimqf3 p7sFExY6Tfx11KhVG5PXYFxVaDOqsLyG+ryjnAB+LwLyBT3b1nEWorWItsVK7HrBauOa f4/bdXg45nnFTIvDbGJlIX7aJ69Lk6VUXWsuw3LyYnuyW05DowwXKEHJipZ+Inp2Jgy4 JIENS8vVZU6/M1gTr7GCyJb41ldW9QtPJfqKJCGeimQStWlMrEMCH7CZ7R97ucgECQKx JGaF/DNT43K8V6KcULEGrbxp1Za28RkBbIl7I/KCHmZQ3zh+osbdv2wfh/64H4xdWL0X xoqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:message-id:subject:to:date :in-reply-to:references:mime-version; bh=9LE73Y33dAfLiexYmrRVP2296Wz/ipGVVMit+7cPDNw=; b=Gm+bUmQYWj4EftMMi869jS51BScOT3aul45vzJ3c4n1HKNBqQWa3JmJfhCi4ceLq+3 HJl/mYd45ngvL1/N6p6Jy/LwJdNd92cyxDMGr89QMHziZNGspe7tB25rQ2ZqIWh7a/uM 0GnScQnefc4mDGOWYihAzlQN+Af2J+YTHpEYWAqxrCRlEFnv+1jb/EK/uFmjfnK1fdZ7 YbN0U1gvCwvX7e2dlxhC/jCmdhun1lIkHPWzLNSHLoDDNk0Z1AD8KbLgSEIWLcG1Jni8 xhhrg9PWwnNdTHZyqrZD5MRESbzrYFvreXdz3lTB6tVY3WHfn6cok8mUg+uP0/YmRmkc 5Ieg== X-Gm-Message-State: APjAAAWjubYe8rFjMdOfH87lOrNqNJ+ACQ/xDPcJb2ERjQ3JaeZcqr/B kp+9QkvUJbbeK6E8+/0O2NeAMrgQ X-Google-Smtp-Source: APXvYqwWz3YPJ1QLPJTS/i/aGUV83GpLQOM9U0Q6yJmWEREbwUzqTAENZX3FUw2cuT2JvUKCeKEX1Q== X-Received: by 2002:a2e:7f06:: with SMTP id a6mr4935215ljd.173.1559726050236; Wed, 05 Jun 2019 02:14:10 -0700 (PDT) Received: from newDragon ([194.186.207.248]) by smtp.googlemail.com with ESMTPSA id r11sm3705865ljh.90.2019.06.05.02.14.09 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Jun 2019 02:14:09 -0700 (PDT) Sender: =?UTF-8?B?0J3QuNC60L7Qu9Cw0Lkg0JjQttC40LrQvtCy?= From: Nikolay Izhikov X-Google-Original-From: Nikolay Izhikov Message-ID: <144ddc8fed98aa6e05739f1fc05b3d7f7048aa17.camel@gmail.com> Subject: Re: [TC] Examples suite issues To: dev@ignite.apache.org Date: Wed, 05 Jun 2019 12:16:32 +0300 In-Reply-To: <87AFFB45-B288-4396-9F38-4F79F88F0A16@gmail.com> References: <18dcb463d64bdd8a267debe38bff124ecf3acc5c.camel@gmail.com> <3b6aad07f536f89a9635fea046756a0faccf7abd.camel@gmail.com> <7b1760e2c693897df438349d2b6c789e5288bf4a.camel@gmail.com> <87AFFB45-B288-4396-9F38-4F79F88F0A16@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-ngbbcPrTlvLw80FW0TaM" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 --=-ngbbcPrTlvLw80FW0TaM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Petr. Current PR solves the following issue: "Data Frame examples crashes in mast= er". We need to solve one more issue:=20 "Data Frame examples not tested on TC" - this require "scala" profile in "B= uild Ignite" suite. =D0=92 =D0=A1=D1=80, 05/06/2019 =D0=B2 12:05 +0300, Petr Ivanov =D0=BF=D0= =B8=D1=88=D0=B5=D1=82: > > On 5 Jun 2019, at 11:49, Nikolay Izhikov wrote: > >=20 > > > 1. Why does your PR show only single file changed? > >=20 > > Because this change fix the issue described in the ticket [1] >=20 > So changes in intermediate commits were reverted in branch? >=20 >=20 > >=20 > > > 2. Can you describe the problem once more, please? Is it about > >=20 > > :ignite-examples module not being build in ~Build Apache Ignite~ ? > >=20 > > Spark examples activated only if `scala` profile enabled. > > There is no `scala` profile in "~Build Apache Ignite~", only `all-scala= `. >=20 > Let's add 'scala' profile into build. >=20 >=20 > >=20 > >=20 > >=20 > > [1] https://issues.apache.org/jira/browse/IGNITE-11881 > >=20 > > =D1=81=D1=80, 5 =D0=B8=D1=8E=D0=BD. 2019 =D0=B3. =D0=B2 10:59, Petr Iva= nov : > >=20 > > > Nikolay, > > >=20 > > >=20 > > > 1. Why does your PR show only single file changed? > > > 2. Can you describe the problem once more, please? Is it about > > > :ignite-examples module not being build in ~Build Apache Ignite~ ? > > >=20 > > >=20 > > >=20 > > > > On 4 Jun 2019, at 20:34, Nikolay Izhikov wrot= e: > > > >=20 > > > > Hello, Igniters. > > > >=20 > > > > Root of the issue is in our maven profiles hierarchy. > > > >=20 > > > > "Build Ignite" suite on TC activate 'all-scala' and examples module= have > > >=20 > > > only 'scala' profile. > > > > To reduce copy-pase I added 'scala' profile of examples module > > >=20 > > > activation based on system property 'scala-examples'. > > > >=20 > > > > So, for now my PR [1] fixes both issues with examples module: > > > >=20 > > > > 1. Unnecessary dependecies that leads to Spark examples crash. > > > > 2. Spark examples not tested on TC. > > > >=20 > > > > After merge of PR [1] we should add this property to "Build Ignite" > > >=20 > > > suite. > > > >=20 > > > > Is there any objections? > > > >=20 > > > > [1] https://github.com/apache/ignite/pull/6587 > > > >=20 > > > > [2] > > >=20 > > > https://ci.ignite.apache.org/viewLog.html?buildId=3D4041670&buildType= Id=3DIgniteTests24Java8_Examples&tab=3DtestsInfo&branch_IgniteTests24Java8= =3Dpull%2F6587%2Fhead > > > >=20 > > > >=20 > > > > =D0=92 =D0=92=D1=82, 04/06/2019 =D0=B2 16:56 +0300, Nikolay Izhikov= =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > > > > I moved jackson dependencies to maven-javadoc-plugin additional > > >=20 > > > dependencies. > > > > > Seems, it solves both issues: Data Frame examples and javadoc > > >=20 > > > generation. > > > > >=20 > > > > > But, Data Frame examples still doesn't shows in tc log. > > > > >=20 > > > > > Will investigate it, shortly. > > > > >=20 > > > > >=20 > > >=20 > > > https://ci.ignite.apache.org/viewLog.html?buildId=3D4039945&tab=3Dque= uedBuildOverviewTab > > > > >=20 > > > > > https://ci.ignite.apache.org/viewLog.html?buildId=3D4039943&;;; > > > > >=20 > > > > > =D0=92 =D0=92=D1=82, 04/06/2019 =D0=B2 15:45 +0300, =D0=9F=D0=B0= =D0=B2=D0=BB=D1=83=D1=85=D0=B8=D0=BD =D0=98=D0=B2=D0=B0=D0=BD =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: > > > > > > Would be great if it is possible. > > > > > >=20 > > > > > > =D0=B2=D1=82, 4 =D0=B8=D1=8E=D0=BD. 2019 =D0=B3. =D0=B2 15:43, = Nikolay Izhikov : > > > > > > >=20 > > > > > > > I used to think it's forbidden to use direct version in pom.x= ml. > > > > > > > We should keep all versions in parent pom. > > > > > > >=20 > > > > > > >=20 > > > > > > > =D0=92 =D0=92=D1=82, 04/06/2019 =D0=B2 15:36 +0300, =D0=9F=D0= =B0=D0=B2=D0=BB=D1=83=D1=85=D0=B8=D0=BD =D0=98=D0=B2=D0=B0=D0=BD =D0=BF=D0= =B8=D1=88=D0=B5=D1=82: > > > > > > > > Nikolay, > > > > > > > >=20 > > > > > > > > It was already observed that removal of jackson dependencie= s from > > > > > > > > examples module would lead to a Javadoc build job failure (= for > > > > > > > > examples module). One way to fix it is changing jackson dep= endency > > > > > > > > versions: > > > > > > > > > > > > > > > > com.fasterxml.jackson.core > > > > > > > > jackson-core > > > > > > > > 2.6.7 > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > com.fasterxml.jackson.core > > > > > > > > jackson-databind > > > > > > > > 2.6.7 > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > com.fasterxml.jackson.core > > > > > > > > jackson-annotations > > > > > > > > 2.6.7 > > > > > > > > > > > > > > > >=20 > > > > > > > > =D0=B2=D1=82, 4 =D0=B8=D1=8E=D0=BD. 2019 =D0=B3. =D0=B2 14:= 57, Nikolay Izhikov : > > > > > > > > >=20 > > > > > > > > > Igniters > > > > > > > > >=20 > > > > > > > > > I've found the root issue. > > > > > > > > >=20 > > > > > > > > > jackson dependency was added in IGNITE-10803 and that's b= rokes > > >=20 > > > Spark Examples. > > > > > > > > >=20 > > > > > > > > > Alex, Yury, please, clarify, do we really need this depen= dencies? > > > > > > > > >=20 > > > > > > > > > =D0=92 =D0=92=D1=82, 04/06/2019 =D0=B2 11:42 +0300, =D0= =9F=D0=B0=D0=B2=D0=BB=D1=83=D1=85=D0=B8=D0=BD =D0=98=D0=B2=D0=B0=D0=BD =D0= =BF=D0=B8=D1=88=D0=B5=D1=82: > > > > > > > > > > But -Pscala is already activated. But it seems that a b= uild job in > > > > > > > > > > question does not compile classes and retrieves a compi= led package > > > > > > > > > > from ~Build Apache Ignite~ job. Need to check if spark = examples are > > > > > > > > > > present. > > > > > > > > > >=20 > > > > > > > > > > =D0=B2=D1=82, 4 =D0=B8=D1=8E=D0=BD. 2019 =D0=B3. =D0=B2= 09:52, =D0=9F=D0=B0=D0=B2=D0=BB=D1=83=D1=85=D0=B8=D0=BD =D0=98=D0=B2=D0=B0= =D0=BD : > > > > > > > > > > >=20 > > > > > > > > > > > Nikolay, > > > > > > > > > > >=20 > > > > > > > > > > > It looks like that profile -Pscala should be activate= d to run > > > > > > > > > > > IgniteExamplesSparkSelfTestSuite. I was able to start= that suite > > > > > > > > > > > execution on my machine but it failed during executio= n. > > > > > > > > > > >=20 > > > > > > > > > > > =D0=B2=D1=82, 4 =D0=B8=D1=8E=D0=BD. 2019 =D0=B3. =D0= =B2 03:08, Denis Magda : > > > > > > > > > > > >=20 > > > > > > > > > > > > Hey Peter, Anton, > > > > > > > > > > > >=20 > > > > > > > > > > > > Are any of you able to help Nickolay with [1]? > > > > > > > > > > > >=20 > > > > > > > > > > > > - > > > > > > > > > > > > Denis > > > > > > > > > > > >=20 > > > > > > > > > > > >=20 > > > > > > > > > > > > On Mon, Jun 3, 2019 at 6:17 AM Nikolay Izhikov < > > >=20 > > > nizhikov@apache.org> wrote: > > > > > > > > > > > >=20 > > > > > > > > > > > > > Hello, Igniters. > > > > > > > > > > > > >=20 > > > > > > > > > > > > > We have several issues with Examples suite on TC > > > > > > > > > > > > >=20 > > > > > > > > > > > > > 1. IgniteExamplesSparkSelfTestSuite seems configu= re, bu not > > >=20 > > > runs on suite > > > > > > > > > > > > > execution. [1] > > > > > > > > > > > > >=20 > > > > > > > > > > > > > 2. Spark Data Frame examples doesn't work in mast= er. Seems some > > >=20 > > > classpath > > > > > > > > > > > > > issues [2] > > > > > > > > > > > > >=20 > > > > > > > > > > > > > I will resolve issue #2. > > > > > > > > > > > > > Can anyone help me with #1? > > > > > > > > > > > > >=20 > > > > > > > > > > > > >=20 > > > > > > > > > > > > > [1] > > > > > > > > > > > > >=20 > > >=20 > > > https://ci.ignite.apache.org/viewLog.html?buildId=3D4027327&buildType= Id=3DIgniteTests24Java8_Examples&tab=3DbuildParameters > > > > > > > > > > > > > [2] https://issues.apache.org/jira/browse/IGNITE-= 11881 > > > > > > > > > > > > >=20 > > > > > > > > > > >=20 > > > > > > > > > > >=20 > > > > > > > > > > >=20 > > > > > > > > > > > -- > > > > > > > > > > > Best regards, > > > > > > > > > > > Ivan Pavlukhin > > > > > > > > > >=20 > > > > > > > > > >=20 > > > > > > > > > >=20 > > > > > > > >=20 > > > > > > > >=20 > > > > > > > >=20 > > > > > >=20 > > > > > >=20 > > > > > >=20 > > >=20 > > >=20 >=20 >=20 --=-ngbbcPrTlvLw80FW0TaM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEOiTcLcdgyP2exB5ZbiaPbjg91GUFAlz3iHAACgkQbiaPbjg9 1GUtGwf/Q+FQreN9+Igk42o9VdZdA6kgPKAGYKxPxF7R89tXVfqk1rFsx5QVditf 1no2wzxhdGegX8goS4run+J3B0+ZryQJ4PzDzgDKV8TBOh8jlQisHsvI1bOPEFX5 Ox+Lu1Oa4QcA7K6XhC7Ff8IM13WDOA1MM8sN8ZOmqekkGlGq97ayN0H9fiWFpEqx eZsrQI/EREyfSZPHZ6/s8r+4lV0P3pawtsc7FirwiVQuAvm524cpmw20bre+OP30 UfeVZznu7KoCGpoIvxlfFDrndfGJsJiingKHCeJRb/9v+EADsEjTpQ1M7okl77wB FvzZ0M21f/KRUDOEC/LP1OmRJahOpQ== =ZZWW -----END PGP SIGNATURE----- --=-ngbbcPrTlvLw80FW0TaM--