From dev-return-45577-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Tue Apr 2 17:04:07 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4E80C180668 for ; Tue, 2 Apr 2019 19:04:06 +0200 (CEST) Received: (qmail 89686 invoked by uid 500); 2 Apr 2019 17:04:05 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 89675 invoked by uid 99); 2 Apr 2019 17:04:05 -0000 Received: from mail-relay.apache.org (HELO mailrelay2-lw-us.apache.org) (207.244.88.137) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Apr 2019 17:04:05 +0000 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mailrelay2-lw-us.apache.org (ASF Mail Server at mailrelay2-lw-us.apache.org) with ESMTPSA id 1AC852BEF for ; Tue, 2 Apr 2019 17:04:04 +0000 (UTC) Received: by mail-wr1-f49.google.com with SMTP id t17so4561774wrw.13 for ; Tue, 02 Apr 2019 10:04:04 -0700 (PDT) X-Gm-Message-State: APjAAAXUupDe98Vksiy9J0SH6yDZRW0s7a4nUflbYsGj7Oafz/Bq2PxI qp3Qxl6KF70BgFU4xsAGRjoRKieQpMQBi7JzkV0= X-Google-Smtp-Source: APXvYqwNcqkiY1PALEFd1MP40yTgaKtNtStDDKGuEt9sKekR9mCdbImQTGBp+Y7Yae2EB4Vvnp0+a03ozumeN2f6y8o= X-Received: by 2002:a5d:4087:: with SMTP id o7mr36075992wrp.9.1554224643038; Tue, 02 Apr 2019 10:04:03 -0700 (PDT) MIME-Version: 1.0 References: <1553598474.845418022@f548.i.mail.ru> <2088013353.12659243.1553735904201@mail.yahoo.com> In-Reply-To: From: Dmitriy Pavlov Date: Tue, 2 Apr 2019 20:03:53 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Ignite 2.7.5 Release scope To: dev@ignite.apache.org Content-Type: multipart/alternative; boundary="000000000000bfe61105858f1ff3" --000000000000bfe61105858f1ff3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ivan P., it seems the netty approach you've proposed works well. Thank you. Igniters, please take a look at following fix: https://github.com/apache/ignite/pull/6384 It allows us to start under Java 12 and under Java 11- (as it). Sincerely, Dmitriy Pavlov =D0=BF=D1=82, 29 =D0=BC=D0=B0=D1=80. 2019 =D0=B3. =D0=B2 22:57, Dmitriy Pav= lov : > Denis, the issue here is that we don't know for sure. We see just one > blocking issue with accessing NioAccessObject. > > And there are 3 different scenario related to this issue fix: > - fixes won't help, and we should find out other options on how to create > a direct buffer from pointer - needed for durable memory, Java 12 goes to= a > later release. > - some fix would help, but other issues come, Java 12 goes to some later > release > - some from proposed fixes works, nothing else needs to be done - 1-2 day= s > > If it latest scenario, I would include as much as we can (1-2 days extra > are comparable with minimal voting time). > > BTW, I've checked scripts it does not work for me, I will ask Andrey > G/Peter for advice on Monday. > > Sincerely, > Dmitriy Pavlov > > > =D0=BF=D1=82, 29 =D0=BC=D0=B0=D1=80. 2019 =D0=B3. =D0=B2 20:47, Denis Mag= da : > >> Folks, >> >> What are the efforts to support Java 12? Let's do 2.7.6 shortly if the >> fixes are time-consuming. >> >> - >> Denis >> >> >> On Fri, Mar 29, 2019 at 10:08 AM Dmitriy Pavlov >> wrote: >> >> > Hi Igniters, >> > >> > I would like to announce code freeze for 2.7.5. Only one open ticket = is >> > there (reopened): https://issues.apache.org/jira/browse/IGNITE-11600 >> (if >> > we >> > can't start using Java 12 we should clearly state it in scripts/code). >> > >> > We're entering to Stabilization phase for >> > https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.7.5 >> and >> > only blockers may be included into scope. See >> > https://cwiki.apache.org/confluence/display/IGNITE/Release+Process for >> > more >> > details. >> > >> > Sincerely, >> > Dmitriy Pavlov >> > >> > =D0=BF=D1=82, 29 =D0=BC=D0=B0=D1=80. 2019 =D0=B3. =D0=B2 13:51, Dmitri= y Pavlov : >> > >> > > Hi Denis, >> > > >> > > I'm not talking about months. In this discussion, Andrey and Ivan >> > proposed >> > > a couple of fixes that may help. >> > > >> > > It will require a day or two to check if it helps. If it not helpful >> then >> > > we should modify startup scripts to say clearly that Java 12 is not >> > > supported. >> > > >> > > Now under Java 12 Ignite suggests to set startup parameters, but eve= n >> > with >> > > correct parameters, it fails and says please set parameters. Totally >> > > unclear for end-user. >> > > >> > > I've reopened https://issues.apache.org/jira/browse/IGNITE-11600 >> > > >> > > Sincerely, >> > > Dmitriy Pavlov >> > > >> > > =D1=87=D1=82, 28 =D0=BC=D0=B0=D1=80. 2019 =D0=B3. =D0=B2 18:51, Deni= s Magda : >> > > >> > >> If the failure handler improvements will lower down a number of >> > >> false-positive cluster shutdowns then I'm for the fix inclusion to >> the >> > >> release. >> > >> >> > >> As for Java 12, I would put to the next release that we can make >> shortly >> > >> after this one. We don't need to wait for months if there are some >> > urgent >> > >> fixes. >> > >> >> > >> - >> > >> Denis >> > >> >> > >> >> > >> On Thu, Mar 28, 2019 at 8:46 AM Dmitriy Pavlov >> > >> wrote: >> > >> >> > >> > Denis, I also +1 for python fix. Today is the planned date of cod= e >> > >> freeze, >> > >> > so today or tomorrow I'll announce it. >> > >> > >> > >> > Only one thing was suggested is the fix for failure handlers. I >> don't >> > >> > deeply understand the pros and cons, but I'm sure we should >> courteous >> > >> > enough for wait experienced folks to come to a consensus. >> > >> > >> > >> > One more thing I suggest to check after code freeze, it is Java >> 12. It >> > >> does >> > >> > not work now, but with thanks to Andrey G and Ivan P. we probably >> have >> > >> not >> > >> > very complex solution for this. >> > >> > >> > >> > So these 2 fixes are last candidates to come to scope. WDYT? >> > >> > >> > >> > Sincerely, >> > >> > Dmitriy Pavlov >> > >> > >> > >> > =D1=87=D1=82, 28 =D0=BC=D0=B0=D1=80. 2019 =D0=B3. =D0=B2 18:10, D= enis Magda : >> > >> > >> > >> > > Yes, the Python example's fix makes sense - that's a usability >> issue >> > >> and >> > >> > > doesn't affect the core components. >> > >> > > >> > >> > > In general, I would suggest us to do a code freeze and push oth= er >> > >> changes >> > >> > > to another release. We can't include everything. >> > >> > > >> > >> > > - >> > >> > > Denis >> > >> > > >> > >> > > >> > >> > > On Thu, Mar 28, 2019 at 3:01 AM Ilya Kasnacheev < >> > >> > ilya.kasnacheev@gmail.com >> > >> > > > >> > >> > > wrote: >> > >> > > >> > >> > > > Hello! >> > >> > > > >> > >> > > > How about adding >> > https://issues.apache.org/jira/browse/IGNITE-11366 >> > >> > > which >> > >> > > > fixes Python's release directory? >> > >> > > > >> > >> > > > I have stumbled on this issue personally. >> > >> > > > >> > >> > > > Regards, >> > >> > > > -- >> > >> > > > Ilya Kasnacheev >> > >> > > > >> > >> > > > >> > >> > > > =D1=87=D1=82, 28 =D0=BC=D0=B0=D1=80. 2019 =D0=B3. =D0=B2 04:1= 9, Roman Shtykh >> > > > >> >: >> > >> > > > >> > >> > > > > Dmitriy, the probability of having nodes down with these bu= gs >> > >> under >> > >> > > heavy >> > >> > > > > load conditions is pretty high. Good candidate for >> > cherry-picking. >> > >> > > > > >> > >> > > > > [1] https://issues.apache.org/jira/browse/IGNITE-9803[2] >> > >> > > > > https://issues.apache.org/jira/browse/IGNITE-11127 >> > >> > > > > -- Roman >> > >> > > > > >> > >> > > > > >> > >> > > > > On Wednesday, March 27, 2019, 2:11:49 a.m. GMT+9, Dmitr= iy >> > >> Pavlov >> > >> > < >> > >> > > > > dpavlov@apache.org> wrote: >> > >> > > > > >> > >> > > > > Hi, >> > >> > > > > >> > >> > > > > I've cherry-picked this commit. It seems it is critical >> because >> > it >> > >> > also >> > >> > > > > fixes storage corruption. >> > >> > > > > >> > >> > > > > Sincerely, >> > >> > > > > Dmitriy Pavlov >> > >> > > > > >> > >> > > > > =D0=B2=D1=82, 26 =D0=BC=D0=B0=D1=80. 2019 =D0=B3. =D0=B2 14= :14, Zhenya Stanilovsky >> > >> > > > > > >> > > > > >: >> > >> > > > > >> > >> > > > > > I suppose this ticket [1] : is very useful too. >> > >> > > > > > >> > >> > > > > > >> > >> > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-10873 [ >> > >> > > > > > CorruptedTreeException during simultaneous cache put >> > operations >> > >> ] >> > >> > > > > > >> > >> > > > > > > >> > >> > > > > > > >> > >> > > > > > >------- Forwarded message ------- >> > >> > > > > > >From: "Alexey Goncharuk" < alexey.goncharuk@gmail.com > >> > >> > > > > > >To: dev < dev@ignite.apache.org > >> > >> > > > > > >Cc: >> > >> > > > > > >Subject: Re: Ignite 2.7.5 Release scope >> > >> > > > > > >Date: Tue, 26 Mar 2019 13:42:59 +0300 >> > >> > > > > > > >> > >> > > > > > >Hello Ilya, >> > >> > > > > > > >> > >> > > > > > >I do not see any issues with the mentioned test. I see t= he >> > >> > following >> > >> > > > > > output >> > >> > > > > > >in the logs: >> > >> > > > > > > >> > >> > > > > > >[21:41:44] : [Step 4/5] [2019-03-22 21:41:44,970][INFO >> > >> > ][main][root] >> > >> > > > >>> >> > >> > > > > > >Stopping test: >> > >> > > > > > >> > >> > > > > > >> > >> > > > > >> > >> > > > >> > >> > > >> > >> > >> > >> >> > >> >TcpDiscoveryCoordinatorFailureTest#testCoordinatorFailedNoAddFinishedMe= ssageStartOneNode >> > >> > > > > > >in 37768 ms <<< >> > >> > > > > > >[21:41:44] : [Step 4/5] [2019-03-22 21:41:44,971][INFO >> > >> > ][main][root] >> > >> > > > >>> >> > >> > > > > > >Stopping test class: TcpDiscoveryCoordinatorFailureTest >> <<< >> > >> > > > > > >[21:41:44] : [Step 4/5] [2019-03-22 21:41:44,971][INFO >> > >> > ][main][root] >> > >> > > > >>> >> > >> > > > > > >Starting test class: IgniteClientConnectTest <<< >> > >> > > > > > > >> > >> > > > > > >The issue with Windows may be long connection timeouts, = in >> > this >> > >> > case >> > >> > > > we >> > >> > > > > > >should either split the suite into multiple ones or >> decrease >> > >> the >> > >> > SPI >> > >> > > > > > >timeouts. >> > >> > > > > > > >> > >> > > > > > >=D0=BF=D0=BD, 25 =D0=BC=D0=B0=D1=80. 2019 =D0=B3. =D0=B2= 11:24, Ilya Kasnacheev < >> > >> > > > > ilya.kasnacheev@gmail.com >> > >> > > > > > >: >> > >> > > > > > > >> > >> > > > > > >> Hello! >> > >> > > > > > >> >> > >> > > > > > >> It seems that I can no longer test this case, on >> account of >> > >> > > > > > >> >> > >> > > > > > >> >> > >> > > > > > >> > >> > > > > >> > >> > > > >> > >> > > >> > >> > >> > >> >> > >> TcpDiscoveryCoordinatorFailureTest#testClusterFailedNewCoordinatorInitia= lized >> > >> > > > > > >> hanging every time under Java 11 on Windows. >> > >> > > > > > >> >> > >> > > > > > >> Alexey, Ivan, can you please take a look? >> > >> > > > > > >> >> > >> > > > > > >> >> > >> > > > > > >> >> > >> > > > > > >> > >> > > > > >> > >> > > > >> > >> > > >> > >> > >> > >> >> > >> https://ci.ignite.apache.org/viewType.html?buildTypeId=3DIgniteTests24Ja= va8_SpiWindows&tab=3DbuildTypeStatusDiv&branch_IgniteTests24Java8=3D__all_b= ranches__ >> > >> > > > > > >> >> > >> > > > > > >> Regards, >> > >> > > > > > >> >> > >> > > > > > >> -- >> > >> > > > > > >> Ilya Kasnacheev >> > >> > > > > > >> >> > >> > > > > > >> >> > >> > > > > > >> =D0=BF=D1=82, 22 =D0=BC=D0=B0=D1=80. 2019 =D0=B3. =D0= =B2 16:59, Ilya Kasnacheev < >> > >> > > > > > ilya.kasnacheev@gmail.com >: >> > >> > > > > > >> >> > >> > > > > > >> > Hello! >> > >> > > > > > >> > >> > >> > > > > > >> > Basically there is a test that explicitly highlights >> this >> > >> > > problem, >> > >> > > > > > that >> > >> > > > > > >> is >> > >> > > > > > >> > running SSL tests on Windows + Java 11. They will >> hang on >> > >> > Master >> > >> > > > but >> > >> > > > > > >> pass >> > >> > > > > > >> > with this patch. >> > >> > > > > > >> > >> > >> > > > > > >> > I have started that on TC, results will probably be >> > >> available >> > >> > > > later >> > >> > > > > > >> today: >> > >> > > > > > >> > >> > >> > > > > > >> > >> > >> > > > > > >> >> > >> > > > > > >> > >> > > > > >> > >> > > > >> > >> > > >> > >> > >> > >> >> > >> https://ci.ignite.apache.org/viewType.html?buildTypeId=3DIgniteTests24Ja= va8_SpiWindows&tab=3DbuildTypeStatusDiv&branch_IgniteTests24Java8=3D__all_b= ranches__ >> > >> > > > > > >> > (mind the Java version). >> > >> > > > > > >> > >> > >> > > > > > >> > Regards, >> > >> > > > > > >> > -- >> > >> > > > > > >> > Ilya Kasnacheev >> > >> > > > > > >> > >> > >> > > > > > >> > >> > >> > > > > > >> > =D0=BF=D1=82, 22 =D0=BC=D0=B0=D1=80. 2019 =D0=B3. = =D0=B2 14:13, Maxim Muzafarov < >> > >> > > maxmuzaf@gmail.com >> > >> > > > > >: >> > >> > > > > > >> > >> > >> > > > > > >> >> Dmitry, Ilya, >> > >> > > > > > >> >> >> > >> > > > > > >> >> Yes, I've looked through those changes [1] as they >> can >> > >> affect >> > >> > > my >> > >> > > > > > local >> > >> > > > > > >> >> PR. Basically, changes look good to me. >> > >> > > > > > >> >> >> > >> > > > > > >> >> I'm not an expert with CommunicationSpi component, = so >> > can >> > >> > miss >> > >> > > > some >> > >> > > > > > >> >> details and I haven't tested these changes under Ja= va >> > 11. >> > >> One >> > >> > > > more >> > >> > > > > > >> >> thing I'd like to say, I would add additional tests >> to >> > PR >> > >> > that >> > >> > > > will >> > >> > > > > > >> >> explicitly highlight the problem being solved. >> > >> > > > > > >> >> >> > >> > > > > > >> >> >> > >> > > > > > >> >> [1] >> https://issues.apache.org/jira/browse/IGNITE-11299 >> > >> > > > > > >> >> >> > >> > > > > > >> >> On Thu, 21 Mar 2019 at 22:57, Dmitriy Pavlov < >> > >> > > > dpavlov@apache.org >> > >> > > > > > >> > >> > > > > > >> wrote: >> > >> > > > > > >> >> > >> > >> > > > > > >> >> > Hi Igniters, >> > >> > > > > > >> >> > >> > >> > > > > > >> >> > fix >> > https://issues.apache.org/jira/browse/IGNITE-11299 >> > >> > > Avoid >> > >> > > > > busy >> > >> > > > > > >> wait >> > >> > > > > > >> >> on >> > >> > > > > > >> >> > processWrite during SSL handshake. >> > >> > > > > > >> >> > seems to be blocker cause it is related to Java 1= 1 >> > >> > > > > > >> >> > >> > >> > > > > > >> >> > I see Maxim M left some comments. Ilya K., Maxim >> > M.were >> > >> > these >> > >> > > > > > >> comments >> > >> > > > > > >> >> > addressed? >> > >> > > > > > >> >> > >> > >> > > > > > >> >> > The ticket is in Patch Available. Reviewer needed= . >> > >> Changes >> > >> > > > > located >> > >> > > > > > >> in >> > >> > > > > > >> >> > GridNioServer. >> > >> > > > > > >> >> > >> > >> > > > > > >> >> > Sincerely, >> > >> > > > > > >> >> > Dmitriy Pavlov >> > >> > > > > > >> >> > >> > >> > > > > > >> >> > P.S. a quite obvious ticket came to sope, as well= : >> > >> > > > > > >> >> > >> https://issues.apache.org/jira/browse/IGNITE-11600 >> > >> > > > > > >> >> > >> > >> > > > > > >> >> > >> > >> > > > > > >> >> > =D1=87=D1=82, 21 =D0=BC=D0=B0=D1=80. 2019 =D0=B3.= =D0=B2 16:55, Petr Ivanov < >> > >> > > mr.weider@gmail.com >> > >> > > > > >: >> > >> > > > > > >> >> > >> > >> > > > > > >> >> > > Huge +1 >> > >> > > > > > >> >> > > >> > >> > > > > > >> >> > > Will try to add new JDK in nearest time to our >> > >> Teamcity. >> > >> > > > > > >> >> > > >> > >> > > > > > >> >> > > >> > >> > > > > > >> >> > > > On 21 Mar 2019, at 16:27, Dmitriy Pavlov < >> > >> > > > > dpavlov@apache.org >> > >> > > > > > > >> > >> > > > > > >> >> wrote: >> > >> > > > > > >> >> > > > >> > >> > > > > > >> >> > > > Hi Igniters, >> > >> > > > > > >> >> > > > >> > >> > > > > > >> >> > > > Meanwhile, Java 12 GA is available. I suggest >> at >> > >> least >> > >> > > test >> > >> > > > > our >> > >> > > > > > >> new >> > >> > > > > > >> >> tests >> > >> > > > > > >> >> > > > scripts with a couple of Java builds. WDYT? >> > >> > > > > > >> >> > > > >> > >> > > > > > >> >> > > > Sincerely, >> > >> > > > > > >> >> > > > Dmitriy Pavlov >> > >> > > > > > >> >> > > > >> > >> > > > > > >> >> > > > =D1=81=D1=80, 20 =D0=BC=D0=B0=D1=80. 2019 =D0= =B3. =D0=B2 19:21, Dmitriy Pavlov >> > >> > > > > > >> < dpavlov@apache.org >: >> > >> > > > > > >> >> > > > >> > >> > > > > > >> >> > > >> Hi Ignite Developers, >> > >> > > > > > >> >> > > >> >> > >> > > > > > >> >> > > >> In a separate discussion, I've shared a log >> with >> > >> all >> > >> > > > > commits. >> > >> > > > > > >> >> > > >> >> > >> > > > > > >> >> > > >> As far as I can see, nobody removed commits >> from >> > >> this >> > >> > > > sheet, >> > >> > > > > > so >> > >> > > > > > >> the >> > >> > > > > > >> >> > > scope >> > >> > > > > > >> >> > > >> of release will be discussed in another way: >> only >> > >> > > > explicitly >> > >> > > > > > >> >> declared >> > >> > > > > > >> >> > > >> commits will be cherry-picked. >> > >> > > > > > >> >> > > >> >> > >> > > > > > >> >> > > >> Sincerely, >> > >> > > > > > >> >> > > >> Dmitriy Pavlov >> > >> > > > > > >> >> > > >> >> > >> > > > > > >> >> > > >> > >> > > > > > >> >> > > >> > >> > > > > > >> >> >> > >> > > > > > >> > >> > >> > > > > > >> > >> > > > > > >> > >> > > > > > -- >> > >> > > > > > Zhenya Stanilovsky >> > >> > > > > > >> > >> > > > >> > >> > > >> > >> > >> > >> >> > > >> > >> > --000000000000bfe61105858f1ff3--