ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Kasnacheev <ilya.kasnach...@gmail.com>
Subject Re: [IMPROVEMENT] Use IgniteSystemProperties.getString(key) instead of System.getenv(key)
Date Mon, 15 Apr 2019 06:35:24 GMT
Hello!

I think it does indeed makes sense to always use
*IgniteSystemProperties.getStri**ng*

Regards,
-- 
Ilya Kasnacheev


чт, 11 апр. 2019 г. в 16:40, Alexey Kuznetsov <akuznetsov@apache.org>:

> Hi, Igniters.
>
> What do you think, if we will use " IgniteSystemProperties.getString(key)"
> instead of " System.getenv(key)"?
>
> IgniteSystemProperties.getString(key) method check System,properties
>  and if not found then check for System.getenv(key).
>
> The main purpose is to use it in tests, because it easily to set system
> property in Java code,
> and very non trivial to do the same for  environment variables.
>
> Does any body have objections if I create JIRA issue (with pull request) to
> replace all direct calls of  "System.getenv(key)" with
> IgniteSystemProperties.getString(key)?
>
> --
> Alexey Kuznetsov
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message