ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ivan Fedotov <ivanan...@gmail.com>
Subject Re: Review IGNITE-11411 'Remove tearDown, setUp from JUnit3TestLegacySupport'
Date Tue, 19 Mar 2019 08:49:13 GMT
Hi Eduard.

Thank you for your participation in the review. In case of any questions
feel free to ask me.

вт, 19 мар. 2019 г. в 11:04, Eduard Shangareev <eduard.shangareev@gmail.com
>:

> Hi.
>
> I am interested in. If nobody did it I would do it next week.
>
> On Tue, Mar 19, 2019 at 10:20 AM Ivan Fedotov <ivanan639@gmail.com> wrote:
>
> > Hi Igniters!
> >
> > Now I am working on iep-30[1] which is about fully 4->5 migration and
> > includes some moments according to JUnit 3->4 migration.
> > I am on the first stage and finishing ticket about removing tearDown,
> setUp
> > from JUnit3TestLegacySupport [2].
> >
> > In nutshell: I removed setUp, tearDown from JUnit3TestLegacySupport and
> > replaced them by beforeTest, afterTest in tests where they are used. That
> > brings us to the JUnit5 test scenario because setUp and tearDown are used
> > under Rule annotation in GridAbstractTest.
> >
> > Could somebody review this ticket, please?
> >
> > [1]
> >
> >
> https://cwiki.apache.org/confluence/display/IGNITE/IEP-30%3A+Migration+to+JUnit+5
> > [2] https://issues.apache.org/jira/browse/IGNITE-11411
> >
> > --
> > Ivan Fedotov.
> >
> > ivanan639@gmail.com
> >
>


-- 
Ivan Fedotov.

ivanan639@gmail.com

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message