ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Denis Magda <dma...@apache.org>
Subject Re: Addressing usability issues with JDK 9-11
Date Tue, 05 Mar 2019 04:25:06 GMT
Dmitriy and Dev,

Let's release Java 9 - 11 improvements that are already merged? In my
understanding, they address or soothe usability issues reported in the
original email.

I would take Ignite 2.7, merge the changes there and roll out 2.8 as soon
as we can.

-
Denis


On Tue, Feb 5, 2019 at 10:23 AM Denis Magda <dmagda@apache.org> wrote:

> Dmitry,
>
> Here is the ticket: https://issues.apache.org/jira/browse/IGNITE-11216
>
> Artem Budnikov reproduced the issue on Linux.
>
> -
> Denis
>
>
> On Mon, Feb 4, 2019 at 8:07 AM Dmitriy Pavlov <dpavlov@apache.org> wrote:
>
>> Igniters,
>>
>> I've created https://issues.apache.org/jira/browse/IGNITE-11189 as the
>> main
>> task to link particular steps to be done. 'Blocked by' link type is for
>> mandatory changes, 'relates to' - for desirable.
>>
>> BTW, examples seem to be running, the only reason they failed was missed
>> dependencies in standalone-pom. I've added notice into Github MD about it:
>>
>> https://github.com/apache/ignite/tree/master/examples#contributing-to-examples
>>
>> Denis,
>>
>> I will not be able to hunt/recruit individuals to contribute, so 'driving'
>> is better to treat as 'contributing'. About your failure at MAC OS, could
>> you please create a separate issue for this? You can link it with the
>> umbrella.
>>
>> Sincerely,
>> Dmitriy Pavlov
>>
>> пт, 1 февр. 2019 г. в 22:40, Denis Magda <dmagda@apache.org>:
>>
>> > Dmitry, thanks for driving this.
>> >
>> > 1. Startup of a node using both ignite.sh and ignite.bat works for
>> Windows,
>> > > OpenJDK 10.0.2. Failure from Denis still needs to be checked by MAC OS
>> > > Users.
>> >
>> >
>> > That's easy to reproduce - you need a machine with Mac OS Mojave and
>> latest
>> > Oracle JDK - "java version "11.0.2" 2019-01-15 LTS".
>> >
>> > By some reason, the script fails to set JVM_OPT parameters. If I do
>> "export
>> > JVM_OPT={parameters from the doc}" then everything starts working.
>> >
>> > -
>> > Denis
>> >
>> >
>> > On Fri, Feb 1, 2019 at 5:53 AM Dmitriy Pavlov <dpavlov@apache.org>
>> wrote:
>> >
>> > > Hi Igniters,
>> > >
>> > >
>> > >
>> > > 0. Results of TC Nightly Run All on Java 11 can be found here
>> > >
>> > >
>> >
>> https://ci.ignite.apache.org/viewLog.html?buildId=2963881&buildTypeId=IgniteTests24Java8_RunAll
>> > > <
>> > >
>> >
>> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_RunAll&branch_IgniteTests24Java8=ignite-11155&tab=buildTypeStatusDiv
>> > > >
>> > >
>> > >
>> > >
>> > > 19 suites & 580 tests failed. So we need to do one-by-one research
for
>> > > occurred problems.
>> > >
>> > >
>> > >
>> > > 1. Startup of a node using both ignite.sh and ignite.bat works for
>> > Windows,
>> > > OpenJDK 10.0.2. Failure from Denis still needs to be checked by MAC OS
>> > > Users.
>> > >
>> > > Control.sh https://issues.apache.org/jira/browse/IGNITE-11153 needs
>> to
>> > be
>> > > fixed. I hope Peter I. will pick up it, fix is quite simple.
>> > >
>> > > Details about illegal access and its warning can be found here:
>> > > http://openjdk.java.net/jeps/261#Relaxed-strong-encapsulation
>> > >
>> > >
>> > >
>> > > 2. Ignition.start warnings:
>> > > https://issues.apache.org/jira/browse/IGNITE-11155
>> > >
>> > >
>> > >
>> > > 3. I’ve done some fixes in the
>> > > https://issues.apache.org/jira/browse/IGNITE-11140 for examples, and
>> I’m
>> > > going to validate results once our Release is passing. Today’s build
>> > failed
>> > >
>> > >
>> > >
>> >
>> https://ci.ignite.apache.org/viewLog.html?buildId=2965908&buildTypeId=Releases_NightlyRelease_RunApacheIgniteNightlyRelease&tab=artifacts&branch_Releases_NightlyRelease=%3Cdefault%3E
>> > >
>> > >
>> > >
>> > > Sincerely,
>> > >
>> > > Dmitriy Pavlov
>> > >
>> > >
>> > > пт, 1 февр. 2019 г. в 00:18, Dmitriy Pavlov <dpavlov@apache.org>:
>> > >
>> > > > Hi Denis,
>> > > >
>> > > > yes, I definitely will close some of these points, I hope Peter I
>> will
>> > > > help with control.sh fix.
>> > > >
>> > > > Point 0. in my plan is to check TeamCity results for Java 11 Run.
>> > > >
>> > > > Unfortunately, I don't have MAC OS so I would appreciate some of MAC
>> > > users
>> > > > may double check launch issue. Please note it may be just a warning
>> > about
>> > > > illegal-access, even if it is set =permit. After this warning (it
is
>> > > > unavoidable for 1st time), everything should be ok.
>> > > >
>> > > > Sincerely,
>> > > > Dmitriy Pavlov
>> > > >
>> > > > чт, 31 янв. 2019 г. в 22:38, Denis Magda <dmagda@apache.org>:
>> > > >
>> > > >> Alright,
>> > > >>
>> > > >> That's what needs to be done:
>> > > >>
>> > > >>    1. Fix sh/bat scripts work - fails on my Mac OS Mojave and
>> latest
>> > > >> Oracle
>> > > >>    JDK - java version "11.0.2" 2019-01-15 LTS
>> > > >>    2. Change command line startup to output warning to stdout
and
>> logs
>> > > to
>> > > >>    add necessary params to JVM
>> > > >>    3. Make sure that examples can be compiled and run with Java
11
>> > > >>    4. Make Ignite buildable with Java 11
>> > > >>
>> > > >> Points 1-3 are quick. Dmitriy are you the one who is looking into
>> it?
>> > > When
>> > > >> can we release Ignite 2.8. We should do this as soon as possible.
>> > > >>
>> > > >> -
>> > > >> Denis
>> > > >>
>> > > >>
>> > > >> On Wed, Jan 30, 2019 at 12:04 PM Dmitriy Pavlov <
>> dpavlov@apache.org>
>> > > >> wrote:
>> > > >>
>> > > >> > The only way to run examples without annoying parameters
setup
>> is to
>> > > use
>> > > >> > IntelliJ Idea templates. I guess other IDEs have a similar
>> feature.
>> > > >> >
>> > > >> > I've described it here
>> > > >> >
>> > > >> >
>> > > >>
>> > >
>> >
>> https://github.com/apache/ignite/tree/ignite-11140/examples#running-examples-on-jdk-91011
>> > > >> >
>> > > >> >
>> > > >> > If anyone knows how to declare such defaults using maven
on
>> IntelliJ
>> > > >> > settings, please share.
>> > > >> >
>> > > >> > ср, 30 янв. 2019 г. в 14:56, Dmitriy Pavlov <dpavlov@apache.org
>> >:
>> > > >> >
>> > > >> > > I've checked examples from our nightly build from TC.
Pom
>> itself
>> > was
>> > > >> > > detected normally, I use IntelliJ Idea Ultimate Edition
2018.2.
>> > > >> > >
>> > > >> > > But it can't compile both for Java 8 and for Java 11.
>> > > >> > >
>> > > >> > > I created https://issues.apache.org/jira/browse/IGNITE-11140
>> so I
>> > > >> will
>> > > >> > > come back with fix proposals later.
>> > > >> > >
>> > > >> > > вт, 29 янв. 2019 г. в 18:04, Dmitriy Pavlov <
>> dpavlov@apache.org>:
>> > > >> > >
>> > > >> > >> Hi Denis,
>> > > >> > >>
>> > > >> > >> I'm not sure that pom detection is related to Java
version or
>> to
>> > > >> Ignite.
>> > > >> > >> I will check examples.
>> > > >> > >>
>> > > >> > >> I've checked Apache Ignite TC Bot can be successfully
launched
>> > > using
>> > > >> > >> instructions in
>> > > >> > >>
>> > > >> >
>> > > >>
>> > >
>> >
>> https://apacheignite.readme.io/docs/getting-started#section-running-ignite-with-java-9-10-11
>> > > >> > >> using OpenJDK 10.0.2 on Windows 10. The only issue
was with
>> JAXB
>> > > >> > >> dependencies, but it is definitely not related to
Apache
>> Ignite.
>> > > >> > >>
>> > > >> > >> BTW, thank you for the banner.
>> > > >> > >>
>> > > >> > >> Sincerely,
>> > > >> > >> Dmitriy Pavlov
>> > > >> > >>
>> > > >> > >> пн, 28 янв. 2019 г. в 23:30, Denis Magda
<dmagda@apache.org>:
>> > > >> > >>
>> > > >> > >>> Igniters,
>> > > >> > >>>
>> > > >> > >>> I played with the latest Oracle JDK 11 on Mac
OS Mojave.
>> Results
>> > > are
>> > > >> > sad:
>> > > >> > >>>
>> > > >> > >>>    - Starting a node from cmd (ignite.sh) -
FAILED
>> > > >> > >>>    - Opening Ignite examples - BAD EXPERIENCE
>> > > >> > >>>       - pom.xml wasn't detected automatically,
had to select
>> it
>> > > >> > manually
>> > > >> > >>>       - was hard to start the code samples (same
issue as
>> with
>> > > cmd).
>> > > >> > As a
>> > > >> > >>>       committer, I know how to fix it (
>> > > >> > >>>
>> > > >> > >>>
>> > > >> >
>> > > >>
>> > >
>> >
>> https://apacheignite.readme.io/docs/getting-started#section-running-ignite-with-java-9-10-11
>> > > >> > >>> ),
>> > > >> > >>>       but most of the developers have no glue
and will give
>> up
>> > > >> > >>>       - The step above have to be repeated for
every single
>> > sample
>> > > >> > >>>
>> > > >> > >>> We briefly discussed this with some community
managers and
>> our
>> > > >> fellows
>> > > >> > >>> will
>> > > >> > >>> share the fix plan here.
>> > > >> > >>>
>> > > >> > >>> In the meantime
>> > > >> > >>>
>> > > >> > >>>    - Artem agreed to help on the docs side:
>> > > >> > >>>    https://issues.apache.org/jira/browse/IGNITE-11113
>> > > >> > >>>    - I've added "How to Use Ignite on JDK 9,
10, 11" as a top
>> > > >> banner of
>> > > >> > >>>    Ignite website: https://ignite.apache.org/index.html
>> > > >> > >>>
>> > > >> > >>>
>> > > >> > >>> -
>> > > >> > >>> Denis
>> > > >> > >>>
>> > > >> > >>
>> > > >> >
>> > > >>
>> > > >
>> > >
>> >
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message