ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anton Vinogradov ...@apache.org>
Subject Re: Peer review: Victory over Patch Available debt
Date Mon, 18 Mar 2019 08:33:37 GMT
Dmitry,

Phrase "Code modifications can be approved by silence: by lazy consensus
(72h) after Dev.List announcement." looks unacceptable to me.

Please roll back the changes and start the discussion at the private list
and never do such updates in the future without the discussion.

On Fri, Mar 15, 2019 at 8:29 PM Dmitriy Pavlov <dpavlov@apache.org> wrote:

> Hi Igniters,
>
> sorry for the late reply. Because this process time to time causes
> questions, I decided to add a couple of words to our wiki.
>
> I've added topics about peer review to HTC
>
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-PeerReviewandLGTM
>
> Actually, it is (more or less) rules of Apache Beam project, as well as
> Apache Training(incubating), as well as our current process + Apache
> policies.
>
> Sincerely,
> Dmitriy Pavlov
>
>
> чт, 16 авг. 2018 г. в 17:46, Yakov Zhdanov <yzhdanov@apache.org>:
>
> > Dmitry,
> >
> > I like your suggestion very much! And I want everyone to follow. Let's
> see
> > if it helps.
> >
> > Can I ask everyone who has submitted tickets for review to add a comment
> > described by Dmitry to each ticket submitted and see if any additional
> > check is still required and fix remaining issues? I believe this should
> > speed up review process very much.
> >
> > --Yakov
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message