ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitriy Pavlov <dpav...@apache.org>
Subject Re: beforeTestsStarted() was deprecated, what should we use instead?
Date Mon, 18 Feb 2019 14:21:49 GMT
Anton,

Do you have real questions? Seems like you're trying to state your opinion
related to the fix rather than asking a question.

We've discussed it in the thread related to Failure Handler fix, that whole
community is responsible to make things better. Mostly, contributors, who
care (proof of it is contribution). You can't say directly to someone to be
responsible (there is no boss in open source). If Oleg wants to proceed
with fixing, he will.

Please merge PR 6122 <https://github.com/apache/ignite/pull/6122> if you
agree with the new approach. We sometimes use todos with linking to tickets.

Sincerely,
Dmitriy Pavlov

пн, 18 февр. 2019 г. в 17:09, Anton Vinogradov <av@apache.org>:

> Oleg,
>
> You may use TODO if it is really necessary.
> I see no reason to have any todo at JUnit3TestLegacySupport class since
> it's already marked as legacy and should be removed in the future.
> And we should have an issue about this removal.
>
> Why you closed GNITE-10177 "cleanup Junit 3 from the project" since you're
> not finished work?
> Why now we discuss incorrect deprecation instead of making proper fix
> design in advance?
>
> One more question to the committer.
> Dmitriy,
>
> Why incomplete fix was merged to master without any issues responsible for
> finalization?
> Who's now responsible for final Junit3 removal?
>
> On Mon, Feb 18, 2019 at 4:22 PM oignatenko <oignatenko@gridgain.com>
> wrote:
>
> > Hi Anton,
> >
> > I removed @deprecated from javadoc, thanks for noticing. PR #6122 [1] is
> > updated.
> >
> > As for TODOs, I think you are wrong here because Ignite coding guidelines
> > [2] not only explicitly allow these but also explain the format in which
> > these should be presented. If you find violations of recommended TODOs
> > format, please let me know.
> >
> > regards, Oleg
> >
> > [1]: https://github.com/apache/ignite/pull/6122
> > [2]:
> >
> >
> https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-TODOs
> >
> >
> >
> > --
> > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message