ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Павлухин Иван <vololo...@gmail.com>
Subject Re: Is it time to move forward to JUnit4 (5)?
Date Wed, 23 Jan 2019 08:32:48 GMT
Cheers!

вт, 22 янв. 2019 г. в 20:19, oignatenko <oignatenko@gridgain.com>:
>
> ...sort of a follow-up. I gave folks a bit more leeway than originally
> planned week or two.
>
> It's been about a month since master was changed in a way that wouldn't
> allow JUnit 3 tests execute anymore (per IGNITE-10177) and I just started
> progress on IGNITE-10629 and made a promised inspection for tests that could
> slip through without required annotation while we were migrating the project
> to JUnit 4.
>
> Results of this check look pretty good, IDEA reported only 6 (six)
> troublesome test cases (4 of which were by the way annotated @Ignore,
> meaning that even with added @Test these won't run anyway). Compared to over
> 11,600 properly annotated test cases this looks really minor. We probably
> can say that tests in master migrated to JUnit 4 quite smoothly.
>
>  regards, Oleg
>
>
> Vladimir Ozerov wrote
> > Hi Oleg,
> >
> > Yes, makes perfect sense. Thank you.
> >
> > On Mon, Dec 10, 2018 at 10:14 PM oignatenko &lt;
>
> > oignatenko@
>
> > &gt; wrote:
> >
> >> Hi Vovan,
> >>
> >> I just created JIRA ticket to address your concerns:
> >> - https://issues.apache.org/jira/browse/IGNITE-10629
> >>
> >> In brief, the plan is that a week or two after migration is over we will
> >> run
> >> code inspection that detects JUnit 3 style tests that lack @Test
> >> annotation
> >> and fix these tests if there are any.
> >>
> >> Does that answer your question?
> >>
> >> regards, Oleg
> >> Vladimir Ozerov wrote
> >> > Ed,
> >> >
> >> > Several questions from my side:
> >> > 1) When the change is expected to be merged?
> >> > 2) What contributors with opened PRs and new or updated JUnit3 tests
> >> are
> >> > supposed to do? Rewrite to JUnit4?
> >> >
> >> > If yes, then we should give them time to have a chance to get used to
> >> new
> >> > approach and resolve possible conflicts.
> >> >
> >> > Vladimir.
> >> >
> >> [cut]
> >>
> >> --
> >> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> >>
>
>
>
>
>
> --
> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/



-- 
Best regards,
Ivan Pavlukhin

Mime
View raw message