ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Kasnacheev <ilya.kasnach...@gmail.com>
Subject Re: Let's force -Dfile.encoding=UTF-8
Date Thu, 10 Jan 2019 13:57:36 GMT
Hello!

I've merged this to master. Now we should to try run nodes in UTF-8 mode
unless specified otherwise explicitly.

Also added a warning on start-up if other encoding is used as it might lead
to data corruption.

Regards,
-- 
Ilya Kasnacheev


ср, 26 дек. 2018 г. в 19:25, Dmitriy Pavlov <dpavlov@apache.org>:

> +1 from my side. I think it is reasonable
>
> ср, 26 дек. 2018 г. в 19:20, Ilya Kasnacheev <ilya.kasnacheev@gmail.com>:
>
> > Hello!
> >
> > It was recently discovered that there's some issue in H2 which leads to
> > differing string encodings when they come into reducer from nodes with
> > different system encoding. Even if we were able to fix this, I suspect
> that
> > user code may too be bitten by mismatch of this setting.
> >
> > I propose to force UTF-8 as system encoding at all times when we control
> > how JVM is launched.
> > This includes ignite.sh, ignite.bat, Apache.Ignite.exe and C++'s
> ./ignite.
> >
> > This will mainly affect Windows systems as I expect that Linux will most
> > always use UTF-8 locale and Mac OS X should always be UTF-8.
> >
> > file.encoding is somewhat misleading name since it specifies the default
> > string encoding, such as the one used for String.getBytes(). It is a
> common
> > convention to set ut to UTF-8, for example, IDEA will do that.
> >
> > WDYT?
> >
> > There's a pull request: https://github.com/apache/ignite/pull/5725
> > If somebody could contribute C++ and .Net tests I would be also grateful.
> >
> > Regards,
> > --
> > Ilya Kasnacheev
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message