From dev-return-43262-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Mon Dec 10 18:32:50 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id CDBE4180627 for ; Mon, 10 Dec 2018 18:32:49 +0100 (CET) Received: (qmail 37802 invoked by uid 500); 10 Dec 2018 17:32:48 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 37790 invoked by uid 99); 10 Dec 2018 17:32:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Dec 2018 17:32:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id DB015C2260 for ; Mon, 10 Dec 2018 17:32:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.111 X-Spam-Level: *** X-Spam-Status: No, score=3.111 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URI_HEX=1.313] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id yOMIXF93hd5U for ; Mon, 10 Dec 2018 17:32:45 +0000 (UTC) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id BBCB76110F for ; Mon, 10 Dec 2018 17:32:45 +0000 (UTC) Received: by mail-io1-f48.google.com with SMTP id t24so9461956ioi.0 for ; Mon, 10 Dec 2018 09:32:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=VXUwJW4N8xcZWFzOTKD4cBTToeHiUf0t3R+r+PYOVck=; b=r+UCobHnDwFPN/EeN1xo0HT/qauFuI9pwDqprwhNI6PizJh06OxYqZhL8xzGOEWFEW ja63wmZcF+nz3b+PRT8UsvsrURUEOIq6ZvKG8QoCyeNog4Ghi/RKeSr+giGM/a+mkJPJ hhhqZf4KBMcE4zGwA87+UxjXc18oD90zSA+7DzyIT0LM8eIs6v0yvVtV6F06PvGwlbQS NwQlCvu0sXlC/EJMSKZxo7rKHS/D4B8uiMUKH3LP6DseGCTsSYo4UV6Bgd4vMejJPKWP +3Alz+a9Flrg3UUUzz9/TcLYtxqavNHe0biHnSXn/vqdOK581gvLw2gqZFbNiRYzfKLw rxyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=VXUwJW4N8xcZWFzOTKD4cBTToeHiUf0t3R+r+PYOVck=; b=JV8Bv3LzAxsAhjoPO05paK3RbFUQVPxOLjZs8lkpFA2MaT4w0MkAsadKrg6HBuXhq8 AdtCnyXyng3vu6NrojZB7WGp3j4wM2NnylhREZeU/zig0HedK1Gkg6cXt74CWzNFlRtv fCBSWOxLSVZXGJ0vAJv7Nq9qL0R3i0kNPSggEL5E4bpgUJZBxYLzixnLEvGTjOmlWvNb Bmi4C3b0j2wQqHsIDsJQdMh62fht8INwD3rnOYnfbWPyGF2bL9JJ7daEKAAj8CaQC0KA AFz1zYmY07ENHloI/U98IKtpC0L0bPdKQ4MRzLHQxhDW/qjyJ0QPK8SF8q+L8gQS+TPJ zclw== X-Gm-Message-State: AA+aEWa8/3z4wl37DZiPmDuLJKBXLgQmMlhsyWVLUmPzIztn1ktL7wYY GrpuVy66ZjTy5rW8q9kksLKuFtDdSABQfad1h95Ka3Lg X-Google-Smtp-Source: AFSGD/XHf4cLZ1/Y0WWpHqRUeWx3nGLEz3E1RDA3HInyiT72fGOetwdXkUQn2F9EEi7stT/s78O6d8MS+vVKyoL/Mvg= X-Received: by 2002:a6b:3bc8:: with SMTP id i191mr11010836ioa.23.1544463165033; Mon, 10 Dec 2018 09:32:45 -0800 (PST) MIME-Version: 1.0 References: <1541609865653-0.post@n4.nabble.com> <1541771333836-0.post@n4.nabble.com> <1542041892907-0.post@n4.nabble.com> In-Reply-To: From: Eduard Shangareev Date: Mon, 10 Dec 2018 20:32:33 +0300 Message-ID: Subject: Re: Is it time to move forward to JUnit4 (5)? To: dev@ignite.apache.org Content-Type: multipart/alternative; boundary="0000000000005212e3057cae5a43" --0000000000005212e3057cae5a43 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ivan, So, suggested actions with the new approach: 1. Add @Test annotation on test methods. 2. Add @RunWith(JUnit4.class) annotation on test class. 3. Add @Before, @After on methods which should run before, after a test (setUp, tearDown in current approach). 4. Add your test-class to a suite using suite.addTest(new JUnit4TestAdapter(YourTestClass.class)); 5. Use @Ignore instead fail(); for muting test. 6. You could start using @Parametrized instead of inheritance. On Mon, Dec 3, 2018 at 1:15 PM =D0=9F=D0=B0=D0=B2=D0=BB=D1=83=D1=85=D0=B8= =D0=BD =D0=98=D0=B2=D0=B0=D0=BD wrote: > Hi Oleg, > > I noticed that GridAbstractTest is now capable to run junit4 tests. > What are the current recommendations for writing new tests? Can we use > junit4 annotation for new tests? > =D0=BF=D0=BD, 12 =D0=BD=D0=BE=D1=8F=D0=B1. 2018 =D0=B3. =D0=B2 19:58, oig= natenko : > > > > Hi Ivan, > > > > I am currently testing approach you used in pull/5354 in the "pilot" > > sub-task with examples tests (IGNITE-10174). > > > > So far it looks more and more like the way to go. The most promising > thing I > > observed is that after I changed classes in our test framework the way > you > > did, execution of (unchanged) examples tests went exactly the same as i= t > was > > before changes. > > > > This indicates that existing tests won't be affected making it indeed l= ow > > risk. > > > > After that I converted examples tests to Junit 4 by adding @RunWith and > > @Test annotations and tried a few, and these looked okay. > > > > Currently I am running full examples test suite and after it is over I > will > > compare results to the reference list I made by running it prior to > > migration. > > > > regards, Oleg > > > > > > > > -- > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ > > > > -- > Best regards, > Ivan Pavlukhin > --0000000000005212e3057cae5a43--