ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Muzafarov (JIRA)" <j...@apache.org>
Subject [jira] [Created] (IGNITE-10748) Remove dead code in TcpCommunicationSpi for the tcp client creation flow
Date Thu, 20 Dec 2018 10:43:00 GMT
Maxim Muzafarov created IGNITE-10748:
----------------------------------------

             Summary: Remove dead code in TcpCommunicationSpi for the tcp client creation
flow
                 Key: IGNITE-10748
                 URL: https://issues.apache.org/jira/browse/IGNITE-10748
             Project: Ignite
          Issue Type: Task
            Reporter: Maxim Muzafarov
            Assignee: Maxim Muzafarov
             Fix For: 2.8


Currently, a batch of changes can be applied over {{TcpCommunicationSpi}} class implementation
due to:

# {{safeTcpHandshake(..)}}
#* {{handshakeConnIdx}} - parameter is always not null
#* {{recovery}} - parameter is always not null
#* {{HandhakeMessage}} - is not used in current flow at all
# {{HandshakeMessage2}}
#* Message size must be defined in the message class as constant
# {{createTcpClient(..)}}
#* Instantiation of {{GridTcpNioCommunicationClient}} must be performed outside the while-loop
# Code-style issues




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message