ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vyacheslav Daradur <daradu...@gmail.com>
Subject Re: Abbreviation code-style requirement.
Date Sat, 15 Dec 2018 09:13:53 GMT
Ivan, thank you!

PR looks good to me in general, but I've noticed a possible typo in
the PR and Wiki:
'lable' -> 'label'

Also, according to the wiki, the following rules should be added:
'topologyVersion' -> 'topVer'
'regularExpression' -> 'regex'

Am I miss something?

On Sat, Dec 15, 2018 at 11:17 AM Павлухин Иван <vololo100@gmail.com> wrote:
>
> Hi Dmitriy, Vyacheslav,
>
> I created a ticket [1] and PR [2] for updating a list of abbreviations
> used by the plugin. The changes in the plugin itself looks trivial.
> But some extra build and publish steps are required (see the ticket).
> Also if I understand it correctly plugin should be build with scala
> support. I will need some time to ensure that I can build it properly.
>
> [1] https://issues.apache.org/jira/browse/IGNITE-10704
> [2] https://github.com/dspavlov/ignite-abbrev-plugin/pull/2
>
> 2018-11-02 21:38 GMT+03:00, Dmitriy Pavlov <dpavlov.spb@gmail.com>:
> > Hi Vyacheslav,
> >
> > I'm sorry I almost gave up with this donation
> >
> > http://apache-ignite-developers.2346864.n4.nabble.com/Re-Place-Ignite-Abbrev-Plugin-to-ASF-Ignite-supplementary-git-repo-tp32745p32764.html
> > because
> > we need someone to sign a software grant agreement, but there were several
> > people who contributed to the plugin.
> >
> > Some of the authors are not active contributors anymore. So I've stuck with
> > finding a way how to donate.
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > пт, 2 нояб. 2018 г. в 21:24, Vyacheslav Daradur <daradurvs@gmail.com>:
> >
> >> I've double checked, we are really able to use IDEA inspection's to
> >> inspect abbreviations by inspection's structure search and replace
> >> templates.
> >> It rather not intuitive and requires complex regex patterns.
> >>
> >> Also, at first sight, it shouldn't be difficult to work with the
> >> project's local properties from the plugin.
> >>
> >> On Fri, Nov 2, 2018 at 2:32 PM Vyacheslav Daradur <daradurvs@gmail.com>
> >> wrote:
> >> >
> >> > I like your idea about auto updates.
> >> >
> >> > In this case, abbr-plugin should be improved to check and download
> >> > updates from external URI or local repo.
> >> > Looks like it could be implemented using Intellij's SDK virtual file
> >> > [1].
> >> >
> >> > But as I can see that abbreviations list update is the very rare case,
> >> > therefore I'm not sure that we really need to do it.
> >> >
> >> > Also, I have another idea we can try to use IDEA inspections and it's
> >> > naming conventions rules.
> >> > IDEA inspections are under the project's git already.
> >> >
> >> > [1]
> >> https://www.jetbrains.org/intellij/sdk/docs/basics/architectural_overview/virtual_file.html
> >> > On Fri, Nov 2, 2018 at 1:47 PM Yakov Zhdanov <yzhdanov@apache.org>
> >> wrote:
> >> > >
> >> > > No, I meant under Ignite's git so any change to resource file arrives
> >> with
> >> > > project workspace updates and gets automatically picked up by plugin.
> >> > >
> >> > > Makes sense?
> >> > >
> >> > > --Yakov
> >> >
> >> >
> >> >
> >> > --
> >> > Best Regards, Vyacheslav D.
> >>
> >>
> >>
> >> --
> >> Best Regards, Vyacheslav D.
> >>
> >
>
>
> --
> Best regards,
> Ivan Pavlukhin



-- 
Best Regards, Vyacheslav D.

Mime
View raw message