From dev-return-41821-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Thu Nov 15 15:06:58 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 20FE6180669 for ; Thu, 15 Nov 2018 15:06:57 +0100 (CET) Received: (qmail 98765 invoked by uid 500); 15 Nov 2018 14:06:57 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 98753 invoked by uid 99); 15 Nov 2018 14:06:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Nov 2018 14:06:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 06E50C0586 for ; Thu, 15 Nov 2018 14:06:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.34 X-Spam-Level: X-Spam-Status: No, score=0.34 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-1.459, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 3KK31eNAYmrj for ; Thu, 15 Nov 2018 14:06:54 +0000 (UTC) Received: from mail-it1-f170.google.com (mail-it1-f170.google.com [209.85.166.170]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 9B97660E30 for ; Thu, 15 Nov 2018 14:06:54 +0000 (UTC) Received: by mail-it1-f170.google.com with SMTP id m15so29355606itl.4 for ; Thu, 15 Nov 2018 06:06:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=RUTqMwzEjVFX+EpAoa4rO1ptoDDsH0q3j/d7UWgJEu4=; b=aURZTwGtOTuQFG5i9lXhtVi9/DUswz3MedM+Ot4oqUGacaeEgRlW673WvCPUQiiUBd Mo1fJnUaL1ItMR+QWvkDT/+c5F2YKrhDTzmLh06q3mZ61J4pje7nXmB2KTVPkrm9IeBR byXg5HICziMKQn/Tvve6AX2UDPCuC+/tjIQET6sX/Yf9Ww0bXcPFfcVkWKWOVOoMHX42 SSkDtezN0SAO6jDWnFlK80/9LWusITwp4IZzjCOKJnX4TgZMEbZB/eMh4ye7io0GVVvd pHsPuYhkcYBIdjv5oeTFq4W7pxtZoiuDEO5tjn9gM46ku0MNi7LLOKfCdo0BlbyqA5A9 anuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=RUTqMwzEjVFX+EpAoa4rO1ptoDDsH0q3j/d7UWgJEu4=; b=P7ny7N20OF9W9eE6S+2TEXa6L8ega88JW0F2PH5RpAdiTnE3M213Ky/LRKijzWVni2 DgCefJSzdqO0KrK8dx9sEI1zQn0T9xlk6f9WIAxGbyL+1ZUvpZRjkq5+vno7Q9HvtMCp +rUoVsv8NieKmBtGAnG3rBzcsT4ltHyzke9mEFlIMgrLHZ2mOwoyWrRGTS+JXybTQcqI gI38DD6hhweHypupklIQi5v+ZQEX9M2LM/Uw07ZoGUaDTTakKpAaiOcFnxjPUuuhH/EJ G/8/VMJ5nhgXuTmbiBQZDplQgNWWeH+tBVElYaxniGFyfDetHTnpJGoiStFCjzONtitZ DyDQ== X-Gm-Message-State: AGRZ1gJ451wScTbXICnmqnVlu0PcOXjDxVXIqE5/ZVlgnMPi9ExHvrSL wkwMsdMWjYG9cGeaYNDuVOFUjrYIeUSa/xqFzcEQ3/nexLg= X-Google-Smtp-Source: AJdET5dHopgfPQ/VamrjEdhWIh5/5nNcM5zKNhiUTlu9XvHqS2Wb423QZbOsEYyHnNFDlKJ5JtvDElPtKRvJlz8NfOg= X-Received: by 2002:a24:e38f:: with SMTP id d137mr5625350ith.69.1542290813726; Thu, 15 Nov 2018 06:06:53 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Denis Mekhanikov Date: Thu, 15 Nov 2018 17:06:40 +0300 Message-ID: Subject: Re: Brainstorm: Make TC Run All faster To: dev@ignite.apache.org Content-Type: multipart/alternative; boundary="00000000000017b535057ab49027" --00000000000017b535057ab49027 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Dmitry, Sergey, There is a common pattern in the test codebase, when each test starts its own set of nodes, and closes them after the test finishes. Node startup takes quite a lot of time, and this time could be reduced, if tests shared the same set of nodes. I mean, if there is a test class with a lot of methods, then in many cases it's enough to start nodes in *beforeTestsStarted* and stop them in *afterTestsStopped* instead of doing it in every test case= . We should encourage contributors to use this pattern. It's not applicable for all tests, and would violate isolation of tests, but I think, it's a good trade-off, because the running time of tests is a real problem. Denis =D1=87=D1=82, 15 =D0=BD=D0=BE=D1=8F=D0=B1. 2018 =D0=B3. =D0=B2 15:11, Serge= y Chugunov : > Dmitriy, > > You brought up really important topic that has a great impact on our > project. Faster runAlls mean quicker feedback and faster progress on issu= es > and features. > > We have a pretty big code base of tests, about 50 thousands tests. Do we > have an idea of how these tests overlap with each other? In my mind it is > possible that we have a good bunch of tests that cover the same code and > could be replaced with just a single test. > > In the ideal world we would even determine the minimal set of tests to > cover our codebase and remove excessive. > > -- > Best regards, > Sergey Chugunov. > > On Thu, Nov 15, 2018 at 2:34 PM Dmitriy Pavlov wrote= : > > > Hi Igniters, > > > > > > > > Some of us started to use the Bot to get an approval of PRs. It helps t= o > > protect master from new failures, but this requires to run RunAll tests > set > > for each commit and this makes markable pressure to TC infra. > > > > > > > > I would like to ask you to share your ideas on how to make runAll faste= r, > > maybe you can share any of your measurements and any other info about > > (possible) bottlenecks. > > > > > > > > Sincerely, > > > > Dmitriy Pavlov > > > --00000000000017b535057ab49027--