From dev-return-42505-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Tue Nov 27 15:23:51 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 552EB180670 for ; Tue, 27 Nov 2018 15:23:50 +0100 (CET) Received: (qmail 73068 invoked by uid 500); 27 Nov 2018 14:23:49 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 73031 invoked by uid 99); 27 Nov 2018 14:23:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Nov 2018 14:23:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 4752FC2326 for ; Tue, 27 Nov 2018 14:23:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.202 X-Spam-Level: X-Spam-Status: No, score=-0.202 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Gsxek1GKfHSK for ; Tue, 27 Nov 2018 14:23:44 +0000 (UTC) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 37E1B60FB7 for ; Tue, 27 Nov 2018 14:16:18 +0000 (UTC) Received: by mail-pl1-f178.google.com with SMTP id k8so5032666pls.11 for ; Tue, 27 Nov 2018 06:16:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=eAFz46+WQZkRFYhZoGdIq9K819i0AeTvtosGoHghdEE=; b=UTHXdaKHaZQaYw8F5y/CQI9ks4dD3rlt+BJgzAvdlo6gPgyEJKVgsiXKFO9Wj4lH98 abzlIFSMKniucyDpV/0NK3UK8GgmEZkoQCEzRpNNOQkwPYK6DNZD21pK5NqGPNRo/5dE K6c1FvvUJK+Ug3X1GdTpTANdQX9OvyK/2L8HLxvwlaejGLA+NcFytW7moWvcvtSVtw1x GxgJfoq+OBC5gaE5UCYLanoSPL45aUC6GtxVKy7Xv4ucGj62iUoMKwR5Ro90/4t/K9tK AeghnIPjxEfvkjtKrIl1aSYuHPOybnT1lY86cWNbfahJVksqaDikfHRDa+aAxUPFIk1M YR+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=eAFz46+WQZkRFYhZoGdIq9K819i0AeTvtosGoHghdEE=; b=aYl8lh/9xHhQsrQp4CAcnCXiPThY12wv0NlTSTGAqGnn3JHMV/vtqz/U/whqzWIT8j fO6XaoWZ/u2fMSeaGg61+RqdliipvLrF6KWMWQSrih3XOyidvWPYA/SW5A82v+L42CBT W7ig++mqkEeQ8HZTjq9q8ihg0DrLF/bQyu6nBszFBAzMmfTdtIVwYvMvmr486/fz+qBd 3Gx16GBGUta+2ndjSJJIG6hCWVhjy9KsfkRx/BDb3XVM7dEWyD0Ik3bzg+oZ5xYOmMtN lghox0kDLJvwzhrlNkxJATaSdoS1N6peoueD4juz7tpBWbOpS2v7AjKkqH/JOkIOK3Cu X8yw== X-Gm-Message-State: AA+aEWbigDiiV2wNyEIuYQ6vJ3kHGfF4QYbppafB543KcX3C1tLET24N TvRuEEpaMWBRUGQwh+K4Vi3FBjjxGz18yUAbJ/bXH7ATxlVzDQ== X-Google-Smtp-Source: AFSGD/XDu/byTPYhgxBPvgh7B5zo5UskYW50/ZNTw1pMthbR43HLHKmyHlYk5Ie0+k+cW9E76mf2O2nRMfdbz9RIG1o= X-Received: by 2002:a17:902:27a8:: with SMTP id d37mr2718429plb.182.1543328176823; Tue, 27 Nov 2018 06:16:16 -0800 (PST) MIME-Version: 1.0 References: <021b64eb10c373d3d9d64733e64fe2364fd0a5ac.camel@gmail.com> In-Reply-To: From: Vyacheslav Daradur Date: Tue, 27 Nov 2018 17:16:03 +0300 Message-ID: Subject: Re: Service grid redesign To: dev@ignite.apache.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable We had the private talk with Nikolay Izhikov, Vladimir Ozerov, Alexey Goncharuk, Yakov Zhdanov, Denis Mekhanikov, Dmitriy Pavlov and I would like to share the summary with the community: The architecture of the implemented deployment process looks good in general, but the following points should be improved: * The new implementation of service processor implementation should be moved to a new class; * A new system property should be introduced to allow users to switch to old implementation in case of errors; * Introduced service deployment failures policy should be removed from current PR and should be implemented as a different task with detailed discussion on dev list to avoid unexpected behavior; * The word "exchange" should be removed from classes names to avoid confusion with PME classes. * Single/full messages should include containing only deployment process-related information only (instead of all service) to reduce messages size; Thanks all! I'll let you know once I fix the notes. On Wed, Nov 21, 2018 at 4:28 PM Dmitriy Pavlov wrote: > > Hi Vyacheslav, Vladimir, > > Could you please invite me, if you will set up a call. > > =D1=81=D1=80, 21 =D0=BD=D0=BE=D1=8F=D0=B1. 2018 =D0=B3. =D0=B2 13:08, Vla= dimir Ozerov : > > > Hi Vyacheslav, > > > > Still not clear enough for me. I do not see a reason to send another ov= er a > > ring in case of successful execution. The only reason is an error on a = node > > which require correction (re-deploy to other node, full service undeplo= y, > > etc). > > I think it makes sense to organize another call to discuss current > > architecture. Otherwise we may spend too much time on emails. > > > > Vladimir. > > > > On Wed, Nov 21, 2018 at 12:57 PM Vyacheslav Daradur > > wrote: > > > > > The full map is needed: > > > 1) to propagate deployment results which could be different from > > > locally calculated in case of any errors; > > > 2) to transfer deployment errors across the cluster; > > > 3) to undeploy exceeded the number of service instances if needed; > > > 4) to get know other nodes that deployment process was finished, this > > > need to avoid calling services which have not been deployed yet (or > > > can't be deployed). We can't just store pending requests because of > > > time to deploy one service instances which may be significant. > > > On Wed, Nov 21, 2018 at 12:45 PM Vladimir Ozerov > > > wrote: > > > > > > > > Vyacheslav, > > > > > > > > I looked at the document and failed to find explanation why full ma= ps > > are > > > > needed. Could you point me to a place where it is explained? > > > > I ask this because my impression from last discussion was that it i= s > > > never > > > > needed. Service status change is initiated by user action, then all > > nodes > > > > perform respective action locally, then they reply to coordinator, = then > > > > coordinator reply to the client, no need a kind of "full" map over > > > > discovery again. The only situation when another message over ring = is > > > > required, is when some node failed to execute local operation (for > > > whatever > > > > reason) and corrective action is required. > > > > > > > > Am I missing something? > > > > > > > > On Wed, Nov 21, 2018 at 11:50 AM Vyacheslav Daradur < > > daradurvs@gmail.com > > > > > > > > wrote: > > > > > > > > > Denis, I suggested new names above in the thread. > > > > > > > > > > Please, look at PME document [1] is should be quiet actual to sho= w > > the > > > > > same flow. > > > > > > > > > > [1] > > > > > > > > > > https://cwiki.apache.org/confluence/display/IGNITE/%28Partition+Map%29+= Exchange+-+under+the+hood > > > > > > > > > > On Wed, Nov 21, 2018 at 11:43 AM Denis Mekhanikov < > > > dmekhanikov@gmail.com> > > > > > wrote: > > > > > > > > > > > > Vyacheslav, > > > > > > > > > > > > Actually, the service assignment is implemented in a way, > > > > > > that allows every node calculate the assignment itself, so no > > > information > > > > > > needs to be shared. > > > > > > The only data, that is sent between nodes is deployment results= , > > > > > > and I don't see an analogy with exchange here. > > > > > > > > > > > > Denis > > > > > > > > > > > > =D1=81=D1=80, 21 =D0=BD=D0=BE=D1=8F=D0=B1. 2018 =D0=B3. =D0=B2 = 11:16, Vladimir Ozerov < > > vozerov@gridgain.com > > > >: > > > > > > > > > > > > > Hi Vyacheslav, > > > > > > > > > > > > > > Could you please explain in what situation coordinator needs = to > > > collect > > > > > > > service deployments info from all nodes and share it with the > > > cluster? > > > > > I > > > > > > > cannot remember from our design discussion when it is needed. > > > Global > > > > > state > > > > > > > normally shared through discovery and only on node join, In t= his > > > case > > > > > we > > > > > > > use "DiscoveryDataBags", not separate messages. > > > > > > > > > > > > > > On Wed, Nov 21, 2018 at 11:11 AM Vyacheslav Daradur < > > > > > daradurvs@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > I think request-response is not suitable terms. > > > > > > > > > > > > > > > > Nodes send to coordinator maps of actual service deployment= s > > > which > > > > > > > > contains what count of instances of each service node hosts > > > locally. > > > > > > > > > > > > > > > > Coordinator sends to the cluster the full map of deployment= s > > > across > > > > > the > > > > > > > > cluster. > > > > > > > > > > > > > > > > On Wed, Nov 21, 2018 at 11:04 AM Vladimir Ozerov < > > > > > vozerov@gridgain.com> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > I do not know what is correct term :-) What I said is tha= t > > > > > "exchange" > > > > > > > is > > > > > > > > > counter intuitive here. There is no "exchange", instead n= odes > > > send > > > > > > > > > information to coordinator that they finished some operat= ion. > > > E.g. > > > > > we > > > > > > > do > > > > > > > > > the same for schema changes (index creation), and as Deni= s > > > > > suggested, > > > > > > > > > Request-Response is correct suffixes here. Message name > > should > > > > > explain > > > > > > > > what > > > > > > > > > really happened, instead of describing things which are > > > somewhat > > > > > > > similar > > > > > > > > in > > > > > > > > > internal flow. > > > > > > > > > > > > > > > > > > On Wed, Nov 21, 2018 at 10:49 AM Nikolay Izhikov < > > > > > nizhikov@apache.org> > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > Hello, Vladimir. > > > > > > > > > > > > > > > > > > > > What is correct term? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > =D1=81=D1=80, 21 =D0=BD=D0=BE=D1=8F=D0=B1. 2018 =D0=B3.= , 10:29 Vladimir Ozerov > > > vozerov@gridgain.com > > > > > : > > > > > > > > > > > > > > > > > > > > > Agree. Service deployment has nothing to do with PME.= We > > > > > should not > > > > > > > > use > > > > > > > > > > the > > > > > > > > > > > same term for different things. > > > > > > > > > > > > > > > > > > > > > > =D0=B2=D1=82, 20 =D0=BD=D0=BE=D1=8F=D0=B1. 2018 =D0= =B3. =D0=B2 17:19, Denis Mekhanikov < > > > > > > > > dmekhanikov@gmail.com>: > > > > > > > > > > > > > > > > > > > > > > > Vyacheslav, > > > > > > > > > > > > > > > > > > > > > > > > I'm in process of reviewing your changes. Sorry for > > > taking so > > > > > > > long. > > > > > > > > > > > > I posted the first portion of review comments > > yesterday. > > > > > > > > > > > > I'd like to finish looking through the code. I'll p= ost > > > more > > > > > > > > comments > > > > > > > > > > > later. > > > > > > > > > > > > > > > > > > > > > > > > I see, that you called things analogously to partit= ion > > > map > > > > > > > > exchange. > > > > > > > > > > > > I realize, that there is an analogy in used procedu= res, > > > but I > > > > > > > don't > > > > > > > > > > > really > > > > > > > > > > > > like the idea to use the same names for everything. > > > > > > > > > > > > The partition map exchange is called this way becau= se > > it > > > > > involves > > > > > > > > an > > > > > > > > > > > actual > > > > > > > > > > > > exchange of information. > > > > > > > > > > > > All nodes need to tell each other, which partitions > > they > > > > > have, > > > > > > > and > > > > > > > > what > > > > > > > > > > > > their states are. > > > > > > > > > > > > > > > > > > > > > > > > There is no exchange in case of service deployment,= so > > I > > > > > would > > > > > > > > skip the > > > > > > > > > > > > "exchange" part. > > > > > > > > > > > > And *single message ->* *full message* look more li= ke > > > > > *request -> > > > > > > > > > > > response* > > > > > > > > > > > > in case of services. > > > > > > > > > > > > > > > > > > > > > > > > Suppose we abandon the PME procedure and move to > > > something > > > > > else. > > > > > > > > > > > > Then *ServiceDeploymentExchange* name won't make se= nse. > > > > > > > > > > > > And I don't want to be in a situation, when I say t= o my > > > > > > > colleague a > > > > > > > > > > word > > > > > > > > > > > > "exchange", > > > > > > > > > > > > and get "which one?" in return. > > > > > > > > > > > > So, I'm for the meaningful names rather than analog= ous > > to > > > > > > > something > > > > > > > > > > else. > > > > > > > > > > > > > > > > > > > > > > > > What do you think? > > > > > > > > > > > > > > > > > > > > > > > > Denis > > > > > > > > > > > > > > > > > > > > > > > > =D0=B2=D1=82, 20 =D0=BD=D0=BE=D1=8F=D0=B1. 2018 =D0= =B3. =D0=B2 12:09, Vyacheslav Daradur < > > > > > > > > daradurvs@gmail.com > > > > > > > > > > >: > > > > > > > > > > > > > > > > > > > > > > > > > Denis, Yakov have you had a chance to review the > > > solution? > > > > > > > > > > > > > > > > > > > > > > > > > > Igniters, we need to define a list of reviewers, > > > otherwise > > > > > no > > > > > > > > end in > > > > > > > > > > > > sign. > > > > > > > > > > > > > > > > > > > > > > > > > > I'm ready to continue work on the Service Grid, > > > including > > > > > new > > > > > > > > > > features > > > > > > > > > > > > > like hot-redeployment and versioning, also, I hav= e > > > ideas > > > > > about > > > > > > > > new > > > > > > > > > > > > > tools for monitoring and management which will be > > > useful > > > > > for > > > > > > > our > > > > > > > > > > > > > end-users. > > > > > > > > > > > > > > > > > > > > > > > > > > But for continuing work we need to overcome this > > first > > > > > phase. > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Nov 13, 2018 at 1:09 PM Vyacheslav Daradu= r < > > > > > > > > > > > daradurvs@gmail.com> > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > Denis, Yakov, feel free to contact me directly = in > > > case of > > > > > > > > > > questions. > > > > > > > > > > > > > Thanks! > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Sun, Nov 11, 2018 at 10:09 PM Denis Mekhanik= ov < > > > > > > > > > > > > dmekhanikov@gmail.com> > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Guys, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I'd like to take a look at the changes before > > they > > > are > > > > > > > > merged. > > > > > > > > > > > > > > > I'll do my best to finish the review before t= he > > > end of > > > > > the > > > > > > > > > > upcoming > > > > > > > > > > > > > week. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks! > > > > > > > > > > > > > > > Denis > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > =D1=81=D0=B1, 10 =D0=BD=D0=BE=D1=8F=D0=B1. 20= 18 =D0=B3. =D0=B2 14:25, Nikolay Izhikov < > > > > > > > > > > nizhikov@apache.org > > > > > > > > > > > >: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hello, Vladimir. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I'm agree with you. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Can we write the list of reviewers for this > > > feature? > > > > > > > > > > > > > > > > Without a date or similar. > > > > > > > > > > > > > > > > Just a list of experts who should review th= is > > > > > feature. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > =D0=92 =D0=A1=D0=B1, 10/11/2018 =D0=B2 14:0= 1 +0300, Vladimir Ozerov > > > > > =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > > > > > > > > > > > > > > > > Igniters, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > This is very huge thing with complex > > algorithms > > > > > behind. > > > > > > > > We > > > > > > > > > > > should > > > > > > > > > > > > > not > > > > > > > > > > > > > > > > merge > > > > > > > > > > > > > > > > > it to the product unless several addition= al > > > > > thorough > > > > > > > > reviews > > > > > > > > > > > are > > > > > > > > > > > > > ready, > > > > > > > > > > > > > > > > > irrespectively of how long will it take. = We > > are > > > > > about > > > > > > > > > > quality, > > > > > > > > > > > > not > > > > > > > > > > > > > speed. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > =D1=81=D0=B1, 10 =D0=BD=D0=BE=D1=8F=D0=B1= . 2018 =D0=B3. =D0=B2 1:30, Denis Magda < > > > > > > > > dmagda@apache.org > > > > > > > > > > >: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Vyacheslav, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > What are the cases when the service can= be > > > > > > > redeployed? > > > > > > > > > > > > Affinity, > > > > > > > > > > > > > > > > failure, > > > > > > > > > > > > > > > > > > etc., right. It would be good to list a= ll > > the > > > > > cases > > > > > > > on > > > > > > > > the > > > > > > > > > > > wiki > > > > > > > > > > > > > and > > > > > > > > > > > > > > > > then > > > > > > > > > > > > > > > > > > our tech writers will get everything > > > documented. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > Denis > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Thu, Nov 8, 2018 at 11:06 PM Vyaches= lav > > > > > Daradur < > > > > > > > > > > > > > > > > daradurvs@gmail.com> > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Denis, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Services reassignment process takes i= nto > > > > > account > > > > > > > > previous > > > > > > > > > > > > > assignments > > > > > > > > > > > > > > > > > > > to avoid redundant redeployments. > > > > > > > > > > > > > > > > > > > So, in the described case, ServiceA w= on't > > > be > > > > > moved > > > > > > > > from > > > > > > > > > > > node1 > > > > > > > > > > > > > to > > > > > > > > > > > > > > > > node2. > > > > > > > > > > > > > > > > > > > On Fri, Nov 9, 2018 at 4:41 AM Denis > > Magda > > > < > > > > > > > > > > > > dmagda@apache.org> > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Vyacheslav, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > First of all, thanks for archiving = this > > > > > milestone > > > > > > > > and > > > > > > > > > > > > > rolling out > > > > > > > > > > > > > > > > these > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > new > > > > > > > > > > > > > > > > > > > > capabilities. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Speaking of the topology change eve= nts > > > [1], > > > > > does > > > > > > > > the > > > > > > > > > > new > > > > > > > > > > > > > > > > architecture > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > avoid > > > > > > > > > > > > > > > > > > > > a running service redeployment when= a > > new > > > > > node > > > > > > > > joins? > > > > > > > > > > For > > > > > > > > > > > > > instance, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > let's > > > > > > > > > > > > > > > > > > > > say I have ServiceA running node1, = then > > > node2 > > > > > > > joins > > > > > > > > > > and I > > > > > > > > > > > > > don't > > > > > > > > > > > > > > > > want > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > the > > > > > > > > > > > > > > > > > > > > service to be redeployed to any oth= er > > > node. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=3D9565= 4584#ServiceGridredesign.Phase1.Implementationdetails.-Topologychange > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > Denis > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Wed, Nov 7, 2018 at 7:04 AM > > Vyacheslav > > > > > > > Daradur < > > > > > > > > > > > > > > > > daradurvs@gmail.com > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Dmitriy, I published documentatio= n in > > > wiki: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=3D9565= 4584 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thank you! > > > > > > > > > > > > > > > > > > > > > On Wed, Nov 7, 2018 at 5:10 PM > > Dmitriy > > > > > Pavlov < > > > > > > > > > > > > > > > > dpavlov.spb@gmail.com > > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hi I think wiki is better than = any > > > > > attached > > > > > > > > docs. > > > > > > > > > > > Could > > > > > > > > > > > > > you > > > > > > > > > > > > > > > > please > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > create a > > > > > > > > > > > > > > > > > > > > > > page? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > =D1=81=D1=80, 7 =D0=BD=D0=BE=D1= =8F=D0=B1. 2018 =D0=B3., 14:39 > > Vyacheslav > > > > > > > Daradur < > > > > > > > > > > > > > > > > daradurvs@gmail.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > : > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I prepared a description of t= he > > > > > implemented > > > > > > > > > > > solution > > > > > > > > > > > > > and > > > > > > > > > > > > > > > > attached > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > it > > > > > > > > > > > > > > > > > > > > > > > to the issue [1]. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > This should help during a rev= iew. > > > > > Should I > > > > > > > > post > > > > > > > > > > the > > > > > > > > > > > > > document > > > > > > > > > > > > > > > > into > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > wiki > > > > > > > > > > > > > > > > > > > > > or > > > > > > > > > > > > > > > > > > > > > > > IEP? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I'd like to ask Ignite's expe= rts > > > > > review the > > > > > > > > > > > solution > > > > > > > > > > > > > [1] [2], > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > please? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > https://issues.apache.org/jira/browse/IGNITE-9607 > > > > > > > > > > > > > > > > > > > > > > > [2] > > > > > > > > https://github.com/apache/ignite/pull/4434 > > > > > > > > > > > > > > > > > > > > > > > On Wed, Oct 31, 2018 at 5:04 = PM > > > > > Vyacheslav > > > > > > > > > > Daradur > > > > > > > > > > > < > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > daradurvs@gmail.com> > > > > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hi, Igniters! Good news! > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Service Grid Redesign Phase= 1 - > > > is in > > > > > > > Patch > > > > > > > > > > > > > Available now. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Nikolay Izhikov has reviewe= d > > > > > > > > implementation. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > However, we need additional > > > review > > > > > from > > > > > > > > other > > > > > > > > > > > > Ignite > > > > > > > > > > > > > > > > experts. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Here is an umbrella ticket = [1] > > > and PR > > > > > > > [2]. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Could someone step in and d= o > > the > > > > > review? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > https://issues.apache.org/jira/browse/IGNITE-9607 > > > > > > > > > > > > > > > > > > > > > > > > [2] > > > > > > > > https://github.com/apache/ignite/pull/4434 > > > > > > > > > > > > > > > > > > > > > > > > On Sat, Aug 18, 2018 at 11:= 44 > > AM > > > > > Denis > > > > > > > > > > > Mekhanikov < > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > dmekhanikov@gmail.com> > > > > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Pavel, could you assist? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Does it make sense for .N= et > > to > > > > > specify > > > > > > > > > > service > > > > > > > > > > > > > class name > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > instead > > > > > > > > > > > > > > > > > > > > > of > > > > > > > > > > > > > > > > > > > > > > > its > > > > > > > > > > > > > > > > > > > > > > > > > implementation? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I think, it shouldn't be = a > > > problem. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Denis > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Sat, Aug 18, 2018, 11:= 33 > > > > > Vyacheslav > > > > > > > > > > Daradur > > > > > > > > > > > < > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > daradurvs@gmail.com> > > > > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I think that the > > replacement > > > of > > > > > > > > serialized > > > > > > > > > > > > > instance > > > > > > > > > > > > > > > > makes > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > sense > > > > > > > > > > > > > > > > > > > > > to me > > > > > > > > > > > > > > > > > > > > > > > > > > for Java part. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > But how it should work = for > > > .NET > > > > > > > client? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Aug 14, 2018 at > > 4:07 > > > PM > > > > > > > Dmitriy > > > > > > > > > > > > > Setrakyan < > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > dsetrakyan@apache.org> > > > > > > > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Aug 14, 2018 = at > > > 6:10 > > > > > AM, > > > > > > > > Nikita > > > > > > > > > > > > > Amelchev < > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > nsamelchev@gmail.com> > > > > > > > > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hello, Igniters. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I am working on tas= k > > [1] > > > that > > > > > > > would > > > > > > > > > > > replace > > > > > > > > > > > > > > > > serialized > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > service's > > > > > > > > > > > > > > > > > > > > > > > > > > instance > > > > > > > > > > > > > > > > > > > > > > > > > > > > by service's class = name > > > and > > > > > > > > properties > > > > > > > > > > > map > > > > > > > > > > > > in > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > {ServiceConfiguration}. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > The task describes = that > > > we > > > > > should > > > > > > > > use > > > > > > > > > > > > > > > > > > > > > > > > > > > > {String className} = + > > > > > {Map > > > > > > > > > Object> > > > > > > > > > > > > > > > > properties} > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > instead > > > > > > > > > > > > > > > > > > > > > > > {Service > > > > > > > > > > > > > > > > > > > > > > > > > > > > srvc}. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I'd like to clarify= the > > > > > following > > > > > > > > > > > > questions: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 1. What about publi= c > > > methods? > > > > > > > > > > > > > > > > > > > > > > > > > > > > I suggest to mark t= hem > > as > > > > > > > > deprecated > > > > > > > > > > and > > > > > > > > > > > > use > > > > > > > > > > > > > class > > > > > > > > > > > > > > > > name > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > of > > > > > > > > > > > > > > > > > > > > > > > provided > > > > > > > > > > > > > > > > > > > > > > > > > > > > instance. > > > > > > > > > > > > > > > > > > > > > > > > > > > > Also to add deployi= ng > > > methods > > > > > > > with > > > > > > > > new > > > > > > > > > > > > > parameters: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > @Deprecated > > > > > > > > > > > > > > > > > > > > > > > > > > > > public > > > > > IgniteInternalFuture > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > deployNodeSingleton(ClusterGroup > > > > > > > > > > > > > > > > > > > > > > > prj, > > > > > > > > > > > > > > > > > > > > > > > > > > > > String > > > > > > > > > > > > > > > > > > > > > > > > > > > > name, Service svc) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > public > > > > > IgniteInternalFuture > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > deployNodeSingleton(ClusterGroup > > > > > > > > > > > > > > > > > > > > > > > prj, > > > > > > > > > > > > > > > > > > > > > > > > > > > > String > > > > > > > > > > > > > > > > > > > > > > > > > > > > name, String > > srvcClsName, > > > > > > > > Map > > > > > > > > > > > > Object> prop) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I think this makes se= nse, > > > but I > > > > > > > would > > > > > > > > > > like > > > > > > > > > > > > > other > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > committers to > > > > > > > > > > > > > > > > > > > > > > > confirm. > > > > > > > > > > > > > > > > > > > > > > > > > > > Perhaps Vladimir Ozer= ov > > > should > > > > > > > > comment > > > > > > > > > > > here. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 2. Is {Map > > Object> > > > > > > > > properties} > > > > > > > > > > > > > parameter > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > mandatory > > > > > > > > > > > > > > > > > > > > > when > > > > > > > > > > > > > > > > > > > > > > > > > > deploying a > > > > > > > > > > > > > > > > > > > > > > > > > > > > service? > > > > > > > > > > > > > > > > > > > > > > > > > > > > Is it make sense to= add > > > > > deploying > > > > > > > > > > methods > > > > > > > > > > > > > without > > > > > > > > > > > > > > > > it? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > For > > > > > > > > > > > > > > > > > > > > > > > example: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > public > > > > > IgniteInternalFuture > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > deployNodeSingleton(ClusterGroup > > > > > > > > > > > > > > > > > > > > > > > prj, > > > > > > > > > > > > > > > > > > > > > > > > > > > > String > > > > > > > > > > > > > > > > > > > > > > > > > > > > name, String > > srvcClsName) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > public > > > > > IgniteInternalFuture > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > deployNodeSingleton(ClusterGroup > > > > > > > > > > > > > > > > > > > > > > > prj, > > > > > > > > > > > > > > > > > > > > > > > > > > > > String > > > > > > > > > > > > > > > > > > > > > > > > > > > > name, String > > srvcClsName, > > > > > > > > Map > > > > > > > > > > > > Object> prop) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I would always ask th= e > > > user to > > > > > pass > > > > > > > > the > > > > > > > > > > > > > property > > > > > > > > > > > > > > > > map, but > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > would > > > > > > > > > > > > > > > > > > > > > > > allow it > > > > > > > > > > > > > > > > > > > > > > > > > > to > > > > > > > > > > > > > > > > > > > > > > > > > > > be null. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > D. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > > > > > > > Best Regards, Vyachesla= v D. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > > > > > Best Regards, Vyacheslav D. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > > > > Best Regards, Vyacheslav D. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > > Best Regards, Vyacheslav D. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > Best Regards, Vyacheslav D. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > Best Regards, Vyacheslav D. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > Best Regards, Vyacheslav D. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > Best Regards, Vyacheslav D. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Best Regards, Vyacheslav D. > > > > > > > > > > > > > > > > > -- > > > Best Regards, Vyacheslav D. > > > > > --=20 Best Regards, Vyacheslav D.