From dev-return-41630-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Sun Nov 11 15:55:53 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6E3C6180645 for ; Sun, 11 Nov 2018 15:55:53 +0100 (CET) Received: (qmail 19892 invoked by uid 500); 11 Nov 2018 14:55:52 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 19880 invoked by uid 99); 11 Nov 2018 14:55:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Nov 2018 14:55:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 74D77CB130 for ; Sun, 11 Nov 2018 14:55:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.661 X-Spam-Level: X-Spam-Status: No, score=-1.661 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-1.459, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id C7cz157ue2eq for ; Sun, 11 Nov 2018 14:55:50 +0000 (UTC) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 06FDF6125D for ; Sun, 11 Nov 2018 14:55:50 +0000 (UTC) Received: by mail-lj1-f175.google.com with SMTP id t22-v6so5389867lji.7 for ; Sun, 11 Nov 2018 06:55:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=wcdXwM0KOC9KssZA5hRAWk9nZGjAqcBSl2dYN+1XT6E=; b=gpXgaRukKXuRmABY+FIx230tlWsKDcs7Ag9dmBRSJDzbcs2M1SjHv3XHkfW8GOOzeK TiZCG8aUq7tb4BDiV25ak1ul23oAmz7rxc4L65f5uEwe6Iw8BDWXpHkb3lj3gXgnj+Wz GMHKVLQBfoq3iyU89uh+Ncyv5O/K2wu+ElePjQOFnpLiUZJJNwwBO6EEKONEzvZPu/Ns ISduTnxliCy3vhWLFmTKZQvcwwxq6/h2AVxMDpQ48HFYsHDOK9NJF+1F8DguheIef5jc rYvXZM0TY++WkN+3gWVTU9dvfWx/Qh/mT9xxN5fN2Lssv0QBSwGB2WGyn/IDSiMkCpfb VUPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=wcdXwM0KOC9KssZA5hRAWk9nZGjAqcBSl2dYN+1XT6E=; b=ktxzwbikJf0t0/bs5WwX6EKk2U2ElexNmLuVRHDqPCOqYS5GK3/PLIDXzvzjhTIWKV J8azoa+kRfZgOHqNklBSikr2ahiQq6Ah6gaF/X6s4JAJD2dXERRMG3ScLTWULsurma6P JNHYj1ockvwJiDu04JzCrujNY0MADdijUPRkugwZvp8oJ6+qK1Iea0359LTyNBZlSe08 ixvuQo6GezuTm+wvAauUHT6MloU5YVIL1/XA0GP+Mor6mU2+sj24V7YAD2YIUXUTtv5k pRBaWyCUxV7shhVVizTTVjo2IXs1diltdLuezISoel8/jp4gZQZTlw8prbQrH/xG9DgU dvDw== X-Gm-Message-State: AGRZ1gJeUC9UAoTpJmWyagyOdfQsIQLGukBYIn8/aR9epJj002YJ9J6L UptjVanC7/3iI7H20s3FB0SAV0LS7270y0oFYH2wRlE9 X-Google-Smtp-Source: AJdET5cli7FrVE588qxawhX6qIuSs78xy0D8hW9hcfDRxXUrtVERNl0NNC+Aep0IoXszSKWCgg3QavuikKBh3vtiLvU= X-Received: by 2002:a2e:117:: with SMTP id 23-v6mr9708972ljb.131.1541948142386; Sun, 11 Nov 2018 06:55:42 -0800 (PST) MIME-Version: 1.0 References: <1520324217.8785.3.camel@gmail.com> <92B8C822-9A79-4F93-944C-F4530FD8D62C@gmail.com> <17418B5C-6919-4E37-B97D-9723C6D71ED9@gmail.com> <7EE0A2B8-DA5D-4770-B970-9B14A97BE709@gmail.com> <64A33502-2AC5-4ED5-9087-F831127A7F3D@gmail.com> <5F3CC726-A246-4390-8763-58B8A98D3992@gmail.com> <05c2b04058e37a82067fd5cb064a938130c745fa.camel@gmail.com> <5C0B8B52-6A13-4010-8C5A-FD881D42C0B2@gmail.com> <17C4EFEB-3BA2-42C6-828C-F1623679672D@gmail.com> In-Reply-To: From: Maxim Muzafarov Date: Sun, 11 Nov 2018 17:55:32 +0300 Message-ID: Subject: Re: Code inspection To: dev@ignite.apache.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Igniters, Since the inspection rules are included in RunAll a few members of the community mentioned a wide distributed execution time on TC agents: - 1h:27m:38s publicagent17_9094 - 38m:04s publicagent17_9094 - 33m:29s publicagent17_9094 - 17m:13s publicagent17_9094 It seems that we should configure the resources distribution across TC containers. Can anyone take a look at it? I've also prepared the short list of rules to work on: + Inconsistent line separators (6 matches) + Problematic whitespace (4 matches) + expression.equals("literal")' rather than '"literal".equals(expression) (53 matches) + Unnecessary 'null' check before 'instanceof' expression or call (42 match= es) + Redundant 'if' statement (69 matches) + Redundant interface declaration (28 matches) + Double negation (0 matches) + Unnecessary code block (472 matches) + Line is longer than allowed by code style (2614 matches) (Is it possible to implement?) WDYT? On Fri, 26 Oct 2018 at 23:43, Dmitriy Pavlov wrote: > > Hi Maxim, > > thank you for your efforts to make this happen. Keep the pace! > > Could you please provide an example of how Inspections can fail, so I or > another contributor could implement support of these failures validation = in > the Tc Bot. > > Sincerely, > Dmitriy Pavlov > > =D0=BF=D1=82, 26 =D0=BE=D0=BA=D1=82. 2018 =D0=B3. =D0=B2 18:27, Yakov Zhd= anov : > > > Maxim, > > > > Thanks for response, let's do it the way you suggested. > > > > Please consider adding more checks > > - line endings. I think we should only have \n > > - ensure blank line in the end of file > > > > All these are code reviews issues I pointed out many times when reviewi= ng > > conributions. It would be cool if we have TC build failing if there is = any. > > > > Thanks! > > > > --Yakov > >