ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Denis Mekhanikov <dmekhani...@gmail.com>
Subject Re: Brainstorm: Make TC Run All faster
Date Thu, 15 Nov 2018 14:06:40 GMT
Dmitry, Sergey,

There is a common pattern in the test codebase, when each test starts its
own set of nodes,
and closes them after the test finishes.
Node startup takes quite a lot of time, and this time could be reduced, if
tests shared the same set of nodes.
I mean, if there is a test class with a lot of methods, then in many cases
it's enough to start nodes in *beforeTestsStarted*
and stop them in *afterTestsStopped* instead of doing it in every test case.
We should encourage contributors to use this pattern.

It's not applicable for all tests, and would violate isolation of tests,
but I think, it's a good trade-off,
because the running time of tests is a real problem.


чт, 15 нояб. 2018 г. в 15:11, Sergey Chugunov <sergey.chugunov@gmail.com>:

> Dmitriy,
> You brought up really important topic that has a great impact on our
> project. Faster runAlls mean quicker feedback and faster progress on issues
> and features.
> We have a pretty big code base of tests, about 50 thousands tests. Do we
> have an idea of how these tests overlap with each other? In my mind it is
> possible that we have a good bunch of tests that cover the same code and
> could be replaced with just a single test.
> In the ideal world we would even determine the minimal set of tests to
> cover our codebase and remove excessive.
> --
> Best regards,
> Sergey Chugunov.
> On Thu, Nov 15, 2018 at 2:34 PM Dmitriy Pavlov <dpavlov@apache.org> wrote:
> > Hi Igniters,
> >
> >
> >
> > Some of us started to use the Bot to get an approval of PRs. It helps to
> > protect master from new failures, but this requires to run RunAll tests
> set
> > for each commit and this makes markable pressure to TC infra.
> >
> >
> >
> > I would like to ask you to share your ideas on how to make runAll faster,
> > maybe you can share any of your measurements and any other info about
> > (possible) bottlenecks.
> >
> >
> >
> > Sincerely,
> >
> > Dmitriy Pavlov
> >

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message