ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitriy Pavlov <dpav...@apache.org>
Subject Re: Change code style inspections to use red mark for those used at Teamcity build checks (IGNITE-10450)
Date Wed, 28 Nov 2018 17:02:07 GMT
Hi Oleg,

Let's merge the change if we already have some, WDYT?

Sincerely,
Dmitriy Pavlov

ср, 28 нояб. 2018 г. в 19:40, oignatenko <oignatenko@gridgain.com>:

> Hello,
>
> When discussing issues involved in IGNITE-10399 we have got an idea to
> change color highlighting of some code style inspections to make it easier
> to see which can lead to problems at Teamcity.
>
> - Screen shot of how it is supposed to work:
>
>
> https://issues.apache.org/jira/secure/attachment/12949868/IDEA.inspections.TC-bot.png
>   ^^^ Violations of inspections used by TC are shown as red in IDEA Error
> Stripe while the rest remains yellow, looks easy to tell one from another.
> (It's probably not very important but for the sake of completeness a thing
> I
> noticed when testing this is that having red inspections didn't block
> compilation and execution of the code.)
>
> - JIRA ticket to change inspections:
>   https://issues.apache.org/jira/browse/IGNITE-10450
>
> - Prior discussions related to inspections checks at Teamcity:
>
>
> http://apache-ignite-developers.2346864.n4.nabble.com/Code-inspection-tp27709.html
>
> Your feedback is welcome.
>
> TIA,
> regards, Oleg
>
> PS. Special thanks to Maxim Muzafarov for help in brainstorming this matter
> and in drafting JIRA ticket.
>
>
>
> --
> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message