ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Muzafarov <maxmu...@gmail.com>
Subject Re: Code inspection
Date Sun, 11 Nov 2018 14:55:32 GMT
Igniters,

Since the inspection rules are included in RunAll a few members of the
community mentioned a wide distributed execution time on TC agents:
 - 1h:27m:38s publicagent17_9094
 - 38m:04s publicagent17_9094
 - 33m:29s publicagent17_9094
 - 17m:13s publicagent17_9094
It seems that we should configure the resources distribution across TC
containers. Can anyone take a look at it?


I've also prepared the short list of rules to work on:
+ Inconsistent line separators (6 matches)
+ Problematic whitespace (4 matches)
+ expression.equals("literal")' rather than
'"literal".equals(expression) (53 matches)
+ Unnecessary 'null' check before 'instanceof' expression or call (42 matches)
+ Redundant 'if' statement (69 matches)
+ Redundant interface declaration (28 matches)
+ Double negation (0 matches)
+ Unnecessary code block (472 matches)
+ Line is longer than allowed by code style (2614 matches) (Is it
possible to implement?)

WDYT?

On Fri, 26 Oct 2018 at 23:43, Dmitriy Pavlov <dpavlov.spb@gmail.com> wrote:
>
> Hi Maxim,
>
>  thank you for your efforts to make this happen. Keep the pace!
>
> Could you please provide an example of how Inspections can fail, so I or
> another contributor could implement support of these failures validation in
> the Tc Bot.
>
> Sincerely,
> Dmitriy Pavlov
>
> пт, 26 окт. 2018 г. в 18:27, Yakov Zhdanov <yzhdanov@apache.org>:
>
> > Maxim,
> >
> > Thanks for response, let's do it the way you suggested.
> >
> > Please consider adding more checks
> > - line endings. I think we should only have \n
> > - ensure blank line in the end of file
> >
> > All these are code reviews issues I pointed out many times when reviewing
> > conributions. It would be cool if we have TC build failing if there is any.
> >
> > Thanks!
> >
> > --Yakov
> >

Mime
View raw message