ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] SomeFire commented on a change in pull request #78: IGNITE-10203 Support for alternative configurations for PR testing
Date Fri, 23 Nov 2018 14:01:13 GMT
SomeFire commented on a change in pull request #78: IGNITE-10203 Support for alternative configurations
for PR testing
URL: https://github.com/apache/ignite-teamcity-bot/pull/78#discussion_r235915862
 
 

 ##########
 File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/ITeamcity.java
 ##########
 @@ -57,7 +54,12 @@
     @Deprecated
     long DEFAULT_BUILDS_COUNT = 1000;
 
-    CompletableFuture<List<BuildType>> getProjectSuites(String projectId);
+    /** {@inheritDoc} */
+    @Override default List<BuildTypeRef> getBuildTypes(String projectId) {
+        return FutureUtil.getResult(getProjectSuites(projectId));
+    }
+
+    CompletableFuture<List<BuildTypeRef>> getProjectSuites(String projectId);
 
 Review comment:
   Missed javadocs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message