ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] SomeFire commented on a change in pull request #74: IGNITE-10275 Refactor of visa caching. Jira spam fix.
Date Mon, 19 Nov 2018 12:43:50 GMT
SomeFire commented on a change in pull request #74: IGNITE-10275 Refactor of visa caching.
Jira spam fix.
URL: https://github.com/apache/ignite-teamcity-bot/pull/74#discussion_r234600605
 
 

 ##########
 File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildObserver.java
 ##########
 @@ -69,28 +93,27 @@ public void stop() {
     public void observe(String srvId, ICredentialsProv prov, String ticket, String branchForTc,
Build... builds) {
         BuildsInfo buildsInfo = new BuildsInfo(srvId, prov, ticket, branchForTc, builds);
 
-        visasStorage.put(new VisaRequest(buildsInfo));
-
         observerTask.addInfo(buildsInfo);
     }
 
     /**
      * @param srvId Server id.
      * @param branch Branch.
      */
-    public String getObservationStatus(String srvId, String branch) {
+    public String getObservationStatus(ContributionKey key) {
 
 Review comment:
   Update javadocs too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message