From dev-return-41042-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Oct 26 15:48:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C29EA180675 for ; Fri, 26 Oct 2018 15:48:03 +0200 (CEST) Received: (qmail 83353 invoked by uid 500); 26 Oct 2018 13:48:02 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 83342 invoked by uid 99); 26 Oct 2018 13:48:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Oct 2018 13:48:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 5FC8DC2272 for ; Fri, 26 Oct 2018 13:48:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -108.987 X-Spam-Level: X-Spam-Status: No, score=-108.987 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URI_HEX=1.313, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id GA092efv9q0Z for ; Fri, 26 Oct 2018 13:48:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 8BCCB5F494 for ; Fri, 26 Oct 2018 13:48:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BEB17E25D5 for ; Fri, 26 Oct 2018 13:48:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 32F412669E for ; Fri, 26 Oct 2018 13:48:00 +0000 (UTC) Date: Fri, 26 Oct 2018 13:48:00 +0000 (UTC) From: "Amelchev Nikita (JIRA)" To: dev@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (IGNITE-10023) Improve ListeningTestLogger for wait conditions. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Amelchev Nikita created IGNITE-10023: ---------------------------------------- Summary: Improve ListeningTestLogger for wait conditions. Key: IGNITE-10023 URL: https://issues.apache.org/jira/browse/IGNITE-10023 Project: Ignite Issue Type: Improvement Reporter: Amelchev Nikita Assignee: Amelchev Nikita Fix For: 2.8 [Dev-list=C2=A0discussion.|http://apache-ignite-developers.2346864.n4.nabbl= e.com/Unreliable-checks-in-tests-for-string-presence-in-GridStringLogger-co= ntents-td30802.html] Method=C2=A0LogListener.check() should be boolean type. It'll be useful for wait=C2=A0for conditions and code readability: For now: {code:java} waitForCondition(() -> {=C2=A0 =C2=A0try {=C2=A0 =C2=A0 =C2=A0lsnr.check();=C2=A0 =C2=A0 =C2=A0return true;=C2=A0 =C2=A0}=C2=A0 =C2=A0catch (AssertionError ignored) {=C2=A0 =C2=A0 =C2=A0return false;=C2=A0 =C2=A0}=C2=A0 }, timeout);=C2=A0 {code} After improvement: {code:java} waitForCondition(lsnr::check, timeout); {code} =C2=A0 =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)