From dev-return-40261-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Tue Oct 9 13:28:28 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B8B0618067A for ; Tue, 9 Oct 2018 13:28:27 +0200 (CEST) Received: (qmail 5762 invoked by uid 500); 9 Oct 2018 11:28:26 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 5739 invoked by uid 99); 9 Oct 2018 11:28:26 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Oct 2018 11:28:26 +0000 From: GitBox To: dev@ignite.apache.org Subject: [GitHub] SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run possible blockers' button Message-ID: <153908450616.26267.13080109052499232629.gitbox@gitbox.apache.org> Date: Tue, 09 Oct 2018 11:28:26 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run possible blockers' button URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r223661071 ########## File path: ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js ########## @@ -321,93 +343,82 @@ function notifyGit() { }); } -function triggerBuild(serverId, suiteId, branchName, top, observe, ticketId) { +function triggerBuilds(serverId, suiteIdList, branchName, top, observe, ticketId) { var queueAtTop = isDefinedAndFilled(top) && top; + var observeJira = isDefinedAndFilled(observe) && observe; + var suiteIdsNotFound = suiteIdList.length === 0; Review comment: Will not work if `suiteIdList` is a single suite or undefined. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services