ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xuchuanyin <...@git.apache.org>
Subject [GitHub] ignite pull request #5073: IGNITE-9995: Fix bugs in windows launch bat scrip...
Date Thu, 25 Oct 2018 08:23:14 GMT
GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/ignite/pull/5073

    IGNITE-9995: Fix bugs in windows launch bat script

    Problems:
    If user is under ignite source dir, launching ignite will cause "Input
    line is too long" error. While if user switch to another dir and lanunch
    ignite, this error will disappear.
    
    Analyze:
    This is because in the first scenario, the current working dir is just
    he IGNITE_HOME, this will cause ignite adding same pathes to classpath
    twice, thus causing a line in cmd too long.
    
    Solution:
    Avoiding adding the same path to classpath twice if current working dir
    is the same as IGNITE_HOME.
    Besides, we use the full path name instead of relative path name if
    current working dir is not the same as IGNITE_HOME.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/ignite 181025_bug_windows_bat

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/5073.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5073
    
----
commit df2186128fd585e479be2b61c66ef75a187caa7f
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-10-25T08:05:37Z

    Fix bugs in windows launch bat script
    
    Problems:
    If user is under ignite source dir, launching ignite will cause "Input
    line is too long" error. While if user switch to another dir and lanunch
    ignite, this error will disappear.
    
    Analyze:
    This is because in the first scenario, the current working dir is just
    he IGNITE_HOME, this will cause ignite adding same pathes to classpath
    twice, thus causing a line in cmd too long.
    
    Solution:
    Avoiding adding the same path to classpath twice if current working dir
    is the same as IGNITE_HOME.
    Besides, we use the full path name instead of relative path name if
    current working dir is not the same as IGNITE_HOME.

----


---

Mime
View raw message