ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitriy Pavlov <dpavlov....@gmail.com>
Subject Re: Code inspection
Date Fri, 26 Oct 2018 20:43:15 GMT
Hi Maxim,

 thank you for your efforts to make this happen. Keep the pace!

Could you please provide an example of how Inspections can fail, so I or
another contributor could implement support of these failures validation in
the Tc Bot.

Sincerely,
Dmitriy Pavlov

пт, 26 окт. 2018 г. в 18:27, Yakov Zhdanov <yzhdanov@apache.org>:

> Maxim,
>
> Thanks for response, let's do it the way you suggested.
>
> Please consider adding more checks
> - line endings. I think we should only have \n
> - ensure blank line in the end of file
>
> All these are code reviews issues I pointed out many times when reviewing
> conributions. It would be cool if we have TC build failing if there is any.
>
> Thanks!
>
> --Yakov
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message