ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yakov Zhdanov <yzhda...@apache.org>
Subject Re: Code inspection
Date Fri, 26 Oct 2018 14:41:14 GMT
Agree with Petr.

Maxim, what are our next steps? Can we add check for
- line length
- indents (tabs vs spaces)

This may require some efforts (will it and how much?), but can we add check
for:
- log messages structure
- log.warn() vs U.warn()
- abbreviations for local variables and fields.

And last question

> - the new configuration ignite_inspections_teamcity.xml added to PR;

Can this be installed locally by every contributor to check the code? Can
we add this to setup steps we have on wiki?

--Yakov

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message