ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Muzafarov <maxmu...@gmail.com>
Subject Re: Code inspection
Date Fri, 26 Oct 2018 15:17:31 GMT
Pert,

> As new way of testing code, this process will take it’s time to become
common, and then there will be no obsolete branches.

I tend to agree with you. Let's stabilize the solution first.


Yakov,

> Maxim, what are our next steps? Can we add check for
> - line length
> - indents (tabs vs spaces)

I'd like to focus on the ignite-core module first. I will prepare the short
list of first-priority inspections to enable and we will discuss it here.
After `Inspection:Core` stabilization and the discussion of proposed rules,
I will file new issues to do. Rules you mention is doable to enable.

> This may require some efforts (will it and how much?), but can we add
check
> for:
> - log messages structure
> - log.warn() vs U.warn()
> - abbreviations for local variables and fields.

I will try to find a simple solution for Ignite-specific
code-style requirements.
As for the abbreviations community decide to make them not mandatory [1].

> Can this be installed locally by every contributor to check the code?
> Can we add this to setup steps we have on wiki?

They are already mentioned in the `Coding Guidelines` community wiki page
[2].
This ignite_inspections_teamcity.xml configuration added only for the run
with TC and contains
enabled only some rules of original idea\ignite_inspections.xml
configuration.

[1]
http://apache-ignite-developers.2346864.n4.nabble.com/Abbreviation-code-style-requirement-tp36605.html
[2]
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-C.CodeInspection


On Fri, 26 Oct 2018 at 17:51 Petr Ivanov <mr.weider@gmail.com> wrote:

> Also, let me note that currently only modules/core/** is under inspection.
> And in spite of the fact that core is the “heaviest" module in project. it
> seems that adding new inspections should be 2-way: new inspections and new
> modules (builds).
>
>
> > On 26 Oct 2018, at 17:41, Yakov Zhdanov <yzhdanov@apache.org> wrote:
> >
> > Agree with Petr.
> >
> > Maxim, what are our next steps? Can we add check for
> > - line length
> > - indents (tabs vs spaces)
>
> Should not we start adding new inspections after current errors all have
> been eliminated?
>
>
> >
> > This may require some efforts (will it and how much?), but can we add
> check
> > for:
> > - log messages structure
> > - log.warn() vs U.warn()
> > - abbreviations for local variables and fields.
> >
> > And last question
> >
> >> - the new configuration ignite_inspections_teamcity.xml added to PR;
> >
> > Can this be installed locally by every contributor to check the code? Can
> > we add this to setup steps we have on wiki?
> >
> > --Yakov
>
> --
--
Maxim Muzafarov

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message